[Test] Remove dead code from ExceptionSerializationTests#34713
Merged
cbuescher merged 2 commits intoelastic:masterfrom Oct 23, 2018
Merged
[Test] Remove dead code from ExceptionSerializationTests#34713cbuescher merged 2 commits intoelastic:masterfrom
cbuescher merged 2 commits intoelastic:masterfrom
Conversation
The `ignore` set contains entries of type Class<?>, but the check is performed on Path objects. This always returns false so is useless currently. Looking at the first commit of this test that already shows this behaviour this never excluded anything, so it can be removed.
Collaborator
|
Pinging @elastic/es-core-infra |
alpar-t
reviewed
Oct 23, 2018
| if (ignore.contains(next)) { | ||
| return FileVisitResult.SKIP_SUBTREE; | ||
| } | ||
| pkgPrefix = next; |
Contributor
There was a problem hiding this comment.
Are you sure it's ok to remove this line ? Line 189 reads it.
Member
Author
There was a problem hiding this comment.
My reasoning is this: nothing in this method in this current form changes "next" (the contains() call should have no side effects), so next is still "pkgPrefix.resolve(dir.getFileName())" here, which is what I use to set pkgPrefix in the following line. Does that make sense? I'm not fully sure what the ignore.contains() check was supposed to do at some point, but I think it doesn't do anything now.
alpar-t
approved these changes
Oct 23, 2018
Contributor
alpar-t
left a comment
There was a problem hiding this comment.
My bad, I missed that next was really just in-lined.
Looks good.
Member
Author
|
@atorok thanks for the review, will merge to master |
jasontedor
added a commit
to jasontedor/elasticsearch
that referenced
this pull request
Oct 23, 2018
* master: (24 commits) ingest: better support for conditionals with simulate?verbose (elastic#34155) [Rollup] Job deletion should be invoked on the allocated task (elastic#34574) [DOCS] .Security index is never auto created (elastic#34589) CCR: Requires soft-deletes on the follower (elastic#34725) re-enable bwc tests (elastic#34743) Empty GetAliases authorization fix (elastic#34444) INGEST: Document Processor Conditional (elastic#33388) [CCR] Add total fetch time leader stat (elastic#34577) SQL: Support pattern against compatible indices (elastic#34718) [CCR] Auto follow pattern APIs adjustments (elastic#34518) [Test] Remove dead code from ExceptionSerializationTests (elastic#34713) A small typo in migration-assistance doc (elastic#34704) ingest: processor stats (elastic#34724) SQL: Implement IN(value1, value2, ...) expression. (elastic#34581) Tests: Add checks to GeoDistanceQueryBuilderTests (elastic#34273) INGEST: Rename Pipeline Processor Param. (elastic#34733) Core: Move IndexNameExpressionResolver to java time (elastic#34507) [DOCS] Force Merge: clarify execution and storage requirements (elastic#33882) TESTING.asciidoc fix examples using forbidden annotation (elastic#34515) SQL: Implement `CONVERT`, an alternative to `CAST` (elastic#34660) ...
kcm
pushed a commit
that referenced
this pull request
Oct 30, 2018
The `ignore` set contains entries of type Class<?>, but the check is performed on Path objects. This always returns false so is useless currently. Looking at the first commit of this test that already shows this behaviour this never excluded anything, so it can be removed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
ignoreset contains entries of type Class<?>, but the check is performedon Path objects. This always returns false so is useless currently. Looking at
the first commit of this test shows that this already was there from the start of this
test, so this behaviour seems to have never resulted in anything. My current guess is is
can be removed.