-
Notifications
You must be signed in to change notification settings - Fork 25.8k
[Tests] GeoDistanceQueryBuilderTests: add more checks #34043
Copy link
Copy link
Closed
Labels
:Analytics/GeoIndexing, search aggregations of geo points and shapesIndexing, search aggregations of geo points and shapes>enhancement>testIssues or PRs that are addressing/adding testsIssues or PRs that are addressing/adding tests
Description
Found this quite ancient TODO in GeoDistanceQueryBuilderTests#assertGeoDistanceRangeQuery that
we probably want to add a few checks to the GeoDistanceQueryBuilder that are being parsed in the
test. So far the only thing the test checks is that the parsing of the input Json Strings doesn't break.
It would be nice to add some way to do meaningfull assertions on the generated GeoDistanceQueryBuilder
instances and maybe even to the Lucene Queries generated later (although that is a bit harder).
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
:Analytics/GeoIndexing, search aggregations of geo points and shapesIndexing, search aggregations of geo points and shapes>enhancement>testIssues or PRs that are addressing/adding testsIssues or PRs that are addressing/adding tests
Type
Fields
Give feedbackNo fields configured for issues without a type.