[Inference API] Address AuthorizationTaskExecutorIT failures#144312
Merged
dimitris-athanasiou merged 3 commits intoelastic:mainfrom Mar 17, 2026
Merged
Conversation
This commit addresses failures in `AuthorizationTaskExecutorIT`. 1. test `testCreatesChatCompletion_AndThenCreatesTextEmbedding` now waits for the second endpoint to be created. As the second endpoint is discovered by the `AuthorizationPoller` we need to wait for the new endpoint to be stored. 2. tests based on `testEndpointGetsUpdated_GivenFingerprintChanged` now wait for inference system indices to be green (have their shards initialized) after the endpoint is stored. The latter guarantees the indices would have been created so that the `ensureGreen` call works as expected. Closes elastic#138012 Closes elastic#144249
Collaborator
|
Pinging @elastic/search-inference-team (Team:Search - Inference) |
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Organization UI (inherited) Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
📝 WalkthroughWalkthroughThis PR removes two muted test entries for AuthorizationTaskExecutorIT, updates AuthorizationTaskExecutorIT to add a Possibly related PRs
🚥 Pre-merge checks | ✅ 2✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Comment Tip You can get early access to new features in CodeRabbit.Enable the |
| assertThat(updated.endpointMetadata().internal().fingerprint(), is(updatedFingerprint)); | ||
| }); | ||
|
|
||
| deleteEndpoints(modelRegistry, Set.of(endpointId)); |
Contributor
There was a problem hiding this comment.
Hmm is endpointId a non-preconfigured endpoint? Shouldn't it already be deleted in the shutdown()?
Contributor
There was a problem hiding this comment.
We chatted offline, endpointId is a random string
jonathan-buttner
approved these changes
Mar 16, 2026
mosche
added a commit
to mosche/elasticsearch
that referenced
this pull request
Mar 20, 2026
Remove 6 muted-tests.yml entries where the corresponding GitHub issue has been closed: - elastic#138012: fixed in PR elastic#144312 - elastic#144169: fixed in PR elastic#144233 - elastic#144240: fixed in PR elastic#144233 - elastic#144246: fixed in PR elastic#144233 - elastic#144249: fixed in PR elastic#144312 - elastic#144392: fixed in PR elastic#144389 Made-with: Cursor
michalborek
pushed a commit
to michalborek/elasticsearch
that referenced
this pull request
Mar 23, 2026
…#144312) This commit addresses failures in `AuthorizationTaskExecutorIT`. 1. test `testCreatesChatCompletion_AndThenCreatesTextEmbedding` now waits for the second endpoint to be created. As the second endpoint is discovered by the `AuthorizationPoller` we need to wait for the new endpoint to be stored. 2. tests based on `testEndpointGetsUpdated_GivenFingerprintChanged` now wait for inference system indices to be green (have their shards initialized) after the endpoint is stored. The latter guarantees the indices would have been created so that the `ensureGreen` call works as expected. Closes elastic#138012 Closes elastic#144249
michalborek
pushed a commit
to michalborek/elasticsearch
that referenced
this pull request
Mar 23, 2026
Remove 6 muted-tests.yml entries where the corresponding GitHub issue has been closed: - elastic#138012: fixed in PR elastic#144312 - elastic#144169: fixed in PR elastic#144233 - elastic#144240: fixed in PR elastic#144233 - elastic#144246: fixed in PR elastic#144233 - elastic#144249: fixed in PR elastic#144312 - elastic#144392: fixed in PR elastic#144389 Made-with: Cursor
dimitris-athanasiou
added a commit
to dimitris-athanasiou/elasticsearch
that referenced
this pull request
Mar 30, 2026
This is a manual backport of fixes added in elastic#144312 and elastic#144736.
dimitris-athanasiou
added a commit
that referenced
this pull request
Mar 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit addresses failures in
AuthorizationTaskExecutorIT.testCreatesChatCompletion_AndThenCreatesTextEmbeddingnow waits for the second endpoint to be created. As the second endpoint is discovered by theAuthorizationPollerwe need to wait for the new endpoint to be stored.testEndpointGetsUpdated_GivenFingerprintChangednow wait for inference system indices to be green (have their shards initialized) after the endpoint is stored. The latter guarantees the indices would have been created so that theensureGreencall works as expected.Closes #138012
Closes #144249