[Inference API] Handle non-initialized shards in AuthorizationTaskExecutorIT by dimitris-athanasiou · Pull Request #144736 · elastic/elasticsearch

dimitris-athanasiou · 2026-03-23T11:27:41Z

Previous attempts at fixing this issue did not work because I was wrongly assuming that assertBusy retried when any exception was thrown. However, it only retries when an AssertionError is thrown.

The key method in the test that needs to wait for internal inference indices to be created is getEisEndpoints(). This commit catches SearchPhaseExecutionException and throws an AssertionError giving us a chance to retry this when getEisEndpoints() is called from within an assertBusy().

Closes #144671
Closes #144691
Closes #144731

…cutorIT Previous attempts at fixing this issue did not work because I was wrongly assuming that `assertBusy` retried when any exception was thrown. However, it only retries when an `AssertionError` is thrown. The key method in the test that needs to wait for internal inference indices to be created is `getEisEndpoints()`. This commit catches `SearchPhaseExecutionException` and throws an `AssertionError` giving us a chance to retry this when `getEisEndpoints()` is called from within an `assertBusy()`. Closes elastic#144671 Closes elastic#144691 Closes elastic#144731

elasticsearchmachine · 2026-03-23T11:28:05Z

Pinging @elastic/search-inference-team (Team:Search - Inference)

coderabbitai · 2026-03-23T11:31:27Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: c0b60c31-2e37-472f-b68a-fe3a22ba727b

📥 Commits

Reviewing files that changed from the base of the PR and between fbc2786 and a7f04e5.

📒 Files selected for processing (1)

muted-tests.yml

💤 Files with no reviewable changes (1)

muted-tests.yml

📝 Walkthrough

Walkthrough

The PR removes three muted-test entries for AuthorizationTaskExecutorIT from muted-tests.yml and updates AuthorizationTaskExecutorIT.getEisEndpoints(ModelRegistry) to catch SearchPhaseExecutionException: on that exception it calls fail() and returns an empty list instead of allowing the exception to propagate, preserving behavior when used inside retry logic such as assertBusy.

🚥 Pre-merge checks | ✅ 1 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Linked Issues check	❓ Inconclusive	PR directly addresses `#144671` and `#144731` by catching SearchPhaseExecutionException in getEisEndpoints() and converting to AssertionError for assertBusy retry logic, enabling test stabilization.	PR mentions `#144691` in description but changes only affect AuthorizationTaskExecutorIT tests, not RootFlattenedFromKeyedFieldDataTests. Clarify if `#144691` is in scope or if PR description has incorrect issue reference.

✅ Passed checks (1 passed)

Check name	Status	Explanation
Out of Scope Changes check	✅ Passed	All changes are scoped to AuthorizationTaskExecutorIT test stability: removed muted test entries and added exception handling for shard initialization timing.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

🛠️ Update Documentation: Commit on current branch
🛠️ Update Documentation: Create PR

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

DonalEvans · 2026-03-23T16:19:05Z

...sterTest/java/org/elasticsearch/xpack/inference/integration/AuthorizationTaskExecutorIT.java

+        try {
+            var endpoints = listener.actionGet(TimeValue.THIRTY_SECONDS);
+            return endpoints.stream().filter(m -> m.service().equals(ElasticInferenceService.NAME)).toList();
+        } catch (SearchPhaseExecutionException e) {
+            // This can happen if the internal inference indices shards have not been initialized yet.
+            // We fail so that when this is called in assertBusy we can retry.
+            fail();
+            return List.of();
+        }


This really makes me wish we were using JUnit 5 so we could use assertDoesNotThrow() here.

Jan-Kazlouski-elastic

Looks good to me!

…cutorIT (elastic#144736) Previous attempts at fixing this issue did not work because I was wrongly assuming that `assertBusy` retried when any exception was thrown. However, it only retries when an `AssertionError` is thrown. The key method in the test that needs to wait for internal inference indices to be created is `getEisEndpoints()`. This commit catches `SearchPhaseExecutionException` and throws an `AssertionError` giving us a chance to retry this when `getEisEndpoints()` is called from within an `assertBusy()`. Closes elastic#144671 Closes elastic#144691 Closes elastic#144731

This is a manual backport of fixes added in elastic#144312 and elastic#144736.

This is a manual backport of fixes added in #144312 and #144736.

…cutorIT (elastic#144736) Previous attempts at fixing this issue did not work because I was wrongly assuming that `assertBusy` retried when any exception was thrown. However, it only retries when an `AssertionError` is thrown. The key method in the test that needs to wait for internal inference indices to be created is `getEisEndpoints()`. This commit catches `SearchPhaseExecutionException` and throws an `AssertionError` giving us a chance to retry this when `getEisEndpoints()` is called from within an `assertBusy()`. Closes elastic#144671 Closes elastic#144691 Closes elastic#144731

dimitris-athanasiou added >test Issues or PRs that are addressing/adding tests :SearchOrg/Inference Label for the Search Inference team v9.4.0 labels Mar 23, 2026

elasticsearchmachine added the Team:Search - Inference label Mar 23, 2026

DonalEvans reviewed Mar 23, 2026

View reviewed changes

DonalEvans approved these changes Mar 23, 2026

View reviewed changes

dimitris-athanasiou added 2 commits March 24, 2026 12:05

Merge branch 'main' into handle-SPEE-in-AuthorizationTaskExecutorIT

a7f04e5

Merge branch 'main' into handle-SPEE-in-AuthorizationTaskExecutorIT

6ab198e

Jan-Kazlouski-elastic approved these changes Mar 25, 2026

View reviewed changes

Merge branch 'main' into handle-SPEE-in-AuthorizationTaskExecutorIT

e398746

dimitris-athanasiou merged commit 8a80908 into elastic:main Mar 26, 2026
36 checks passed

dimitris-athanasiou deleted the handle-SPEE-in-AuthorizationTaskExecutorIT branch March 26, 2026 12:39

This was referenced Mar 30, 2026

[CI] AuthorizationTaskExecutorIT testCreatesChatCompletion_AndThenCreatesTextEmbedding failing #144699

Closed

[9.3][TEST] Address AuthorizationTaskExecutorIT test failures #145201

Merged

dimitris-athanasiou added a commit to dimitris-athanasiou/elasticsearch that referenced this pull request Mar 30, 2026

[9.3][TEST] Address AuthorizationTaskExecutorIT test failures

b23ecee

This is a manual backport of fixes added in elastic#144312 and elastic#144736.

dimitris-athanasiou added a commit that referenced this pull request Mar 30, 2026

[9.3][TEST] Address AuthorizationTaskExecutorIT test failures (#145201)

57c510f

This is a manual backport of fixes added in #144312 and #144736.

jonathan-buttner mentioned this pull request Apr 8, 2026

[Inference API] Initializing inference indices #145938

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Inference API] Handle non-initialized shards in AuthorizationTaskExecutorIT#144736

[Inference API] Handle non-initialized shards in AuthorizationTaskExecutorIT#144736
dimitris-athanasiou merged 4 commits intoelastic:mainfrom
dimitris-athanasiou:handle-SPEE-in-AuthorizationTaskExecutorIT

dimitris-athanasiou commented Mar 23, 2026

Uh oh!

elasticsearchmachine commented Mar 23, 2026

Uh oh!

coderabbitai bot commented Mar 23, 2026 •

edited

Loading

Walkthrough

❌ Failed checks (1 inconclusive)

Uh oh!

DonalEvans Mar 23, 2026

Uh oh!

Jan-Kazlouski-elastic left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

dimitris-athanasiou commented Mar 23, 2026

Uh oh!

elasticsearchmachine commented Mar 23, 2026

Uh oh!

coderabbitai bot commented Mar 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

❌ Failed checks (1 inconclusive)

Uh oh!

DonalEvans Mar 23, 2026

Choose a reason for hiding this comment

Uh oh!

Jan-Kazlouski-elastic left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

coderabbitai bot commented Mar 23, 2026 •

edited

Loading