Skip to content

Fix approximation csvtests#144233

Merged
jan-elastic merged 2 commits intoelastic:mainfrom
jan-elastic:fix-approximation-csvtests
Mar 16, 2026
Merged

Fix approximation csvtests#144233
jan-elastic merged 2 commits intoelastic:mainfrom
jan-elastic:fix-approximation-csvtests

Conversation

@jan-elastic
Copy link
Copy Markdown
Contributor

@jan-elastic jan-elastic commented Mar 13, 2026

the bounds for some tests were too tight

fixes #144169 #144007 #144051 #144066 #144014 #144022 #144001

@elasticsearchmachine elasticsearchmachine added v9.4.0 needs:triage Requires assignment of a team area label labels Mar 13, 2026
@jan-elastic jan-elastic added >test Issues or PRs that are addressing/adding tests :ml Machine learning Team:ML Meta label for the ML team labels Mar 13, 2026
@elasticsearchmachine elasticsearchmachine removed the needs:triage Requires assignment of a team area label label Mar 13, 2026
@elasticsearchmachine
Copy link
Copy Markdown
Collaborator

Pinging @elastic/ml-core (Team:ML)

@jan-elastic jan-elastic force-pushed the fix-approximation-csvtests branch from cd12aa8 to a0247c7 Compare March 13, 2026 18:32
@jan-elastic jan-elastic enabled auto-merge (squash) March 13, 2026 18:33
@jan-elastic jan-elastic disabled auto-merge March 16, 2026 08:30
@jan-elastic jan-elastic merged commit baacf10 into elastic:main Mar 16, 2026
36 checks passed
ncordon pushed a commit to ncordon/elasticsearch that referenced this pull request Mar 16, 2026
* looser approximation csv tests

* unmute tests
szybia added a commit to szybia/elasticsearch that referenced this pull request Mar 16, 2026
…elocations

* upstream/main: (33 commits)
  Unmute InferenceRestIT and DefaultEndPointsIT (elastic#144217)
  feat: add keep_alive to async task status (elastic#144010)
  Add explicit isNoOpUpdate() method to MapperService (elastic#144113)
  Always attach APM Agent (elastic#144120)
  Fix random_score nightly tests (elastic#144176)
  Add nested query checks for disabled sequence numbers (elastic#144185)
  Return sentinel values from Fetch when sequence numbers are disabled (elastic#144212)
  [Test] Test peer-recovery with sequence numbers pruning (elastic#144116)
  Remove `scaled-*` field assertions from mixed cluster downsampling test (elastic#144295)
  Refactor: Use range syntax in ES|QL exponential histogram tests (elastic#144110)
  Move resolve aliases to IndexAbstractionOptions (elastic#143953)
  unmute test (elastic#144299)
  Fix approximation csvtests (elastic#144233)
  fix test (elastic#144171)
  Add int4 vector scoring benchmarks (elastic#144105)
  Mute org.elasticsearch.xpack.esql.qa.single_node.GenerativeIT test elastic#143023
  Mute org.elasticsearch.test.apmintegration.MetricsApmIT testApmIntegration {withOTel=false} elastic#144282
  Native cli launcher (elastic#143712)
  Mute org.elasticsearch.xpack.esql.qa.multi_node.GenerativeIT test elastic#143023
  Mute org.elasticsearch.xpack.esql.heap_attack.HeapAttackSubqueryIT testManyRandomKeywordFieldsInSubqueryIntermediateResults elastic#144274
  ...
mosche added a commit to mosche/elasticsearch that referenced this pull request Mar 20, 2026
Remove 6 muted-tests.yml entries where the corresponding GitHub
issue has been closed:

- elastic#138012: fixed in PR elastic#144312
- elastic#144169: fixed in PR elastic#144233
- elastic#144240: fixed in PR elastic#144233
- elastic#144246: fixed in PR elastic#144233
- elastic#144249: fixed in PR elastic#144312
- elastic#144392: fixed in PR elastic#144389

Made-with: Cursor
mosche added a commit that referenced this pull request Mar 20, 2026
Remove 6 muted-tests.yml entries where the corresponding GitHub
issue has been closed:

- #138012: fixed in PR #144312
- #144169: fixed in PR #144233
- #144240: fixed in PR #144233
- #144246: fixed in PR #144233
- #144249: fixed in PR #144312
- #144392: fixed in PR #144389

Made-with: Cursor
michalborek pushed a commit to michalborek/elasticsearch that referenced this pull request Mar 23, 2026
* looser approximation csv tests

* unmute tests
michalborek pushed a commit to michalborek/elasticsearch that referenced this pull request Mar 23, 2026
Remove 6 muted-tests.yml entries where the corresponding GitHub
issue has been closed:

- elastic#138012: fixed in PR elastic#144312
- elastic#144169: fixed in PR elastic#144233
- elastic#144240: fixed in PR elastic#144233
- elastic#144246: fixed in PR elastic#144233
- elastic#144249: fixed in PR elastic#144312
- elastic#144392: fixed in PR elastic#144389

Made-with: Cursor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:ml Machine learning Team:ML Meta label for the ML team >test Issues or PRs that are addressing/adding tests v9.4.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CI] CsvTests test {csv-spec:approximation.Approximate stats by on large multi-valued data} failing

2 participants