Fix append writes test for backing indices#144389
Merged
fcofdez merged 2 commits intoelastic:mainfrom Mar 17, 2026
Merged
Conversation
The test introduced in 17113ab incorrectly allowed INDEX with an id on backing indices regardless of seq_no_disabled. Assert it is only permitted when seq_no is disabled and rejected otherwise.
Collaborator
|
Pinging @elastic/es-distributed (Team:Distributed) |
Contributor
Author
|
I noticed this right after merging the PR 🤦 |
romseygeek
approved these changes
Mar 17, 2026
Contributor
Author
|
@elasticmachine update branch |
mosche
added a commit
to mosche/elasticsearch
that referenced
this pull request
Mar 20, 2026
Remove 6 muted-tests.yml entries where the corresponding GitHub issue has been closed: - elastic#138012: fixed in PR elastic#144312 - elastic#144169: fixed in PR elastic#144233 - elastic#144240: fixed in PR elastic#144233 - elastic#144246: fixed in PR elastic#144233 - elastic#144249: fixed in PR elastic#144312 - elastic#144392: fixed in PR elastic#144389 Made-with: Cursor
michalborek
pushed a commit
to michalborek/elasticsearch
that referenced
this pull request
Mar 23, 2026
The test introduced in 17113ab incorrectly allowed INDEX with an id on backing indices regardless of seq_no_disabled. Assert it is only permitted when seq_no is disabled and rejected otherwise. Closes elastic#144392
michalborek
pushed a commit
to michalborek/elasticsearch
that referenced
this pull request
Mar 23, 2026
Remove 6 muted-tests.yml entries where the corresponding GitHub issue has been closed: - elastic#138012: fixed in PR elastic#144312 - elastic#144169: fixed in PR elastic#144233 - elastic#144240: fixed in PR elastic#144233 - elastic#144246: fixed in PR elastic#144233 - elastic#144249: fixed in PR elastic#144312 - elastic#144392: fixed in PR elastic#144389 Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test introduced in 17113ab incorrectly allowed
INDEX with an id on backing indices regardless of
seq_no_disabled. Assert it is only permitted when seq_no
is disabled and rejected otherwise.
Closes #144392