fix(ci): Use correct READ_ONLY access value instead of READ#7239
Merged
Conversation
Contributor
|
This pull request does not have a backport label. Could you fix it @nuugen? 🙏
|
8 tasks
v1v
approved these changes
Mar 6, 2025
|
Contributor
💛 Build succeeded, but was flaky
Failed CI Stepscc @nuugen |
v1v
reviewed
Mar 6, 2025
| access_level: BUILD_AND_READ | ||
| everyone: | ||
| access_level: READ | ||
| access_level: READ_ONLY |
Member
There was a problem hiding this comment.
I think I took the above access level called BUILD_AND_READ and removed BUILD_AND, assuming it was enough :/ . It's undoubtedly misleading that _ONLY is needed; what else will be read if it's only read? Thanks for the fix Linh!
v1v
added a commit
to pkoutsovasilis/elastic-agent
that referenced
this pull request
Mar 6, 2025
* upstream/main: feat: bump go to 1.24.0 (elastic#6932) [CI] Fix Core DRA crossbuild (elastic#7203) fix(ci): Use correct `READ_ONLY` access value instead of `READ` (elastic#7239) ci(buildkite): add initial elastic-agent-helm-charts pipeline (elastic#7176) chore: update elastic-agent-libs to v0.18.8 (elastic#6938) [flakiness] Correct group for TestEndpointAgentServiceMonitoring (elastic#7165)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix the incorrect pipeline access value from
READtoREAD_ONLY. This was prompted by the validation failure at https://buildkite.com/elastic/terrazzo/builds/23681#01956b3e-2e25-45b3-bd6c-537cc5b00496.Why is it important?
Such that the pipeline is managed correctly by EngProd's automation.
Also, this can be prevented once #7240 is merged.
Checklist
./changelog/fragmentsusing the changelog toolDisruptive User Impact
How to test this PR locally
Related issues
Questions to ask yourself