Skip to content

[flakiness] Correct group for TestEndpointAgentServiceMonitoring#7165

Merged
pkoutsovasilis merged 2 commits intoelastic:mainfrom
pkoutsovasilis:ci/correct_endpoint_group
Mar 6, 2025
Merged

[flakiness] Correct group for TestEndpointAgentServiceMonitoring#7165
pkoutsovasilis merged 2 commits intoelastic:mainfrom
pkoutsovasilis:ci/correct_endpoint_group

Conversation

@pkoutsovasilis
Copy link
Copy Markdown
Contributor

@pkoutsovasilis pkoutsovasilis commented Mar 4, 2025 •
edited
Loading

What does this PR do?

This PR relocates TestEndpointAgentServiceMonitoring to the FleetEndpointSecurity execution group to prevent test failures caused by concurrent installation attempts of the Endpoint package when tests run in different groups.

Why is it important?

Reduces flakiness of Endpoint related tests that run in our CI

Checklist

  • I have read and understood the pull request guidelines of this project.
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in ./changelog/fragments using the changelog tool
  • I have added an integration test or an E2E test

Disruptive User Impact

How to test this PR locally

Related issues

@pkoutsovasilis pkoutsovasilis added Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team flaky-test Unstable or unreliable test cases. backport-active-all Automated backport with mergify to all the active branches labels Mar 4, 2025
@pkoutsovasilis pkoutsovasilis self-assigned this Mar 4, 2025
@elastic-sonarqube
Copy link
Copy Markdown

elastic-sonarqube bot commented Mar 4, 2025

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarQube

@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Mar 4, 2025

💚 Build Succeeded

History

cc @pkoutsovasilis

@pkoutsovasilis pkoutsovasilis marked this pull request as ready for review March 5, 2025 07:00
@pkoutsovasilis pkoutsovasilis requested a review from a team as a code owner March 5, 2025 07:00
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Mar 5, 2025

Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane)

@swiatekm
Copy link
Copy Markdown
Member

swiatekm commented Mar 5, 2025

Is this supposed to be a temporary fix? We may eventually want to run these tests concurrently, in which case I think we'd want to check if the package is installed before trying to install it?

@pkoutsovasilis
Copy link
Copy Markdown
Contributor Author

pkoutsovasilis commented Mar 5, 2025

Is this supposed to be a temporary fix? We may eventually want to run these tests concurrently, in which case I think we'd want to check if the package is installed before trying to install it?

I feel that we should first address the flakiness of how test are currently running, with the minimal blast radius (avoid adding extra flakiness) and then in a follow-up decide how these tests can be altered to support running concurrently. wdyt? 🙂

@pkoutsovasilis
Copy link
Copy Markdown
Contributor Author

pkoutsovasilis commented Mar 5, 2025

@dliappis @pazone since this regards a change that was introduced by the latest concurrent groups effort in the CI test execution I would appreciate a review from either of you 🙂

@pkoutsovasilis pkoutsovasilis merged commit 31aac31 into elastic:main Mar 6, 2025
14 checks passed
@pkoutsovasilis pkoutsovasilis deleted the ci/correct_endpoint_group branch March 6, 2025 08:20
mergify bot pushed a commit that referenced this pull request Mar 6, 2025
@pkoutsovasilis @mergify
[flakiness] Correct group for TestEndpointAgentServiceMonitoring (#7165)
195955d 
* fix: move TestEndpointAgentServiceMonitoring under FleetEndpointSecurity execution group

* fix: specify full endpoint path in pgrep and pkill of TestEndpointMetricsAfterRestart

(cherry picked from commit 31aac31)
mergify bot pushed a commit that referenced this pull request Mar 6, 2025
@pkoutsovasilis @mergify
[flakiness] Correct group for TestEndpointAgentServiceMonitoring (#7165)
cc10a3d 
* fix: move TestEndpointAgentServiceMonitoring under FleetEndpointSecurity execution group

* fix: specify full endpoint path in pgrep and pkill of TestEndpointMetricsAfterRestart

(cherry picked from commit 31aac31)
This was referenced Mar 6, 2025
Merged
Merged
mergify bot pushed a commit that referenced this pull request Mar 6, 2025
@pkoutsovasilis @mergify
[flakiness] Correct group for TestEndpointAgentServiceMonitoring (#7165)
58d8bcf 
* fix: move TestEndpointAgentServiceMonitoring under FleetEndpointSecurity execution group

* fix: specify full endpoint path in pgrep and pkill of TestEndpointMetricsAfterRestart

(cherry picked from commit 31aac31)
@mergify mergify bot mentioned this pull request Mar 6, 2025
Merged
8 tasks
mergify bot pushed a commit that referenced this pull request Mar 6, 2025
@pkoutsovasilis @mergify
[flakiness] Correct group for TestEndpointAgentServiceMonitoring (#7165)
7976461 
* fix: move TestEndpointAgentServiceMonitoring under FleetEndpointSecurity execution group

* fix: specify full endpoint path in pgrep and pkill of TestEndpointMetricsAfterRestart

(cherry picked from commit 31aac31)
mergify bot pushed a commit that referenced this pull request Mar 6, 2025
@pkoutsovasilis @mergify
[flakiness] Correct group for TestEndpointAgentServiceMonitoring (#7165)
e55e687 
* fix: move TestEndpointAgentServiceMonitoring under FleetEndpointSecurity execution group

* fix: specify full endpoint path in pgrep and pkill of TestEndpointMetricsAfterRestart

(cherry picked from commit 31aac31)
This was referenced Mar 6, 2025
Merged
Merged
pkoutsovasilis added a commit that referenced this pull request Mar 6, 2025
@mergify @pkoutsovasilis
[flakiness] Correct group for TestEndpointAgentServiceMonitoring (#7165…
d37a2f7 
…) (#7227)

* fix: move TestEndpointAgentServiceMonitoring under FleetEndpointSecurity execution group

* fix: specify full endpoint path in pgrep and pkill of TestEndpointMetricsAfterRestart

(cherry picked from commit 31aac31)

Co-authored-by: Panos Koutsovasilis <panos.koutsovasilis@elastic.co>
pkoutsovasilis added a commit that referenced this pull request Mar 6, 2025
@mergify @pkoutsovasilis
[flakiness] Correct group for TestEndpointAgentServiceMonitoring (#7165…
788b544 
…) (#7230)

* fix: move TestEndpointAgentServiceMonitoring under FleetEndpointSecurity execution group

* fix: specify full endpoint path in pgrep and pkill of TestEndpointMetricsAfterRestart

(cherry picked from commit 31aac31)

Co-authored-by: Panos Koutsovasilis <panos.koutsovasilis@elastic.co>
pkoutsovasilis added a commit that referenced this pull request Mar 6, 2025
@mergify @pkoutsovasilis
[flakiness] Correct group for TestEndpointAgentServiceMonitoring (#7165…
df48656 
…) (#7228)

* fix: move TestEndpointAgentServiceMonitoring under FleetEndpointSecurity execution group

* fix: specify full endpoint path in pgrep and pkill of TestEndpointMetricsAfterRestart

(cherry picked from commit 31aac31)

Co-authored-by: Panos Koutsovasilis <panos.koutsovasilis@elastic.co>
pkoutsovasilis added a commit that referenced this pull request Mar 6, 2025
@mergify @pkoutsovasilis
[flakiness] Correct group for TestEndpointAgentServiceMonitoring (#7165…
307ec89 
…) (#7229)

* fix: move TestEndpointAgentServiceMonitoring under FleetEndpointSecurity execution group

* fix: specify full endpoint path in pgrep and pkill of TestEndpointMetricsAfterRestart

(cherry picked from commit 31aac31)

Co-authored-by: Panos Koutsovasilis <panos.koutsovasilis@elastic.co>
pkoutsovasilis added a commit that referenced this pull request Mar 6, 2025
@mergify @pkoutsovasilis
[flakiness] Correct group for TestEndpointAgentServiceMonitoring (#7165…
85c9a6c 
…) (#7231)

* fix: move TestEndpointAgentServiceMonitoring under FleetEndpointSecurity execution group

* fix: specify full endpoint path in pgrep and pkill of TestEndpointMetricsAfterRestart

(cherry picked from commit 31aac31)

Co-authored-by: Panos Koutsovasilis <panos.koutsovasilis@elastic.co>
v1v added a commit to pkoutsovasilis/elastic-agent that referenced this pull request Mar 6, 2025
@v1v
Merge remote-tracking branch 'upstream/main' into feat/mage_helm_package
afa1caa 
* upstream/main:
  feat: bump go to 1.24.0 (elastic#6932)
  [CI] Fix Core DRA crossbuild (elastic#7203)
  fix(ci): Use correct `READ_ONLY` access value instead of `READ` (elastic#7239)
  ci(buildkite): add initial elastic-agent-helm-charts pipeline (elastic#7176)
  chore: update elastic-agent-libs to v0.18.8 (elastic#6938)
  [flakiness] Correct group for TestEndpointAgentServiceMonitoring (elastic#7165)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andrzej-stencel andrzej-stencel andrzej-stencel approved these changes

@swiatekm swiatekm swiatekm approved these changes

@michel-laterman michel-laterman Awaiting requested review from michel-laterman michel-laterman is a code owner automatically assigned from elastic/elastic-agent-control-plane

@dliappis dliappis Awaiting requested review from dliappis

@pazone pazone Awaiting requested review from pazone

Assignees

@pkoutsovasilis pkoutsovasilis

Labels

backport-active-all Automated backport with mergify to all the active branches flaky-test Unstable or unreliable test cases. skip-changelog Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@pkoutsovasilis @elasticmachine @swiatekm @andrzej-stencel