feat: bump go to 1.24.0 by kruskall · Pull Request #6932 · elastic/elastic-agent

kruskall · 2025-02-19T19:50:21Z

What does this PR do?

bump go to 1.24.0

Why is it important?

should help with fips among other things

Checklist

I have read and understood the pull request guidelines of this project.
My code follows the style guidelines of this project
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
I have made corresponding change to the default configuration files
I have added tests that prove my fix is effective or that my feature works
I have added an entry in ./changelog/fragments using the changelog tool
I have added an integration test or an E2E test

Disruptive User Impact

How to test this PR locally

Related issues

Questions to ask yourself

How are we going to support this in production?
How are we going to measure its adoption?
How are we going to debug this?
What are the metrics I should take care of?
...

mergify · 2025-02-19T19:50:58Z

This pull request does not have a backport label. Could you fix it @kruskall? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

backport-./d./d is the label that automatically backports to the 8./d branch. /d is the digit
backport-active-all is the label that automatically backports to all active branches.
backport-active-8 is the label that automatically backports to all active minor branches for the 8 major.
backport-active-9 is the label that automatically backports to all active minor branches for the 9 major.

cmacknz

Thanks! Set the backport 8.x label so that 9.1.0 and 8.19 will both release with Go 1.24.

pkoutsovasilis

I would like first the PR that adds the container packaging step in the CI and then merge this PR if our CI is green. Sorry for the delay

cc @dliappis

dliappis · 2025-02-21T18:07:59Z

I would like first the PR that adds the container packaging step in the CI and then merge this PR if our CI is green. Sorry for the delay

cc @dliappis

Agreed. I'd like to tread carefully here, and I don't see a pressing need to go to 1.24.0 right now since 1.23 is still supported.

kruskall · 2025-02-21T18:42:00Z

Agreed. I'd like to tread carefully here, and I don't see a pressing need to go to 1.24.0 right now since 1.23 is still supported.

This is true but 1.24 makes it a lot easier to test/prepare for fips compliance 🙂

I'd prefer not to delay this too much, (I'm also happy to tackle any required issue).

jlind23 · 2025-02-24T07:59:23Z

@dliappis @kruskall anything else than the eng prod review missing here? I can see that Craig approved and CI is green.

dliappis · 2025-02-24T10:25:33Z

@dliappis @kruskall anything else than the eng prod review missing here? I can see that Craig approved and CI is green.

Quality is paramount and don't want to land in a situation like #6948 where PR passed, but subsequent packaging jobs failed.

I'd prefer not merging until we are sure that CI has the additional coverage mentioned in the linked issue above.

simitt · 2025-02-24T12:24:23Z

We are really eager to get the update to go-1.24 in for easier handling with the FIPS work. But I agree we should have a high confidence level. @dliappis, are you referring to https://github.com/elastic/ingest-dev/issues/5115? Anything that we can help drive forward so that this PR can be driven forward?

I would like first the PR that adds the container packaging step in the CI and then merge this PR if our CI is green.

@pkoutsovasilis which PR or issue are you referring to?

pkoutsovasilis · 2025-02-24T12:31:14Z

I would like first the PR that adds the container packaging step in the CI and then merge this PR if our CI is green.

@pkoutsovasilis which PR or issue are you referring to?

@simitt I can assure you that everybody wants to see this PR merged ASAP and everyone understands the critically of go 1.24 for FIPS. That said, this PR is currently missing but it is being worked on, so we can introduce go 1.24 with confidence that we won't run into any similar issue as we did for go 1.23 (#6948) 🙂

simitt · 2025-02-24T14:02:39Z

@pkoutsovasilis thanks for linking the PR! My comment was not to create more pressure, I was simply not sure which PR is considered a precondition. The go.1.24 update will make certain things easier, but it is not currently blocking us, so I fully agree with stabilizing things first and having a good confidence level.

swiatekm · 2025-03-03T12:46:10Z

Packaging tests are failing because we're using the 1.23 crossbuild image to build the fips docker image. I'm guessing we missed a Go version update somewhere?

simitt · 2025-03-05T11:50:06Z

#6972 has been merged, @kruskall can you update this branch and then re-request a review? (~~might update to go-1.24.1 already though, see elastic/golang-crossbuild#529~~ -> let's stick with 1.24.0 for now as 1.24.1 PR is failing and don't want to be blocked until a new image can be released)

kruskall · 2025-03-05T11:59:35Z

@elastic/ingest-eng-prod friendly ping for review 🙂

simitt · 2025-03-06T10:06:14Z

buildkite test this

elastic-sonarqube · 2025-03-06T11:37:22Z

Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarQube

elasticmachine · 2025-03-06T12:39:06Z

💛 Build succeeded, but was flaky

Buildkite Build
Commit: 95dec1c

Failed CI Steps

Unit tests - Windows 2022

History

💔 Build #18108 failed 95dec1c
💚 Build #17898 succeeded d42b00c
💔 Build #17858 failed c50a7b6

cc @kruskall

* feat: bump go to 1.24.0 * lint: bump golangci-lint * lint: bump golangci-lint * Update .golangci.yml * Update .golangci.yml * build: bump go to 1.24.0 (cherry picked from commit 79c9886)

* feat: bump go to 1.24.0 * lint: bump golangci-lint * lint: bump golangci-lint * Update .golangci.yml * Update .golangci.yml * build: bump go to 1.24.0 (cherry picked from commit 79c9886) # Conflicts: # .github/workflows/golangci-lint.yml # .golangci.yml

kruskall · 2025-03-06T15:41:14Z

@Mergifyio backport 8.18

mergify · 2025-03-06T15:41:20Z

backport 8.18

✅ Backports have been created

Details

#7249 feat: bump go to 1.24.0 (backport #6932) has been created for branch 8.18 but encountered conflicts

* feat: bump go to 1.24.0 * lint: bump golangci-lint * lint: bump golangci-lint * Update .golangci.yml * Update .golangci.yml * build: bump go to 1.24.0 (cherry picked from commit 79c9886) # Conflicts: # .github/workflows/golangci-lint.yml # .golangci.yml

* feat: bump go to 1.24.0 (#6932) * feat: bump go to 1.24.0 * lint: bump golangci-lint * lint: bump golangci-lint * Update .golangci.yml * Update .golangci.yml * build: bump go to 1.24.0 (cherry picked from commit 79c9886) # Conflicts: # .github/workflows/golangci-lint.yml # .golangci.yml * Update golangci-lint.yml * Update .golangci.yml --------- Co-authored-by: kruskall <99559985+kruskall@users.noreply.github.com>

* upstream/main: feat: bump go to 1.24.0 (elastic#6932) [CI] Fix Core DRA crossbuild (elastic#7203) fix(ci): Use correct `READ_ONLY` access value instead of `READ` (elastic#7239) ci(buildkite): add initial elastic-agent-helm-charts pipeline (elastic#7176) chore: update elastic-agent-libs to v0.18.8 (elastic#6938) [flakiness] Correct group for TestEndpointAgentServiceMonitoring (elastic#7165)

* feat: bump go to 1.24.0 (#6932) * feat: bump go to 1.24.0 * lint: bump golangci-lint * lint: bump golangci-lint * Update .golangci.yml * Update .golangci.yml * build: bump go to 1.24.0 (cherry picked from commit 79c9886) # Conflicts: # .github/workflows/golangci-lint.yml # .golangci.yml * Update golangci-lint.yml * Update .golangci.yml --------- Co-authored-by: kruskall <99559985+kruskall@users.noreply.github.com>

* feat: bump go to 1.24.0 * lint: bump golangci-lint * lint: bump golangci-lint * Update .golangci.yml * Update .golangci.yml * build: bump go to 1.24.0 (cherry picked from commit 79c9886) Co-authored-by: kruskall <99559985+kruskall@users.noreply.github.com>

feat: bump go to 1.24.0

c87cd36

kruskall added the enhancement New feature or request label Feb 19, 2025

kruskall requested a review from a team as a code owner February 19, 2025 19:50

kruskall requested review from andrzej-stencel and michel-laterman February 19, 2025 19:50

mergify bot assigned kruskall Feb 19, 2025

kruskall added 2 commits February 19, 2025 20:56

lint: bump golangci-lint

2dc8ab8

lint: bump golangci-lint

cd9ad20

kruskall requested a review from a team as a code owner February 19, 2025 20:18

kruskall added 2 commits February 19, 2025 21:39

Update .golangci.yml

fe33ee9

Update .golangci.yml

621f562

cmacknz added the backport-8.x Automated backport to the 8.x branch with mergify label Feb 19, 2025

cmacknz previously approved these changes Feb 19, 2025

View reviewed changes

dliappis requested a review from pkoutsovasilis February 20, 2025 18:16

pkoutsovasilis reviewed Feb 20, 2025

View reviewed changes

pierrehilbert added the Team:Ingest-EngProd label Feb 21, 2025

kruskall mentioned this pull request Feb 28, 2025

Enhancement/5039 remove x crypto fips #7072

Merged

3 tasks

Merge branch 'main' into feat/bump-go-1.24

c50a7b6

build: bump go to 1.24.0

d42b00c

kruskall added the backport-9.0 Automated backport to the 9.0 branch label Mar 4, 2025

Merge branch 'main' into feat/bump-go-1.24

95dec1c

kruskall dismissed cmacknz’s stale review via 95dec1c March 5, 2025 17:03

simitt approved these changes Mar 6, 2025

View reviewed changes

jlind23 approved these changes Mar 6, 2025

View reviewed changes

pkoutsovasilis approved these changes Mar 6, 2025

View reviewed changes

kruskall merged commit 79c9886 into elastic:main Mar 6, 2025
14 checks passed

kruskall deleted the feat/bump-go-1.24 branch March 6, 2025 14:40

mergify bot mentioned this pull request Mar 6, 2025

[8.x](backport #6932) feat: bump go to 1.24.0 #7247

Merged

8 tasks

mergify bot mentioned this pull request Mar 6, 2025

[9.0](backport #6932) feat: bump go to 1.24.0 #7248

Merged

8 tasks

kruskall added the backport-8.18 Automated backport to the 8.18 branch label Mar 6, 2025

mergify bot mentioned this pull request Mar 6, 2025

[8.18] feat: bump go to 1.24.0 (backport #6932) #7249

Merged

8 tasks

This was referenced Mar 14, 2025

[8.x](backport #7072) Enhancement/5039 remove x crypto fips #7421

Merged

[9.0](backport #7072) Enhancement/5039 remove x crypto fips #7422

Merged

v1v mentioned this pull request Mar 24, 2025

[Automation] Bump Golang version to 1.24.1 #7454

Merged

This was referenced Mar 26, 2025

[8.16](backport #7531) build(deps): bump github.com/elastic/elastic-agent-system-metrics from 0.11.9 to 0.11.10 #7560

Closed

[8.17](backport #7531) build(deps): bump github.com/elastic/elastic-agent-system-metrics from 0.11.9 to 0.11.10 #7559

Closed

ycombinator mentioned this pull request Mar 16, 2026

Bump Go version to 1.25.8 #10156

Merged

Conversation

kruskall commented Feb 19, 2025

What does this PR do?

Why is it important?

Checklist

Disruptive User Impact

How to test this PR locally

Related issues

Questions to ask yourself

Uh oh!

mergify bot commented Feb 19, 2025

Uh oh!

cmacknz left a comment

Choose a reason for hiding this comment

Uh oh!

pkoutsovasilis left a comment

Choose a reason for hiding this comment

Uh oh!

dliappis commented Feb 21, 2025

Uh oh!

kruskall commented Feb 21, 2025

Uh oh!

jlind23 commented Feb 24, 2025

Uh oh!

dliappis commented Feb 24, 2025

Uh oh!

simitt commented Feb 24, 2025

Uh oh!

pkoutsovasilis commented Feb 24, 2025

Uh oh!

simitt commented Feb 24, 2025

Uh oh!

swiatekm commented Mar 3, 2025

Uh oh!

simitt commented Mar 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kruskall commented Mar 5, 2025

Uh oh!

simitt commented Mar 6, 2025

Uh oh!

elastic-sonarqube bot commented Mar 6, 2025

Quality Gate passed

Uh oh!

elasticmachine commented Mar 6, 2025

💛 Build succeeded, but was flaky

Failed CI Steps

History

Uh oh!

Uh oh!

kruskall commented Mar 6, 2025

Uh oh!

mergify bot commented Mar 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Backports have been created

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

simitt commented Mar 5, 2025 •

edited

Loading

mergify bot commented Mar 6, 2025 •

edited

Loading