Skip to content

[CI] Fix Core DRA crossbuild#7203

Merged
pazone merged 8 commits intomainfrom
ci_fix_dra_crossbuild
Mar 6, 2025
Merged

[CI] Fix Core DRA crossbuild#7203
pazone merged 8 commits intomainfrom
ci_fix_dra_crossbuild

Conversation

@pazone
Copy link
Copy Markdown

@pazone pazone commented Mar 5, 2025

What does this PR do?

Fixes Core DRA snapshot build by splittion the build step into separate steps

x86_64: Elastic-Agent Core Snapshot produces:

  • elastic-agent-core-9.1.0-SNAPSHOT-linux-x86_64.tar.gz
  • elastic-agent-core-9.1.0-SNAPSHOT-darwin-aarch64.tar.gz
  • elastic-agent-core-9.1.0-SNAPSHOT-darwin-x86_64.tar.gz
  • elastic-agent-core-9.1.0-SNAPSHOT-windows-x86_64.zip

ARM: Elastic-Agent Core Snapshot produces:

  • elastic-agent-core-9.1.0-SNAPSHOT-linux-arm64.tar.gz + sha + csv

Build example

Why is it important?

Checklist

  • I have read and understood the pull request guidelines of this project.
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in ./changelog/fragments using the changelog tool
  • I have added an integration test or an E2E test

Disruptive User Impact

How to test this PR locally

Related issues

Questions to ask yourself

  • How are we going to support this in production?
  • How are we going to measure its adoption?
  • How are we going to debug this?
  • What are the metrics I should take care of?
  • ...

@mergify mergify bot assigned pazone Mar 5, 2025
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Mar 5, 2025

This pull request does not have a backport label. Could you fix it @pazone? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-./d./d is the label that automatically backports to the 8./d branch. /d is the digit
  • backport-active-all is the label that automatically backports to all active branches.
  • backport-active-8 is the label that automatically backports to all active minor branches for the 8 major.
  • backport-active-9 is the label that automatically backports to all active minor branches for the 9 major.

@pazone pazone added skip-changelog backport-active-all Automated backport with mergify to all the active branches Team:Ingest-EngProd labels Mar 5, 2025
@pazone pazone marked this pull request as ready for review March 5, 2025 13:03
@pazone pazone requested a review from a team as a code owner March 5, 2025 13:03
@pazone pazone requested review from dliappis and pchila March 5, 2025 13:03
@pazone pazone marked this pull request as draft March 5, 2025 14:04
@pazone pazone marked this pull request as ready for review March 5, 2025 14:41
Pavel Zorin and others added 2 commits March 5, 2025 15:50
Co-authored-by: Paolo Chilà <paolo.chila@elastic.co>
Co-authored-by: Paolo Chilà <paolo.chila@elastic.co>
@dliappis
Copy link
Copy Markdown
Contributor

dliappis commented Mar 5, 2025

Last build when setting the right env vars:

DRA_BRANCH="main"
DRA_WORKFLOW="snapshot"
DRY_RUN="true"
RUN_SNAPSHOT="true"

seems to have passed: https://buildkite.com/elastic/elastic-agent-binary-dra/builds/2528#01956753-433a-4102-a15b-80508f139113

dliappis
dliappis previously approved these changes Mar 5, 2025
Copy link
Copy Markdown
Contributor

@dliappis dliappis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM based on #7203 (comment)

but I'd like to see @pchila 's or @pkoutsovasilis 's review too, in terms of whether the PLATFORMS vars are correct and whether we also need PACKAGE env vars.

@pazone pazone requested a review from pkoutsovasilis March 6, 2025 09:58
@dliappis dliappis self-requested a review March 6, 2025 12:08
Copy link
Copy Markdown
Contributor

@dliappis dliappis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks for iterating.

I compared the name and number of artifacts published using this PR vs the last successful build from main (https://buildkite.com/elastic/elastic-agent-binary-dra/builds/2506#0195652a-9f95-43b3-98b2-31752e9cf837) and they look identical.

@pazone pazone changed the title [CI] Fix DRA crossbuild [CI] Fix Core DRA crossbuild Mar 6, 2025
@pazone pazone requested a review from pchila March 6, 2025 12:16
@elastic-sonarqube
Copy link
Copy Markdown

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@elasticmachine
Copy link
Copy Markdown
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

History

cc @pazone

@pazone pazone merged commit d0548da into main Mar 6, 2025
10 checks passed
@pazone pazone deleted the ci_fix_dra_crossbuild branch March 6, 2025 14:36
mergify bot pushed a commit that referenced this pull request Mar 6, 2025
* [CI] Fix DRA crossbuild

* Added staging fix

* Fixed mistype

* Fixed darwin build

* Update .buildkite/pipeline.elastic-agent-binary-dra.yml

Co-authored-by: Paolo Chilà <paolo.chila@elastic.co>

* Update .buildkite/pipeline.elastic-agent-binary-dra.yml

Co-authored-by: Paolo Chilà <paolo.chila@elastic.co>

* replaced commas with spaces

---------

Co-authored-by: Paolo Chilà <paolo.chila@elastic.co>
(cherry picked from commit d0548da)
mergify bot pushed a commit that referenced this pull request Mar 6, 2025
* [CI] Fix DRA crossbuild

* Added staging fix

* Fixed mistype

* Fixed darwin build

* Update .buildkite/pipeline.elastic-agent-binary-dra.yml

Co-authored-by: Paolo Chilà <paolo.chila@elastic.co>

* Update .buildkite/pipeline.elastic-agent-binary-dra.yml

Co-authored-by: Paolo Chilà <paolo.chila@elastic.co>

* replaced commas with spaces

---------

Co-authored-by: Paolo Chilà <paolo.chila@elastic.co>
(cherry picked from commit d0548da)

# Conflicts:
#	.buildkite/pipeline.elastic-agent-binary-dra.yml
mergify bot pushed a commit that referenced this pull request Mar 6, 2025
* [CI] Fix DRA crossbuild

* Added staging fix

* Fixed mistype

* Fixed darwin build

* Update .buildkite/pipeline.elastic-agent-binary-dra.yml

Co-authored-by: Paolo Chilà <paolo.chila@elastic.co>

* Update .buildkite/pipeline.elastic-agent-binary-dra.yml

Co-authored-by: Paolo Chilà <paolo.chila@elastic.co>

* replaced commas with spaces

---------

Co-authored-by: Paolo Chilà <paolo.chila@elastic.co>
(cherry picked from commit d0548da)
mergify bot pushed a commit that referenced this pull request Mar 6, 2025
* [CI] Fix DRA crossbuild

* Added staging fix

* Fixed mistype

* Fixed darwin build

* Update .buildkite/pipeline.elastic-agent-binary-dra.yml

Co-authored-by: Paolo Chilà <paolo.chila@elastic.co>

* Update .buildkite/pipeline.elastic-agent-binary-dra.yml

Co-authored-by: Paolo Chilà <paolo.chila@elastic.co>

* replaced commas with spaces

---------

Co-authored-by: Paolo Chilà <paolo.chila@elastic.co>
(cherry picked from commit d0548da)
mergify bot pushed a commit that referenced this pull request Mar 6, 2025
* [CI] Fix DRA crossbuild

* Added staging fix

* Fixed mistype

* Fixed darwin build

* Update .buildkite/pipeline.elastic-agent-binary-dra.yml

Co-authored-by: Paolo Chilà <paolo.chila@elastic.co>

* Update .buildkite/pipeline.elastic-agent-binary-dra.yml

Co-authored-by: Paolo Chilà <paolo.chila@elastic.co>

* replaced commas with spaces

---------

Co-authored-by: Paolo Chilà <paolo.chila@elastic.co>
(cherry picked from commit d0548da)
v1v added a commit to pkoutsovasilis/elastic-agent that referenced this pull request Mar 6, 2025
* upstream/main:
  feat: bump go to 1.24.0 (elastic#6932)
  [CI] Fix Core DRA crossbuild (elastic#7203)
  fix(ci): Use correct `READ_ONLY` access value instead of `READ` (elastic#7239)
  ci(buildkite): add initial elastic-agent-helm-charts pipeline (elastic#7176)
  chore: update elastic-agent-libs to v0.18.8 (elastic#6938)
  [flakiness] Correct group for TestEndpointAgentServiceMonitoring (elastic#7165)
pazone pushed a commit that referenced this pull request Mar 7, 2025
* [CI] Fix DRA crossbuild

* Added staging fix

* Fixed mistype

* Fixed darwin build

* Update .buildkite/pipeline.elastic-agent-binary-dra.yml

Co-authored-by: Paolo Chilà <paolo.chila@elastic.co>

* Update .buildkite/pipeline.elastic-agent-binary-dra.yml

Co-authored-by: Paolo Chilà <paolo.chila@elastic.co>

* replaced commas with spaces

---------

Co-authored-by: Paolo Chilà <paolo.chila@elastic.co>
(cherry picked from commit d0548da)

Co-authored-by: Pavel Zorin <pavel.zorin@elastic.co>
pazone pushed a commit that referenced this pull request Mar 7, 2025
* [CI] Fix DRA crossbuild

* Added staging fix

* Fixed mistype

* Fixed darwin build

* Update .buildkite/pipeline.elastic-agent-binary-dra.yml

Co-authored-by: Paolo Chilà <paolo.chila@elastic.co>

* Update .buildkite/pipeline.elastic-agent-binary-dra.yml

Co-authored-by: Paolo Chilà <paolo.chila@elastic.co>

* replaced commas with spaces

---------

Co-authored-by: Paolo Chilà <paolo.chila@elastic.co>
(cherry picked from commit d0548da)

Co-authored-by: Pavel Zorin <pavel.zorin@elastic.co>
pazone pushed a commit that referenced this pull request Mar 7, 2025
* [CI] Fix Core DRA crossbuild (#7203)

* [CI] Fix DRA crossbuild

* Added staging fix

* Fixed mistype

* Fixed darwin build

* Update .buildkite/pipeline.elastic-agent-binary-dra.yml

Co-authored-by: Paolo Chilà <paolo.chila@elastic.co>

* Update .buildkite/pipeline.elastic-agent-binary-dra.yml

Co-authored-by: Paolo Chilà <paolo.chila@elastic.co>

* replaced commas with spaces

---------

Co-authored-by: Paolo Chilà <paolo.chila@elastic.co>
(cherry picked from commit d0548da)

# Conflicts:
#	.buildkite/pipeline.elastic-agent-binary-dra.yml

* Resolved conflicts

---------

Co-authored-by: Pavel Zorin <pavel.zorin@elastic.co>
pazone pushed a commit that referenced this pull request Mar 7, 2025
* [CI] Fix DRA crossbuild

* Added staging fix

* Fixed mistype

* Fixed darwin build

* Update .buildkite/pipeline.elastic-agent-binary-dra.yml

Co-authored-by: Paolo Chilà <paolo.chila@elastic.co>

* Update .buildkite/pipeline.elastic-agent-binary-dra.yml

Co-authored-by: Paolo Chilà <paolo.chila@elastic.co>

* replaced commas with spaces

---------

Co-authored-by: Paolo Chilà <paolo.chila@elastic.co>
(cherry picked from commit d0548da)

Co-authored-by: Pavel Zorin <pavel.zorin@elastic.co>
pazone pushed a commit that referenced this pull request Mar 7, 2025
* [CI] Fix DRA crossbuild

* Added staging fix

* Fixed mistype

* Fixed darwin build

* Update .buildkite/pipeline.elastic-agent-binary-dra.yml

Co-authored-by: Paolo Chilà <paolo.chila@elastic.co>

* Update .buildkite/pipeline.elastic-agent-binary-dra.yml

Co-authored-by: Paolo Chilà <paolo.chila@elastic.co>

* replaced commas with spaces

---------

Co-authored-by: Paolo Chilà <paolo.chila@elastic.co>
(cherry picked from commit d0548da)

Co-authored-by: Pavel Zorin <pavel.zorin@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-active-all Automated backport with mergify to all the active branches skip-changelog Team:Ingest-EngProd

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants