This repository was archived by the owner on Sep 17, 2024. It is now read-only.
fix: always quote variables in shell scripts#2284
Merged
mdelapenya merged 7 commits intoelastic:mainfrom Mar 29, 2022
Merged
Conversation
Contributor
💔 Tests Failed
Expand to view the summary
Build stats
Test stats 🧪
Test errors
Expand to view the tests failures
|
v1v
approved these changes
Mar 29, 2022
mdelapenya
commented
Mar 29, 2022
| } | ||
|
|
||
| // Skip scenarios per platform | ||
| tags += " && ~@skip:${goArch}" |
Contributor
Author
There was a problem hiding this comment.
Removed because we do not need to skip by arch at the tag level, but at the .e2e-testing.yaml descriptor
mdelapenya
added a commit
that referenced
this pull request
Mar 29, 2022
* chore: remove @Skip:platform tags * fix: do not use the @Skip:platform tag in pipeline * fix: quote variables as much as possible * chore: always quote shell variables * fix: more double quotes * fix: more quotes (cherry picked from commit ed5a86e) Co-authored-by: Manuel de la Peña <mdelapenya@gmail.com>
mdelapenya
added a commit
that referenced
this pull request
Mar 29, 2022
* chore: remove @Skip:platform tags * fix: do not use the @Skip:platform tag in pipeline * fix: quote variables as much as possible * chore: always quote shell variables * fix: more double quotes * fix: more quotes (cherry picked from commit ed5a86e) Co-authored-by: Manuel de la Peña <mdelapenya@gmail.com>
mdelapenya
added a commit
that referenced
this pull request
Mar 29, 2022
* chore: remove @Skip:platform tags * fix: do not use the @Skip:platform tag in pipeline * fix: quote variables as much as possible * chore: always quote shell variables * fix: more double quotes * fix: more quotes (cherry picked from commit ed5a86e) Co-authored-by: Manuel de la Peña <mdelapenya@gmail.com>
mdelapenya
added a commit
to mdelapenya/e2e-testing
that referenced
this pull request
Mar 30, 2022
* main: (72 commits) fix: always quote variables in shell scripts (elastic#2284) chore: bring back system integration scenarios (elastic#2233) chore: do not notify build green for fleet nightly builds (elastic#2277) chore: include suite, platform and tags in test reports name (elastic#2273) bump stack version 8.2.0-dcff22d7 (elastic#2270) bump stack version 8.2.0-4509f321 (elastic#2265) chore: bump Godog to v0.12.4 (elastic#2245) bump stack version 8.2.0-5cc993c1 (elastic#2254) bump stack version 8.2.0-82b803a1 (elastic#2250) fix: never process elasticsearch CI artifacts (elastic#2246) bump stack version 8.2.0-ff67d7b8 (elastic#2242) ci: periodic builds for the last two minor versions (elastic#2241) bump stack version 8.2.0-9bac538c (elastic#2240) fix: add end-of-file line in templates (elastic#2237) chore: add Christos to SSH users bump stack version 8.2.0-fee3b8d2 (elastic#2234) Separate ES workload from Agent spec and make it req for the scenarios (elastic#2203) bump stack version 8.2.0-d02c907a (elastic#2228) bump stack version 8.2.0-63265ec9 (elastic#2225) fix: wrong link (elastic#2220) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@skip:platformtags@skip:platformtag in pipelineWhat does this PR do?
We are always double-quoting the values for the shell variables that are used to configure the test execution, and that is done here:
.ci/scripts/functiona-test.shFinally, because we are controlling what scenarios to run on each supported platform using the CI descriptors (see
.ci/.e2e-tests.yaml), we do not need the@skip:platformGherkin annotation, which was used in the past to skip certain scenarios per platform.With current approach, simply adding/removing the platform from the scenario in that CI descriptor would do it.
Why is it important?
We introduced a regression in #2273, because when sourcing the .env file including a variable with whitespaces on its value, then it does not consider it and directly executes it.
This is the case in:
Checklist
make unit-test), and they are passing locallymake noticein the proper directory)How to test this PR locally
Related issues