This repository was archived by the owner on Sep 17, 2024. It is now read-only.
chore: include suite, platform and tags in test reports name#2273
Merged
mdelapenya merged 2 commits intoelastic:mainfrom Mar 28, 2022
Merged
chore: include suite, platform and tags in test reports name#2273mdelapenya merged 2 commits intoelastic:mainfrom
mdelapenya merged 2 commits intoelastic:mainfrom
Conversation
mdelapenya
commented
Mar 28, 2022
| def envContext = [] | ||
| envContext.add("PROVIDER=${provider}") | ||
| envContext.add("SUITE=${suite}") | ||
| envContext.add("REPORT_PREFIX=${suite}_${platform}_${tags}") |
Contributor
Author
There was a problem hiding this comment.
Same as the parallel stage name
v1v
reviewed
Mar 28, 2022
.ci/scripts/functional-test.sh
Outdated
| BEAT_VERSION=${4:-"${BASE_VERSION}"} | ||
| ELASTIC_AGENT_VERSION=${5:-"${BASE_VERSION}"} | ||
| GOARCH=${GOARCH:-"amd64"} | ||
| REPORT_PREFIX="${SUITE}_${GOARCH}_${TAGS}" |
Member
There was a problem hiding this comment.
What do you think to allow overriding the value only if REPORT_PREFIX is not set? IIUC,
https://github.com/elastic/e2e-testing/pull/2273/files#diff-ef8b2f5e4d21d81c0eba4754dea3a3dfc2c67d26284f195165b650cf4aff7beaR564 uses .ci/scripts/functional-test.sh with only one parameter, so REPORT_PREFIX="${SUITE}_${GOARCH}_${TAGS}" = REPORT_PREFIX=${tags}_ amd64_" but REPORT_PREFIX is already in place as it's created on the fly in the jenkinsfile
Contributor
Author
There was a problem hiding this comment.
That could be fine too. My only concern is that the script that is run on CI is generated on the fly in the Ansible code, and this is different to the committed script. I'd try to align them as much as possible
kuisathaverat
approved these changes
Mar 28, 2022
mdelapenya
commented
Mar 28, 2022
Contributor
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
💚 Flaky test reportTests succeeded. 🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
mergify bot
pushed a commit
that referenced
this pull request
Mar 28, 2022
* chore: include suite, platform and tags in test reports name * chore: read existing value first (cherry picked from commit e516dc9)
mergify bot
pushed a commit
that referenced
this pull request
Mar 28, 2022
* chore: include suite, platform and tags in test reports name * chore: read existing value first (cherry picked from commit e516dc9)
mergify bot
pushed a commit
that referenced
this pull request
Mar 28, 2022
* chore: include suite, platform and tags in test reports name * chore: read existing value first (cherry picked from commit e516dc9)
mdelapenya
added a commit
that referenced
this pull request
Mar 28, 2022
mdelapenya
added a commit
that referenced
this pull request
Mar 28, 2022
mdelapenya
added a commit
that referenced
this pull request
Mar 28, 2022
8 tasks
mdelapenya
added a commit
to mdelapenya/e2e-testing
that referenced
this pull request
Mar 30, 2022
* main: (72 commits) fix: always quote variables in shell scripts (elastic#2284) chore: bring back system integration scenarios (elastic#2233) chore: do not notify build green for fleet nightly builds (elastic#2277) chore: include suite, platform and tags in test reports name (elastic#2273) bump stack version 8.2.0-dcff22d7 (elastic#2270) bump stack version 8.2.0-4509f321 (elastic#2265) chore: bump Godog to v0.12.4 (elastic#2245) bump stack version 8.2.0-5cc993c1 (elastic#2254) bump stack version 8.2.0-82b803a1 (elastic#2250) fix: never process elasticsearch CI artifacts (elastic#2246) bump stack version 8.2.0-ff67d7b8 (elastic#2242) ci: periodic builds for the last two minor versions (elastic#2241) bump stack version 8.2.0-9bac538c (elastic#2240) fix: add end-of-file line in templates (elastic#2237) chore: add Christos to SSH users bump stack version 8.2.0-fee3b8d2 (elastic#2234) Separate ES workload from Agent spec and make it req for the scenarios (elastic#2203) bump stack version 8.2.0-d02c907a (elastic#2228) bump stack version 8.2.0-63265ec9 (elastic#2225) fix: wrong link (elastic#2220) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
It adds a prefix to the test report names so that it's easier to look them up in the Jenkins UI. In the past, the report name was created calling
unamein the remote VM, now it uses the metadata coming from the platform descriptorsWhy is it important?
Consistency about file names, and adding discoverability when reading reports in the Jenkins UI
Checklist
make unit-test), and they are passing locallymake noticein the proper directory)Related issues