Skip to content
This repository was archived by the owner on Sep 17, 2024. It is now read-only.

fix: add end-of-file line in templates#2237

Merged
mdelapenya merged 1 commit intoelastic:mainfrom
mdelapenya:fix-end-of-file-templates
Mar 15, 2022
Merged

fix: add end-of-file line in templates#2237
mdelapenya merged 1 commit intoelastic:mainfrom
mdelapenya:fix-end-of-file-templates

Conversation

@mdelapenya
Copy link
Copy Markdown
Contributor

What does this PR do?

It fixes the warning of pre-commit for the YAML templates, regarding the end-of-file hook.

Why is it important?

Pre-commit stage adds a warning

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have run the Unit tests (make unit-test), and they are passing locally
  • I have run the End-2-End tests for the suite I'm working on, and they are passing locally
  • I have noticed new Go dependencies (run make notice in the proper directory)

Related issues

@mdelapenya mdelapenya added the backport-skip Skip notification from the automated backport with mergify label Mar 15, 2022
@mdelapenya mdelapenya self-assigned this Mar 15, 2022
@mdelapenya mdelapenya requested review from a team and ChrsMark March 15, 2022 06:28
@mdelapenya
Copy link
Copy Markdown
Contributor Author

I'm not adding the backport labels because I already fixed the backport PRs one by one. See #2230 #2231 and #2232

@elasticmachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-03-15T06:28:27.178+0000

  • Duration: 53 min 36 sec

Test stats 🧪

Test Results
Failed 0
Passed 276
Skipped 0
Total 276

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@mdelapenya mdelapenya merged commit 225907c into elastic:main Mar 15, 2022
@mdelapenya mdelapenya deleted the fix-end-of-file-templates branch March 16, 2022 09:14
mdelapenya added a commit that referenced this pull request Mar 17, 2022
* main: (268 commits)
  bump stack version 8.2.0-ff67d7b8 (#2242)
  ci: periodic builds for the last two minor versions (#2241)
  bump stack version 8.2.0-9bac538c (#2240)
  fix: add end-of-file line in templates (#2237)
  chore: add Christos to SSH users
  bump stack version 8.2.0-fee3b8d2 (#2234)
  Separate ES workload from Agent spec and make it req for the scenarios (#2203)
  bump stack version 8.2.0-d02c907a (#2228)
  bump stack version 8.2.0-63265ec9 (#2225)
  fix: wrong link (#2220)
  chore: define provider for each test suite (#2213)
  ci: provision e2-small workers (#2212)
  bump stack version 8.2.0-a12f7069 (#2209)
  chore: support for Oracle Linux 8 (#2208)
  bump stack version 8.2.0-190af159 (#2206)
  bump stack version 8.2.0-fdde08ec (#2200)
  bump stack version 8.2.0-43df679f (#2193)
  chore: use trace level in logs (#2130)
  bump stack version 8.2.0-bdf2ad74 (#2188)
  feat: support downloading project artifacts for the new bucket layout (#2172)
  ...
mdelapenya added a commit to mdelapenya/e2e-testing that referenced this pull request Mar 30, 2022
* main: (72 commits)
  fix: always quote variables in shell scripts (elastic#2284)
  chore: bring back system integration scenarios (elastic#2233)
  chore: do not notify build green for fleet nightly builds (elastic#2277)
  chore: include suite, platform and tags in test reports name (elastic#2273)
  bump stack version 8.2.0-dcff22d7 (elastic#2270)
  bump stack version 8.2.0-4509f321 (elastic#2265)
  chore: bump Godog to v0.12.4 (elastic#2245)
  bump stack version 8.2.0-5cc993c1 (elastic#2254)
  bump stack version 8.2.0-82b803a1 (elastic#2250)
  fix: never process elasticsearch CI artifacts (elastic#2246)
  bump stack version 8.2.0-ff67d7b8 (elastic#2242)
  ci: periodic builds for the last two minor versions (elastic#2241)
  bump stack version 8.2.0-9bac538c (elastic#2240)
  fix: add end-of-file line in templates (elastic#2237)
  chore: add Christos to SSH users
  bump stack version 8.2.0-fee3b8d2 (elastic#2234)
  Separate ES workload from Agent spec and make it req for the scenarios (elastic#2203)
  bump stack version 8.2.0-d02c907a (elastic#2228)
  bump stack version 8.2.0-63265ec9 (elastic#2225)
  fix: wrong link (elastic#2220)
  ...
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

backport-skip Skip notification from the automated backport with mergify

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants