Skip to content
This repository was archived by the owner on Sep 17, 2024. It is now read-only.

chore: support for Oracle Linux 8#2208

Merged
mdelapenya merged 7 commits intoelastic:mainfrom
mdelapenya:oracle-linux
Mar 7, 2022
Merged

chore: support for Oracle Linux 8#2208
mdelapenya merged 7 commits intoelastic:mainfrom
mdelapenya:oracle-linux

Conversation

@mdelapenya
Copy link
Copy Markdown
Contributor

What does this PR do?

It adds support for Oracle Linux 8 for the "running-on-beats" scenarios.

Why is it important?

Increase the support matrix

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have run the Unit tests (make unit-test), and they are passing locally
  • I have run the End-2-End tests for the suite I'm working on, and they are passing locally
  • I have noticed new Go dependencies (run make notice in the proper directory)

Author's Checklist

  • @jlind23 could you add the backport labels please? I do not see Oracle Linux in the support matrix spreadsheet so I'm not sure which branches should be used

Related issues

@mdelapenya mdelapenya added Team:Automation Label for the Observability productivity team Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team area:ci Anything related to the CI area:test Anything related to the Test automation size:S less than 1 day labels Mar 4, 2022
@mdelapenya mdelapenya self-assigned this Mar 4, 2022
@mdelapenya mdelapenya requested review from a team and jlind23 March 4, 2022 09:26
username: admin
oracle_linux8:
image: "ami-00371eeb8fd8e0e16"
instance_type: "c5.2xlarge"
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trying with a smaller instance 🤞

Copy link
Copy Markdown
Member

@v1v v1v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Unrelated, could .ci/.e2e-tests.yaml and .ci/.e2e-tests-for-elastic-agent.yaml be renamed with something about daily/nightly? IIUC, this change will affect only the nightly builds, but the name of those files are not representing when they are used, just thinking if it could be helpful

@mdelapenya
Copy link
Copy Markdown
Contributor Author

+1

Unrelated, could .ci/.e2e-tests.yaml and .ci/.e2e-tests-for-elastic-agent.yaml be renamed with something about daily/nightly? IIUC, this change will affect only the nightly builds, but the name of those files are not representing when they are used, just thinking if it could be helpful

Indeed. I see those files as the metadata driving the execution (connecting VM settings, test suites, cucumber tags and jenkins parallel stages), so names that come to my mind are:

  • .e2e-tests.yaml > .stages-settings.yml
  • .e2e-tests-for-elastic-agent.yaml > .stages-settings-elastic-agent.yml (as it's triggered by the elastic-agent and beats repositories)

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Mar 4, 2022

This pull request does not have a backport label. Could you fix it @mdelapenya? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v./d./d./d is the label to automatically backport to the 7./d branch. /d is the digit
    NOTE: backport-skip has been added to this pull request.

@mergify mergify bot added the backport-skip Skip notification from the automated backport with mergify label Mar 4, 2022
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Mar 4, 2022

💔 Tests Failed

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-03-04T15:26:31.530+0000

  • Duration: 53 min 42 sec

Test stats 🧪

Test Results
Failed 1
Passed 275
Skipped 0
Total 276

Test errors 1

Expand to view the tests failures

Initializing / End-To-End Tests / kubernetes-autodiscover_debian_amd64_elastic-agent / Logs collection from running pod – elastic-agent standalone
    Expand to view the error details

     Step "elastic-agent" collects events with "kubernetes.pod.name:a-pod": context deadline exceeded 
    

  • no stacktrace

Steps errors 2

Expand to view the steps failures

Shell Script
  • Took 18 min 44 sec . View more details here
  • Description: ssh -tt -o TCPKeepAlive=yes -o ServerAliveInterval=60 -o ServerAliveCountMax=10 -o StrictHostKeyChecking=no -o UserKnownHostsFile=/dev/null -i /var/lib/jenkins/workspace/PR-2208-6-b2da3a4e-5c9a-44ef-9637-b7338354916c/e2essh admin@18.219.53.32 -- 'sudo bash /home/admin/e2e-testing/.ci/scripts/functional-test.sh "elastic-agent && ~@nightly && ~@skip:amd64" '
Archive the artifacts
  • Took 0 min 0 sec . View more details here
  • Description: [2022-03-04T16:19:06.602Z] Archiving artifacts script returned exit code 2

🐛 Flaky test report

❕ There are test failures but not known flaky tests.

Expand to view the summary

Genuine test errors 1

💔 There are test failures but not known flaky tests, most likely a genuine test failure.

  • Name: Initializing / End-To-End Tests / kubernetes-autodiscover_debian_amd64_elastic-agent / Logs collection from running pod – elastic-agent standalone

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

state: latest
when: ansible_distribution in ["Fedora", "RedHat", "CentOS"]

- name: Install dependencies (Oracle Linux)
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same deps as for Centos/RedHat, but I wanted to keep them separated for decoupling.

If you think we can merge them, I'm OK with that too

Copy link
Copy Markdown
Contributor

@jlind23 jlind23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Manu!

@mdelapenya
Copy link
Copy Markdown
Contributor Author

The only failure is a well-know friend @ChrsMark is debugging. I'd say this is good to go.

@jlind23 could you confirm the target branches for this change?

@jlind23
Copy link
Copy Markdown
Contributor

jlind23 commented Mar 7, 2022

It should begin in 8.2 and then run on each version from 8.2 on.

@mdelapenya mdelapenya closed this Mar 7, 2022
@mdelapenya mdelapenya reopened this Mar 7, 2022
@mdelapenya mdelapenya merged commit 148f0db into elastic:main Mar 7, 2022
@mdelapenya mdelapenya deleted the oracle-linux branch March 9, 2022 06:32
mdelapenya added a commit that referenced this pull request Mar 17, 2022
* main: (268 commits)
  bump stack version 8.2.0-ff67d7b8 (#2242)
  ci: periodic builds for the last two minor versions (#2241)
  bump stack version 8.2.0-9bac538c (#2240)
  fix: add end-of-file line in templates (#2237)
  chore: add Christos to SSH users
  bump stack version 8.2.0-fee3b8d2 (#2234)
  Separate ES workload from Agent spec and make it req for the scenarios (#2203)
  bump stack version 8.2.0-d02c907a (#2228)
  bump stack version 8.2.0-63265ec9 (#2225)
  fix: wrong link (#2220)
  chore: define provider for each test suite (#2213)
  ci: provision e2-small workers (#2212)
  bump stack version 8.2.0-a12f7069 (#2209)
  chore: support for Oracle Linux 8 (#2208)
  bump stack version 8.2.0-190af159 (#2206)
  bump stack version 8.2.0-fdde08ec (#2200)
  bump stack version 8.2.0-43df679f (#2193)
  chore: use trace level in logs (#2130)
  bump stack version 8.2.0-bdf2ad74 (#2188)
  feat: support downloading project artifacts for the new bucket layout (#2172)
  ...
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area:ci Anything related to the CI area:test Anything related to the Test automation backport-skip Skip notification from the automated backport with mergify size:S less than 1 day Team:Automation Label for the Observability productivity team Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Test the Elastic Agent on Oracle Linux 8 operating system

4 participants