Skip to content
This repository was archived by the owner on Sep 17, 2024. It is now read-only.

[8.0](backport #2284) fix: always quote variables in shell scripts#2289

Merged
mdelapenya merged 1 commit into8.0from
mergify/bp/8.0/pr-2284
Mar 29, 2022
Merged

[8.0](backport #2284) fix: always quote variables in shell scripts#2289
mdelapenya merged 1 commit into8.0from
mergify/bp/8.0/pr-2284

Conversation

@mergify
Copy link
Copy Markdown
Contributor

@mergify mergify bot commented Mar 29, 2022

This is an automatic backport of pull request #2284 done by Mergify.

Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

@mdelapenya
fix: always quote variables in shell scripts (#2284)
fd8c82c 
* chore: remove @Skip:platform tags

* fix: do not use the @Skip:platform tag in pipeline

* fix: quote variables as much as possible

* chore: always quote shell variables

* fix: more double quotes

* fix: more quotes

(cherry picked from commit ed5a86e)
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Mar 29, 2022

💔 Tests Failed

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-03-29T11:39:08.066+0000

  • Duration: 60 min 46 sec

Test stats 🧪

Test Results
Failed 1
Passed 310
Skipped 0
Total 311

Test errors 1

Expand to view the tests failures

Initializing / End-To-End Tests / fleet_debian_arm64_system_integration / Adding core system/metrics Integration to a Policy – System Integration
    Expand to view the error details

     Step "system/metrics" with "core" metrics are present in the datastreams

  • no stacktrace

Steps errors 2

Expand to view the steps failures

Shell Script
  • Took 25 min 6 sec . View more details here
  • Description: ssh -tt -o TCPKeepAlive=yes -o ServerAliveInterval=60 -o ServerAliveCountMax=10 -o StrictHostKeyChecking=no -o UserKnownHostsFile=/dev/null -i /var/lib/jenkins/workspace/PR-2289-1-b70202c8-26b9-413a-b06e-664cfcc41877/e2essh admin@18.219.159.154 -- 'sudo bash /home/admin/e2e-testing/.ci/scripts/functional-test.sh "system_integration && ~@nightly" '
Archive the artifacts
  • Took 0 min 1 sec . View more details here
  • Description: [2022-03-29T12:38:44.314Z] Archiving artifacts script returned exit code 2

🐛 Flaky test report

❕ There are test failures but not known flaky tests.

Expand to view the summary

Genuine test errors 1

💔 There are test failures but not known flaky tests, most likely a genuine test failure.

  • Name: Initializing / End-To-End Tests / fleet_debian_arm64_system_integration / Adding core system/metrics Integration to a Policy – System Integration

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@mdelapenya mdelapenya merged commit ee8f2c6 into 8.0 Mar 29, 2022
@mergify mergify bot deleted the mergify/bp/8.0/pr-2284 branch March 30, 2022 01:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

@mdelapenya mdelapenya

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@elasticmachine @mdelapenya