[packaging][beats-tester] use commit id binaries by v1v · Pull Request #22027 · elastic/beats

v1v · 2020-10-20T15:24:57Z

What does this PR do?

#21903 in place therefore let's consume those artifacts/binaries, for such, the parentstream will store their build data to be consumed by the downstream jobs.

More context

Packaging

for branches/tags then the beats pipeline triggers the packaging pipeline, therefore this approach will ensure the packaging will happen for that particular commit id.
for PRs, the packaging pipeline only happens with a /packaging comment, therefore it will use the latest commit.

Beats tester

Beats tester pipeline that has been triggered by the packaging pipeline then the commit id used for the packaging will be the one used for.

Why is it important?

Avoid known issues when the beats-tester and end2end pipelines consume artifacts that don't match with the upstream build that caused the package generation.

Related issues

Relates #21903
Blocked by elastic/beats-tester#185

Tests

packaging.properties is generated to be consumed by the packaging pipeline ->

beats-tester.properties is generated to be consumed by the beats-tester

commit id and URLs are passed between the three pipelines packaging -> beats-tester

elasticmachine · 2020-10-20T16:49:18Z

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS

Expand to view the summary

Build stats

Build Cause: [v1v commented: Jenkins run the tests please]
Start Time: 2020-10-29T11:50:20.208+0000
Duration: 73 min 23 sec

Test stats 🧪

Test	Results
Failed	0
Passed	16374
Skipped	1344
Total	17718

v1v · 2020-10-21T10:39:17Z

/packaging

…ter-commit * upstream/master: feat: package aliases for snapshots (elastic#21960) [DOC] Add firewall as possible troubleshooting issue (elastic#21743) [Filebeat] Add max_number_of_messages config parameter for S3 input (elastic#21993) [Elastic Agent] Fix missing elastic_agent event data (elastic#21994) Document auditbeat system process module config (elastic#21766) Update links (elastic#22012)

v1v · 2020-10-21T11:14:10Z

/packaging

v1v · 2020-10-21T11:15:13Z

/packaging

v1v · 2020-10-21T11:17:01Z

/package

…ter-commit * upstream/master: [Ingest Manager] Use ML_SYSTEM to detect if agent is running as a service (elastic#21884) Prevent log input from sending duplicate messages due to file renaming (elastic#21911)

elasticmachine · 2020-10-28T15:39:09Z

Pinging @elastic/integrations-services (Team:Services)

kuisathaverat · 2020-10-28T16:48:18Z

.ci/packaging.groovy

+                  gitCheckout(basedir: "${BASE_DIR}", branch: props.COMMIT)
+                } catch(err) {
+                  // Fallback to the head of the branch as used to be.
+                  gitCheckout(basedir: "${BASE_DIR}")


in case of error getting the artifact the build will continue, Is that correct?

Yes, just wanted to keep the backward compatibility with the existing behaviour, which it's not ideal, but just in case something bad happens when fetching the artifacts from the upstream build, at least the behaviour will remain working

elasticmachine · 2020-10-28T16:51:14Z

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test	Results
Failed	0
Passed	16374
Skipped	1344
Total	17718

.ci/packaging.groovy

Co-authored-by: cachedout <mike.place@elastic.co>

v1v · 2020-10-29T11:49:54Z

Jenkins run the tests please

v1v · 2020-10-29T12:44:22Z

/package

* upstream/master: [JJBB] Add 6.8+ branches (elastic#22321) [CI] Support Windows-8 (elastic#22307) Change cloud.provider from googlecloud to gcp in billing metricset (elastic#22287) [packaging][beats-tester] use commit id binaries (elastic#22027) [CI] Report error in the catch section (elastic#22297)

# Conflicts: # .ci/packaging.groovy # Jenkinsfile

[packaging][beats-tester] use commit id binaries

7f212d3

botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Oct 20, 2020

[packaging] use commit version

cad5685

andresrc added [zube]: Inbox [zube]: In Review Team:Automation Label for the Observability productivity team Team:Services (Deprecated) Label for the former Integrations-Services team and removed [zube]: Inbox labels Oct 20, 2020

botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Oct 20, 2020

andresrc added [zube]: In Progress Team:Automation Label for the Observability productivity team Team:Services (Deprecated) Label for the former Integrations-Services team and removed [zube]: In Review labels Oct 20, 2020

botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Oct 20, 2020

v1v added 2 commits October 21, 2020 12:07

Fix missing parenthesis

9aa0feb

v1v added 2 commits October 21, 2020 16:27

Merge remote-tracking branch 'upstream/master' into feature/beats-tes…

5f6f7db

…ter-commit * upstream/master: [Ingest Manager] Use ML_SYSTEM to detect if agent is running as a service (elastic#21884) Prevent log input from sending duplicate messages due to file renaming (elastic#21911)

Fix post within a node

2d00db5

v1v requested a review from a team October 28, 2020 15:36

v1v self-assigned this Oct 28, 2020

Merge branch 'master' into feature/beats-tester-commit

528c095

v1v marked this pull request as ready for review October 28, 2020 15:39

kuisathaverat reviewed Oct 28, 2020

View reviewed changes

cachedout approved these changes Oct 28, 2020

View reviewed changes

.ci/packaging.groovy Outdated Show resolved Hide resolved

Update .ci/packaging.groovy

bffb2ff

Co-authored-by: cachedout <mike.place@elastic.co>

v1v requested review from kuisathaverat and mdelapenya October 29, 2020 16:02

mdelapenya approved these changes Oct 29, 2020

View reviewed changes

v1v merged commit 2ad0b88 into elastic:master Oct 30, 2020

v1v deleted the feature/beats-tester-commit branch October 30, 2020 13:25

zube bot added [zube]: Done and removed [zube]: In Progress labels Oct 30, 2020

v1v mentioned this pull request Nov 2, 2020

Cherry-pick to 7.10: [CI] support windows-7-32 bits (#19797) #22336

Merged

v1v added a commit to v1v/beats that referenced this pull request Nov 2, 2020

[packaging][beats-tester] use commit id binaries (elastic#22027)

ad78b80

# Conflicts: # .ci/packaging.groovy # Jenkinsfile

This was referenced Nov 2, 2020

Cherry-pick to 7.x: [packaging][beats-tester] use commit id binaries (#22027) #22337

Closed

Cherry-pick to 7.x: [packaging][beats-tester] use commit id binaries (#22027) #22471

Merged

v1v added a commit to v1v/beats that referenced this pull request Nov 6, 2020

[packaging][beats-tester] use commit id binaries (elastic#22027)

329d18b

v1v mentioned this pull request Nov 6, 2020

Cherry-pick to 7.10: [packaging][beats-tester] use commit id binaries (#22027) #22472

Merged

v1v added a commit to v1v/beats that referenced this pull request Nov 6, 2020

[packaging][beats-tester] use commit id binaries (elastic#22027)

567df76

v1v added a commit that referenced this pull request Nov 9, 2020

[packaging][beats-tester] use commit id binaries (#22027) (#22471)

7d2e42c

v1v added a commit that referenced this pull request Nov 9, 2020

[packaging][beats-tester] use commit id binaries (#22027) (#22472)

e1a9e2c

zube bot removed the [zube]: Done label Jan 29, 2021

Conversation

v1v commented Oct 20, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this PR do?

More context

Packaging

Beats tester

Why is it important?

Related issues

Tests

Uh oh!

elasticmachine commented Oct 20, 2020 • edited by jenkins-beats-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

💚 Build Succeeded

Build stats

Test stats 🧪

Uh oh!

v1v commented Oct 21, 2020

Uh oh!

v1v commented Oct 21, 2020

Uh oh!

v1v commented Oct 21, 2020

Uh oh!

v1v commented Oct 21, 2020

Uh oh!

elasticmachine commented Oct 28, 2020

Uh oh!

kuisathaverat Oct 28, 2020

Choose a reason for hiding this comment

Uh oh!

v1v Oct 28, 2020

Choose a reason for hiding this comment

Uh oh!

elasticmachine commented Oct 28, 2020 • edited by jenkins-beats-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

💚 Flaky test report

Test stats 🧪

Uh oh!

Uh oh!

v1v commented Oct 29, 2020

Uh oh!

v1v commented Oct 29, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

v1v commented Oct 20, 2020 •

edited

Loading

elasticmachine commented Oct 20, 2020 •

edited by jenkins-beats-ci bot

Loading

elasticmachine commented Oct 28, 2020 •

edited by jenkins-beats-ci bot

Loading