Skip to content

[CI] fix No such property: APM_URL_BASE#185

Merged
v1v merged 6 commits intoelastic:masterfrom
v1v:fix/empty-apm-url
Oct 22, 2020
Merged

[CI] fix No such property: APM_URL_BASE#185
v1v merged 6 commits intoelastic:masterfrom
v1v:fix/empty-apm-url

Conversation

@v1v
Copy link
Copy Markdown
Member

@v1v v1v commented Oct 22, 2020 •
edited
Loading

What

When empty params then groovy exception

image

Stacktrace

11:03:49  GitHub has been notified of this commit’s build result
11:03:49  
11:03:49  Also:   groovy.lang.MissingPropertyException: No such property: APM_URL_BASE for class: groovy.lang.Binding
11:03:49  Also:   groovy.lang.MissingPropertyException: No such property: APM_URL_BASE for class: groovy.lang.Binding
11:03:49  Also:   groovy.lang.MissingPropertyException: No such property: APM_URL_BASE for class: groovy.lang.Binding
11:03:49  groovy.lang.MissingPropertyException: No such property: APM_URL_BASE for class: groovy.lang.Binding
11:03:49  	at groovy.lang.Binding.getVariable(Binding.java:63)
11:03:49  	at org.jenkinsci.plugins.scriptsecurity.sandbox.groovy.SandboxInterceptor.onGetProperty(SandboxInterceptor.java:270)
11:03:49  	at org.kohsuke.groovy.sandbox.impl.Checker$7.call(Checker.java:353)
11:03:49  	at org.kohsuke.groovy.sandbox.impl.Checker.checkedGetProperty(Checker.java:357)
11:03:49  	at org.kohsuke.groovy.sandbox.impl.Checker.checkedGetProperty(Checker.java:333)
11:03:49  	at org.kohsuke.groovy.sandbox.impl.Checker.checkedGetProperty(Checker.java:333)
11:03:49  	at org.kohsuke.groovy.sandbox.impl.Checker.checkedGetProperty(Checker.java:333)
11:03:49  	at org.kohsuke.groovy.sandbox.impl.Checker.checkedGetProperty(Checker.java:333)
11:03:49  	at org.kohsuke.groovy.sandbox.impl.Checker.checkedGetProperty(Checker.java:333)
11:03:49  	at com.cloudbees.groovy.cps.sandbox.SandboxInvoker.getProperty(SandboxInvoker.java:29)
11:03:49  	at com.cloudbees.groovy.cps.impl.PropertyAccessBlock.rawGet(PropertyAccessBlock.java:20)
11:03:49  	at WorkflowScript.run(WorkflowScript:68)

Tests

With some empty values

image

@v1v v1v requested a review from a team October 22, 2020 10:24
@v1v v1v self-assigned this Oct 22, 2020
@elasticmachine
Copy link
Copy Markdown
Collaborator

elasticmachine commented Oct 22, 2020 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Started by user Victor Martinez]

  • Start Time: 2020-10-22T13:13:25.907+0000

  • Duration: 51 min 8 sec

Test stats 🧪

Test Results
Failed 0
Passed 10836
Skipped 6098
Total 16934

@v1v
Copy link
Copy Markdown
Member Author

v1v commented Oct 22, 2020

It seems the apm-url is required to be used:


[2020-10-22T12:34:14.228Z] fatal: [tester-awslinux]: FAILED! => {"msg": "The task includes an option with an undefined variable. The error was: 'apm_url_base' is undefined\n\nThe error appears to be in '/var/lib/jenkins/workspace/Beats_beats-tester-mbp_PR-185/src/roles/common/tasks/main.yml': line 9, column 3, but may\nbe elsewhere in the file depending on the exact syntax problem.\n\nThe offending line appears to be:\n\n\n- name: Compute vars (redhat)\n  ^ here\n"}

I'll need to add the option to disable the apm-server validation otherwise we might end up with failures that are not related to the beats but the apm-server one

kuisathaverat
kuisathaverat reviewed Oct 22, 2020
View reviewed changes
@v1v v1v mentioned this pull request Oct 22, 2020
Merged
@v1v @kuisathaverat
Update .ci/Jenkinsfile
d4c3268 
Co-authored-by: Ivan Fernandez Calvo <kuisathaverat@users.noreply.github.com>
@v1v v1v merged commit 6289c9a into elastic:master Oct 22, 2020
@v1v v1v deleted the fix/empty-apm-url branch October 22, 2020 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cachedout cachedout cachedout approved these changes

@kuisathaverat kuisathaverat kuisathaverat approved these changes

+1 more reviewer

@mdelapenya mdelapenya mdelapenya approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@v1v v1v

Labels

automation bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@v1v @elasticmachine @cachedout @mdelapenya @kuisathaverat