[Ingest Manager] Use ML_SYSTEM to detect if agent is running as a service#21884
Merged
michalpristas merged 3 commits intoelastic:masterfrom Oct 21, 2020
Merged
[Ingest Manager] Use ML_SYSTEM to detect if agent is running as a service#21884michalpristas merged 3 commits intoelastic:masterfrom
michalpristas merged 3 commits intoelastic:masterfrom
Conversation
Contributor
|
Pinging @elastic/ingest-management (Team:Ingest Management) |
Contributor
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
|
blakerouse
approved these changes
Oct 20, 2020
Contributor
blakerouse
left a comment
There was a problem hiding this comment.
I have confirmed that this works on Windows 10 with Elastic Agent installed as a service.
michalpristas
added a commit
to michalpristas/beats
that referenced
this pull request
Oct 21, 2020
…vice (elastic#21884) [Ingest Manager] Use ML_SYSTEM to detect if agent is running as a service (elastic#21884)
michalpristas
added a commit
to michalpristas/beats
that referenced
this pull request
Oct 21, 2020
…vice (elastic#21884) [Ingest Manager] Use ML_SYSTEM to detect if agent is running as a service (elastic#21884)
This was referenced Oct 21, 2020
v1v
added a commit
to v1v/beats
that referenced
this pull request
Oct 21, 2020
…ter-commit * upstream/master: [Ingest Manager] Use ML_SYSTEM to detect if agent is running as a service (elastic#21884) Prevent log input from sending duplicate messages due to file renaming (elastic#21911)
v1v
added a commit
to v1v/beats
that referenced
this pull request
Oct 22, 2020
* upstream/master: (27 commits) chore: use ubuntu 18 as linux agent (elastic#22084) docs: Prepare Changelog for 7.9.3 (elastic#22073) (elastic#22075) docs: Prepare Changelog for 6.8.13 (elastic#22072) (elastic#22079) [build][packaging] Add resilience when docker build (elastic#22050) Fix the url of reviewdog (elastic#21981) revert WSS process reporting for windows (elastic#22055) Fix typo (elastic#19585) (elastic#22061) [Ingest Manager] Use ML_SYSTEM to detect if agent is running as a service (elastic#21884) Prevent log input from sending duplicate messages due to file renaming (elastic#21911) feat: package aliases for snapshots (elastic#21960) [DOC] Add firewall as possible troubleshooting issue (elastic#21743) [Filebeat] Add max_number_of_messages config parameter for S3 input (elastic#21993) [Elastic Agent] Fix missing elastic_agent event data (elastic#21994) Document auditbeat system process module config (elastic#21766) Update links (elastic#22012) dynamically find librpm (elastic#21936) Fix Istio docs (elastic#22019) [beats-tester][packaging] store packages in another location (elastic#21903) [Kubernetes] Remove redundant dockersock volume mount (elastic#22009) [Ingest Manager] Always try snapshot repo for agent upgrade (elastic#21951) ...
Contributor
|
I've confirmed this on a Win 7 x64 instance of 7.10 BC4 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
We were using SERVICE token to detect whether or not agent is running as a service. But it turned out that in many cases this token is missing.
We decided that it would be better to use ML_SYSTEM which should be close enough to detect high elevated runs == service runs.
Why is it important?
TO make agent upgradeable even on windows.
Fixes: #21822
Checklist
CHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.