[Heartbeat] Add service_name option for APM integration#19932
Merged
andrewvc merged 6 commits intoelastic:masterfrom Jul 17, 2020
Merged
[Heartbeat] Add service_name option for APM integration#19932andrewvc merged 6 commits intoelastic:masterfrom
andrewvc merged 6 commits intoelastic:masterfrom
Conversation
Contributor
|
Pinging @elastic/uptime (Team:Uptime) |
blakerouse
approved these changes
Jul 15, 2020
Contributor
blakerouse
left a comment
There was a problem hiding this comment.
Looks good, like the consolidation of the arguments into a struct.
Think some of the imports should be cleaned up, but not going to block you on that.
Contributor
Author
|
@blakerouse fixed all the import ordering issues, will merge on green. Thanks for the review! |
6 tasks
andrewvc
added a commit
to andrewvc/beats
that referenced
this pull request
Jul 17, 2020
Adds a new standard service_name option to the heartbeat config file. While possible with fields already, adding this as a first class option encourages use of this important field for integration. First step toward elastic/uptime#220 This PR also refactors some internal bits where we were passing too many parameters already, and adding service_name would just be too much. We now pass a single larger struct for common monitor options which cleans up a lot of the code. (cherry picked from commit 6197850)
v1v
added a commit
to v1v/beats
that referenced
this pull request
Jul 20, 2020
…ngs-archive * upstream/master: (274 commits) Test export commands in all Beats (elastic#20016) [Ingest Manager] Allow using drop path for agent build (elastic#20019) [DOCS] Remove include for deleted file in monitoring docs (elastic#20038) Removing xpack.monitoring.* settings (elastic#18608) [Heartbeat] Add service_name option for APM integration (elastic#19932) [Elastic Agent] Fix merging of fleet.yml. Add --staging to enroll cmd. (elastic#20026) Stricter stalebot configuration for PRs (elastic#20004) [ci] Favor direct mage invocation on CI (elastic#19960) Add cloudwatch input into Filebeat configure inputs documentation (elastic#19973) [Filebeat] remove delimiter \n from log line in s3 input (elastic#19972) [Metricbeat] Update MySQL dashboard (elastic#19913) Packetbeat process monitor: Ignore missing /proc/net/tcp6 (elastic#19945) [CI] fix MODULE variable cornercases (elastic#19985) Ignore timestamp in fortinet/clientendpoint and netscout/sightline (elastic#19998) add 7.9 to .backportrc.json (elastic#19952) Update internal links to external (elastic#19947) Remove Dynamic Script Compilations warning in Cisco module (elastic#19840) [Elastic Agent] Fix RPM and DEB packaging for Elastic Agent (elastic#19959) [Ingest Manager] Do not compare err with custom type (elastic#19980) Fix nanocore sum for non default intervals on Kubernetes Overview Dashboard (elastic#19675) ...
v1v
added a commit
to v1v/beats
that referenced
this pull request
Jul 20, 2020
…nly-mod * upstream/master: (75 commits) Test export commands in all Beats (elastic#20016) [Ingest Manager] Allow using drop path for agent build (elastic#20019) [DOCS] Remove include for deleted file in monitoring docs (elastic#20038) Removing xpack.monitoring.* settings (elastic#18608) [Heartbeat] Add service_name option for APM integration (elastic#19932) [Elastic Agent] Fix merging of fleet.yml. Add --staging to enroll cmd. (elastic#20026) Stricter stalebot configuration for PRs (elastic#20004) [ci] Favor direct mage invocation on CI (elastic#19960) Add cloudwatch input into Filebeat configure inputs documentation (elastic#19973) [Filebeat] remove delimiter \n from log line in s3 input (elastic#19972) [Metricbeat] Update MySQL dashboard (elastic#19913) Packetbeat process monitor: Ignore missing /proc/net/tcp6 (elastic#19945) [CI] fix MODULE variable cornercases (elastic#19985) Ignore timestamp in fortinet/clientendpoint and netscout/sightline (elastic#19998) add 7.9 to .backportrc.json (elastic#19952) Update internal links to external (elastic#19947) Remove Dynamic Script Compilations warning in Cisco module (elastic#19840) [Elastic Agent] Fix RPM and DEB packaging for Elastic Agent (elastic#19959) [Ingest Manager] Do not compare err with custom type (elastic#19980) Fix nanocore sum for non default intervals on Kubernetes Overview Dashboard (elastic#19675) ...
andrewvc
added a commit
that referenced
this pull request
Jul 29, 2020
) Adds a new standard service_name option to the heartbeat config file. While possible with fields already, adding this as a first class option encourages use of this important field for integration. First step toward elastic/uptime#220 This PR also refactors some internal bits where we were passing too many parameters already, and adding service_name would just be too much. We now pass a single larger struct for common monitor options which cleans up a lot of the code. (cherry picked from commit 6197850)
andrewvc
added a commit
to andrewvc/kibana
that referenced
this pull request
Jul 29, 2020
With elastic/beats#19932 coming in 7.10 adding the `service.name` ECS field is very easy. We should prefer this field when cross linking to APM, hence this PR. Resolves elastic/uptime#220
7 tasks
andrewvc
added a commit
to elastic/kibana
that referenced
this pull request
Jul 29, 2020
#73618) With elastic/beats#19932 coming in 7.10 adding the `service.name` ECS field is very easy. We should prefer this field when cross linking to APM, hence this PR. Resolves elastic/uptime#220
andrewvc
added a commit
to andrewvc/kibana
that referenced
this pull request
Jul 29, 2020
elastic#73618) With elastic/beats#19932 coming in 7.10 adding the `service.name` ECS field is very easy. We should prefer this field when cross linking to APM, hence this PR. Resolves elastic/uptime#220 # Conflicts: # x-pack/plugins/uptime/public/lib/helper/observability_integration/get_apm_href.ts
andrewvc
added a commit
to elastic/kibana
that referenced
this pull request
Aug 5, 2020
#73618) (#73666) With elastic/beats#19932 coming in 7.10 adding the `service.name` ECS field is very easy. We should prefer this field when cross linking to APM, hence this PR. Resolves elastic/uptime#220 # Conflicts: # x-pack/plugins/uptime/public/lib/helper/observability_integration/get_apm_href.ts
melchiormoulin
pushed a commit
to melchiormoulin/beats
that referenced
this pull request
Oct 14, 2020
Adds a new standard service_name option to the heartbeat config file. While possible with fields already, adding this as a first class option encourages use of this important field for integration. First step toward elastic/uptime#220 This PR also refactors some internal bits where we were passing too many parameters already, and adding service_name would just be too much. We now pass a single larger struct for common monitor options which cleans up a lot of the code.
andrewvc
added a commit
that referenced
this pull request
Nov 12, 2020
Using the nesting this way lets us handle future fields like service.environment more cleanly if/when they become available. See https://github.com/elastic/ecs/blob/master/rfcs/text/0002-rfc-environment.md for the proposal to add service.environment This is a follow-up to #19932 which has not yet been released, so this is not a breaking change.
andrewvc
added a commit
to andrewvc/beats
that referenced
this pull request
Nov 12, 2020
Using the nesting this way lets us handle future fields like service.environment more cleanly if/when they become available. See https://github.com/elastic/ecs/blob/master/rfcs/text/0002-rfc-environment.md for the proposal to add service.environment This is a follow-up to elastic#19932 which has not yet been released, so this is not a breaking change. (cherry picked from commit 425271b)
andrewvc
added a commit
that referenced
this pull request
Nov 12, 2020
…2574) Using the nesting this way lets us handle future fields like service.environment more cleanly if/when they become available. See https://github.com/elastic/ecs/blob/master/rfcs/text/0002-rfc-environment.md for the proposal to add service.environment This is a follow-up to #19932 which has not yet been released, so this is not a breaking change. (cherry picked from commit 425271b)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds a new standard
service_nameoption to the heartbeat config file. While possible withfieldsalready, adding this as a first class option encourages use of this important field for integration.First step toward elastic/uptime#220
This PR also refactors some internal bits where we were passing too many parameters already, and adding
service_namewould just be too much. We now pass a single larger struct for common monitor options which cleans up a lot of the code.Checklist
CHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.How to test this PR locally
Run against ES with
service_namein your config and see thatservice.nameis populated.