Remove Dynamic Script Compilations warning in Cisco module#19840
Merged
stu-elastic merged 5 commits intoelastic:masterfrom Jul 16, 2020
Merged
Remove Dynamic Script Compilations warning in Cisco module#19840stu-elastic merged 5 commits intoelastic:masterfrom
stu-elastic merged 5 commits intoelastic:masterfrom
Conversation
The suggestions are now defaults
Contributor
💚 Build Succeeded
Expand to view the summary
Build stats
Steps errorsExpand to view the steps failures
|
dedemorton
suggested changes
Jul 13, 2020
Contributor
|
Pinging @elastic/siem (Team:SIEM) |
dedemorton
approved these changes
Jul 14, 2020
Contributor
dedemorton
left a comment
There was a problem hiding this comment.
LGTM - there are some conflicts that need to be resolved before merging, though.
Contributor
|
We've just added another module that carries the same warning, can you remove that one too? https://github.com/elastic/beats/blob/master/x-pack/filebeat/module/sophosxg/_meta/docs.asciidoc |
Contributor
Author
|
@dedemorton Merged. |
stu-elastic
commented
Jul 15, 2020
| - {ref}/modules-scripting-using.html#modules-scripting-using-caching[script.cache.max_size]: | ||
| Increase to at least `300` if using both filesets or other script-heavy modules. | ||
|
|
||
| :modulename!: |
dedemorton
approved these changes
Jul 15, 2020
Contributor
dedemorton
left a comment
There was a problem hiding this comment.
LGTM pending resolution of this comment: https://github.com/elastic/beats/pull/19840/files#r455274688
adriansr
approved these changes
Jul 16, 2020
stu-elastic
added a commit
that referenced
this pull request
Jul 16, 2020
stu-elastic
added a commit
that referenced
this pull request
Jul 16, 2020
v1v
added a commit
to v1v/beats
that referenced
this pull request
Jul 20, 2020
…ngs-archive * upstream/master: (274 commits) Test export commands in all Beats (elastic#20016) [Ingest Manager] Allow using drop path for agent build (elastic#20019) [DOCS] Remove include for deleted file in monitoring docs (elastic#20038) Removing xpack.monitoring.* settings (elastic#18608) [Heartbeat] Add service_name option for APM integration (elastic#19932) [Elastic Agent] Fix merging of fleet.yml. Add --staging to enroll cmd. (elastic#20026) Stricter stalebot configuration for PRs (elastic#20004) [ci] Favor direct mage invocation on CI (elastic#19960) Add cloudwatch input into Filebeat configure inputs documentation (elastic#19973) [Filebeat] remove delimiter \n from log line in s3 input (elastic#19972) [Metricbeat] Update MySQL dashboard (elastic#19913) Packetbeat process monitor: Ignore missing /proc/net/tcp6 (elastic#19945) [CI] fix MODULE variable cornercases (elastic#19985) Ignore timestamp in fortinet/clientendpoint and netscout/sightline (elastic#19998) add 7.9 to .backportrc.json (elastic#19952) Update internal links to external (elastic#19947) Remove Dynamic Script Compilations warning in Cisco module (elastic#19840) [Elastic Agent] Fix RPM and DEB packaging for Elastic Agent (elastic#19959) [Ingest Manager] Do not compare err with custom type (elastic#19980) Fix nanocore sum for non default intervals on Kubernetes Overview Dashboard (elastic#19675) ...
v1v
added a commit
to v1v/beats
that referenced
this pull request
Jul 20, 2020
…nly-mod * upstream/master: (75 commits) Test export commands in all Beats (elastic#20016) [Ingest Manager] Allow using drop path for agent build (elastic#20019) [DOCS] Remove include for deleted file in monitoring docs (elastic#20038) Removing xpack.monitoring.* settings (elastic#18608) [Heartbeat] Add service_name option for APM integration (elastic#19932) [Elastic Agent] Fix merging of fleet.yml. Add --staging to enroll cmd. (elastic#20026) Stricter stalebot configuration for PRs (elastic#20004) [ci] Favor direct mage invocation on CI (elastic#19960) Add cloudwatch input into Filebeat configure inputs documentation (elastic#19973) [Filebeat] remove delimiter \n from log line in s3 input (elastic#19972) [Metricbeat] Update MySQL dashboard (elastic#19913) Packetbeat process monitor: Ignore missing /proc/net/tcp6 (elastic#19945) [CI] fix MODULE variable cornercases (elastic#19985) Ignore timestamp in fortinet/clientendpoint and netscout/sightline (elastic#19998) add 7.9 to .backportrc.json (elastic#19952) Update internal links to external (elastic#19947) Remove Dynamic Script Compilations warning in Cisco module (elastic#19840) [Elastic Agent] Fix RPM and DEB packaging for Elastic Agent (elastic#19959) [Ingest Manager] Do not compare err with custom type (elastic#19980) Fix nanocore sum for non default intervals on Kubernetes Overview Dashboard (elastic#19675) ...
melchiormoulin
pushed a commit
to melchiormoulin/beats
that referenced
this pull request
Oct 14, 2020
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
…9840) (elastic#19995) (cherry picked from commit 1700dba)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The suggestions are now defaults as of elastic/elasticsearch#59267.
See: the defaults for the conditional processor and the ingest processor.