[DOCS] Update tab-widgets internal links to external#19947
Merged
EamonnTP merged 1 commit intoelastic:masterfrom Jul 16, 2020
Merged
[DOCS] Update tab-widgets internal links to external#19947EamonnTP merged 1 commit intoelastic:masterfrom
EamonnTP merged 1 commit intoelastic:masterfrom
Conversation
bmorelli25
requested changes
Jul 16, 2020
Member
bmorelli25
left a comment
There was a problem hiding this comment.
It looks like this didn't work:
(see {beats-ref-root}/auditbeat/master/command-line-options.html[Command reference]).
bmorelli25
reviewed
Jul 16, 2020
| @@ -1,17 +1,20 @@ | |||
| // tag::deb[] | |||
|
|
|||
| :beatname_url: {beats-ref-root}/{beatname_lc}/{branch} | |||
Member
There was a problem hiding this comment.
This can't be added here as it doesn't resolve for the attributes that are used in tagged regions elsewhere. This needs to be added everywhere that attribute is used.
@dedemorton, I know you were against putting this in the docs repo initially (and I was too after hearing your argument), but maybe we can put it in the docs repo with a big comment around it saying not to use it for external book linking? I'm struggling to think of a better option
Suggested change
| :beatname_url: {beats-ref-root}/{beatname_lc}/{branch} | |
| :beatname_url: {beats-ref-root}/{beatname_lc}/{branch} |
Contributor
There was a problem hiding this comment.
I think it should work because the beatname_url attribute is only referenced in the widgets right?
At any rate, I can see that including it in the widget adds a LOT of repetition, so I think you're probably right. Put it in with the other shared attributes and mark it clearly.
@EamonnTP Sorry to give you the run around on this, but I think Brandon is right.
Contributor
|
Pinging @elastic/integrations-services (Team:Services) |
bmorelli25
reviewed
Jul 16, 2020
Author
|
@elasticmachine, run elasticsearch-ci/docs |
Author
bmorelli25
approved these changes
Jul 16, 2020
Member
bmorelli25
left a comment
There was a problem hiding this comment.
Very nice! Sorry for the earlier confusion.
EamonnTP
pushed a commit
to EamonnTP/beats
that referenced
this pull request
Jul 16, 2020
EamonnTP
pushed a commit
to EamonnTP/beats
that referenced
this pull request
Jul 16, 2020
v1v
added a commit
to v1v/beats
that referenced
this pull request
Jul 20, 2020
…ngs-archive * upstream/master: (274 commits) Test export commands in all Beats (elastic#20016) [Ingest Manager] Allow using drop path for agent build (elastic#20019) [DOCS] Remove include for deleted file in monitoring docs (elastic#20038) Removing xpack.monitoring.* settings (elastic#18608) [Heartbeat] Add service_name option for APM integration (elastic#19932) [Elastic Agent] Fix merging of fleet.yml. Add --staging to enroll cmd. (elastic#20026) Stricter stalebot configuration for PRs (elastic#20004) [ci] Favor direct mage invocation on CI (elastic#19960) Add cloudwatch input into Filebeat configure inputs documentation (elastic#19973) [Filebeat] remove delimiter \n from log line in s3 input (elastic#19972) [Metricbeat] Update MySQL dashboard (elastic#19913) Packetbeat process monitor: Ignore missing /proc/net/tcp6 (elastic#19945) [CI] fix MODULE variable cornercases (elastic#19985) Ignore timestamp in fortinet/clientendpoint and netscout/sightline (elastic#19998) add 7.9 to .backportrc.json (elastic#19952) Update internal links to external (elastic#19947) Remove Dynamic Script Compilations warning in Cisco module (elastic#19840) [Elastic Agent] Fix RPM and DEB packaging for Elastic Agent (elastic#19959) [Ingest Manager] Do not compare err with custom type (elastic#19980) Fix nanocore sum for non default intervals on Kubernetes Overview Dashboard (elastic#19675) ...
v1v
added a commit
to v1v/beats
that referenced
this pull request
Jul 20, 2020
…nly-mod * upstream/master: (75 commits) Test export commands in all Beats (elastic#20016) [Ingest Manager] Allow using drop path for agent build (elastic#20019) [DOCS] Remove include for deleted file in monitoring docs (elastic#20038) Removing xpack.monitoring.* settings (elastic#18608) [Heartbeat] Add service_name option for APM integration (elastic#19932) [Elastic Agent] Fix merging of fleet.yml. Add --staging to enroll cmd. (elastic#20026) Stricter stalebot configuration for PRs (elastic#20004) [ci] Favor direct mage invocation on CI (elastic#19960) Add cloudwatch input into Filebeat configure inputs documentation (elastic#19973) [Filebeat] remove delimiter \n from log line in s3 input (elastic#19972) [Metricbeat] Update MySQL dashboard (elastic#19913) Packetbeat process monitor: Ignore missing /proc/net/tcp6 (elastic#19945) [CI] fix MODULE variable cornercases (elastic#19985) Ignore timestamp in fortinet/clientendpoint and netscout/sightline (elastic#19998) add 7.9 to .backportrc.json (elastic#19952) Update internal links to external (elastic#19947) Remove Dynamic Script Compilations warning in Cisco module (elastic#19840) [Elastic Agent] Fix RPM and DEB packaging for Elastic Agent (elastic#19959) [Ingest Manager] Do not compare err with custom type (elastic#19980) Fix nanocore sum for non default intervals on Kubernetes Overview Dashboard (elastic#19675) ...
EamonnTP
pushed a commit
that referenced
this pull request
Jul 21, 2020
EamonnTP
pushed a commit
that referenced
this pull request
Jul 21, 2020
melchiormoulin
pushed a commit
to melchiormoulin/beats
that referenced
this pull request
Oct 14, 2020
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To accommodate including the tab-widgets in the Observability docs, this PR updates internal links to external.
Related PR: elastic/observability-docs#16