ci: Change comment trigger detection method#19827
Merged
kuisathaverat merged 7 commits intoelastic:masterfrom Jul 14, 2020
Merged
ci: Change comment trigger detection method#19827kuisathaverat merged 7 commits intoelastic:masterfrom
kuisathaverat merged 7 commits intoelastic:masterfrom
Conversation
Contributor
Author
|
/package |
Contributor
Author
|
/package |
Contributor
💚 Build Succeeded
Expand to view the summary
Build stats
|
Contributor
Author
|
/package |
2 similar comments
Member
|
/package |
Member
|
/package |
Contributor
Author
|
/package |
Contributor
Author
|
/package |
mdelapenya
approved these changes
Jul 14, 2020
v1v
approved these changes
Jul 14, 2020
Member
v1v
left a comment
There was a problem hiding this comment.
Is /package comment an example? Otherwise it will be required to enable it in
beats/.ci/apm-beats-update.groovy
Line 29 in 133fb60
Co-authored-by: Victor Martinez <victormartinezrubio@gmail.com>
kuisathaverat
added a commit
to kuisathaverat/beats
that referenced
this pull request
Jul 14, 2020
* test: check which trigger is enabled * chore: merge master * test: test a fix * test: change the comment trigger detection method * test: change the comment trigger detection method * Update .ci/packaging.groovy Co-authored-by: Victor Martinez <victormartinezrubio@gmail.com> Co-authored-by: Victor Martinez <victormartinezrubio@gmail.com>
kuisathaverat
added a commit
to kuisathaverat/beats
that referenced
this pull request
Jul 14, 2020
* test: check which trigger is enabled * chore: merge master * test: test a fix * test: change the comment trigger detection method * test: change the comment trigger detection method * Update .ci/packaging.groovy Co-authored-by: Victor Martinez <victormartinezrubio@gmail.com> Co-authored-by: Victor Martinez <victormartinezrubio@gmail.com>
kuisathaverat
added a commit
to kuisathaverat/beats
that referenced
this pull request
Jul 14, 2020
* test: check which trigger is enabled * chore: merge master * test: test a fix * test: change the comment trigger detection method * test: change the comment trigger detection method * Update .ci/packaging.groovy Co-authored-by: Victor Martinez <victormartinezrubio@gmail.com> Co-authored-by: Victor Martinez <victormartinezrubio@gmail.com>
kuisathaverat
added a commit
that referenced
this pull request
Jul 14, 2020
* test: check which trigger is enabled * chore: merge master * test: test a fix * test: change the comment trigger detection method * test: change the comment trigger detection method * Update .ci/packaging.groovy Co-authored-by: Victor Martinez <victormartinezrubio@gmail.com> Co-authored-by: Victor Martinez <victormartinezrubio@gmail.com> Co-authored-by: Victor Martinez <victormartinezrubio@gmail.com>
kuisathaverat
added a commit
that referenced
this pull request
Jul 14, 2020
* test: check which trigger is enabled * chore: merge master * test: test a fix * test: change the comment trigger detection method * test: change the comment trigger detection method * Update .ci/packaging.groovy Co-authored-by: Victor Martinez <victormartinezrubio@gmail.com> Co-authored-by: Victor Martinez <victormartinezrubio@gmail.com> Co-authored-by: Victor Martinez <victormartinezrubio@gmail.com>
kuisathaverat
added a commit
that referenced
this pull request
Jul 14, 2020
* test: check which trigger is enabled * chore: merge master * test: test a fix * test: change the comment trigger detection method * test: change the comment trigger detection method * Update .ci/packaging.groovy Co-authored-by: Victor Martinez <victormartinezrubio@gmail.com> Co-authored-by: Victor Martinez <victormartinezrubio@gmail.com> Co-authored-by: Victor Martinez <victormartinezrubio@gmail.com>
v1v
added a commit
to v1v/beats
that referenced
this pull request
Jul 14, 2020
* upstream/master: (25 commits) [Elastic Agent] Send checkin payload to Fleet (elastic#19857) [Ingest Manager] Fixed tests across agent elastic#19877 [Ingest Manager] Fix serialization test elastic#19876 Fix service start type mapping in windows/service metricset (elastic#19551) ci: Change comment trigger detection method (elastic#19827) Add 21 autogenerated filesets from rsa2elk devices (elastic#19713) [Ingest Manager] Agent config cleanup (elastic#19848) libbeat/publisher/pipeline: fix data races (elastic#19821) Update monitoring-internal-collection.asciidoc (elastic#19422) (elastic#19697) [Elastic Agent] Trust exchange endpoint must bind to 127.0.0.1 (elastic#19861) Specify an ECS version in Auditbeat/Packetbeat/Winlogbeat (elastic#19159) Add azure billing metricset (elastic#19207) Add support for appinsights in the metricbeat azure module (elastic#18940) Add MySQL query metricset with lightweight module and SQL helper (elastic#18955) [Ingest Manager] Refuse invalid stream values in configuration (elastic#19587) Do not use vendor during integration tests (elastic#19839) LIBBEAT: Enhancement Convert dissected values from String to other basic data types and IP (elastic#18683) [Elastic Agent] Remove support for "logs" and only support logfile (elastic#19761) [CI] support windows-2012 (elastic#19773) Do not update go.mod during packaging and testing (elastic#19823) ...
melchiormoulin
pushed a commit
to melchiormoulin/beats
that referenced
this pull request
Oct 14, 2020
* test: check which trigger is enabled * chore: merge master * test: test a fix * test: change the comment trigger detection method * test: change the comment trigger detection method * Update .ci/packaging.groovy Co-authored-by: Victor Martinez <victormartinezrubio@gmail.com> Co-authored-by: Victor Martinez <victormartinezrubio@gmail.com>
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
…19872) * test: check which trigger is enabled * chore: merge master * test: test a fix * test: change the comment trigger detection method * test: change the comment trigger detection method * Update .ci/packaging.groovy Co-authored-by: Victor Martinez <victormartinezrubio@gmail.com> Co-authored-by: Victor Martinez <victormartinezrubio@gmail.com> Co-authored-by: Victor Martinez <victormartinezrubio@gmail.com>
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
…19873) * test: check which trigger is enabled * chore: merge master * test: test a fix * test: change the comment trigger detection method * test: change the comment trigger detection method * Update .ci/packaging.groovy Co-authored-by: Victor Martinez <victormartinezrubio@gmail.com> Co-authored-by: Victor Martinez <victormartinezrubio@gmail.com> Co-authored-by: Victor Martinez <victormartinezrubio@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
It changes the filter for comment trigger.
Why is it important?
isCommentTrigger needs a node to works because we use it on a when context without a node provisioned it does not work, thus we changed that function to a triggerBy directive.
Checklist
[ ] My code follows the style guidelines of this project[ ] I have commented my code, particularly in hard-to-understand areas[ ] I have made corresponding changes to the documentation[ ] I have made corresponding change to the default configuration files[ ] I have added tests that prove my fix is effective or that my feature works[ ] I have added an entry inCHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.