Merged
Conversation
Contributor
💔 Tests Failed
Expand to view the summary
Build stats
Test stats 🧪
Test errorsExpand to view the tests failures
Steps errorsExpand to view the steps failures
Log outputExpand to view the last 100 lines of log output
|
vendor work run fix change fix fix dependencies work fix
Contributor
|
Pinging @elastic/integrations (Team:Integrations) |
kaiyan-sheng
approved these changes
Jul 9, 2020
Contributor
kaiyan-sheng
left a comment
There was a problem hiding this comment.
Overall it looks good! Just several small comments.
|
|
||
| [float] | ||
| === `billing` | ||
| This metricset will collect relevant usage data and forecast information from the specific subscription, these metrics will have a timegrain every 24 hours, |
Contributor
There was a problem hiding this comment.
Suggested change
| This metricset will collect relevant usage data and forecast information from the specific subscription, these metrics will have a timegrain every 24 hours, | |
| This metricset will collect relevant usage data and forecast information from a specific subscription. These metrics will have a timegrain every 24 hours, |
Contributor
|
Lint failure should be fixed in master now. If you rebase this PR, hopefully CI will turn green 😄 |
narph
added a commit
to narph/beats
that referenced
this pull request
Jul 13, 2020
* work on metricset vendor work run fix change fix fix dependencies work fix * remove vendor * remove unused * work on the billing * make notice * work on fields * build dashboards * make notice * review * make sure * is set to auto in gitattributes * test * update CLRF to LF * update CLRF to LF * notice * notice * Fix notice * update visualization Co-authored-by: Martijn Laarman <Mpdreamz@gmail.com> Co-authored-by: Carlos Pérez-Aradros Herce <exekias@gmail.com> (cherry picked from commit e69eb97)
6 tasks
narph
added a commit
that referenced
this pull request
Jul 14, 2020
* work on metricset vendor work run fix change fix fix dependencies work fix * remove vendor * remove unused * work on the billing * make notice * work on fields * build dashboards * make notice * review * make sure * is set to auto in gitattributes * test * update CLRF to LF * update CLRF to LF * notice * notice * Fix notice * update visualization Co-authored-by: Martijn Laarman <Mpdreamz@gmail.com> Co-authored-by: Carlos Pérez-Aradros Herce <exekias@gmail.com> (cherry picked from commit e69eb97)
v1v
added a commit
to v1v/beats
that referenced
this pull request
Jul 14, 2020
* upstream/master: (25 commits) [Elastic Agent] Send checkin payload to Fleet (elastic#19857) [Ingest Manager] Fixed tests across agent elastic#19877 [Ingest Manager] Fix serialization test elastic#19876 Fix service start type mapping in windows/service metricset (elastic#19551) ci: Change comment trigger detection method (elastic#19827) Add 21 autogenerated filesets from rsa2elk devices (elastic#19713) [Ingest Manager] Agent config cleanup (elastic#19848) libbeat/publisher/pipeline: fix data races (elastic#19821) Update monitoring-internal-collection.asciidoc (elastic#19422) (elastic#19697) [Elastic Agent] Trust exchange endpoint must bind to 127.0.0.1 (elastic#19861) Specify an ECS version in Auditbeat/Packetbeat/Winlogbeat (elastic#19159) Add azure billing metricset (elastic#19207) Add support for appinsights in the metricbeat azure module (elastic#18940) Add MySQL query metricset with lightweight module and SQL helper (elastic#18955) [Ingest Manager] Refuse invalid stream values in configuration (elastic#19587) Do not use vendor during integration tests (elastic#19839) LIBBEAT: Enhancement Convert dissected values from String to other basic data types and IP (elastic#18683) [Elastic Agent] Remove support for "logs" and only support logfile (elastic#19761) [CI] support windows-2012 (elastic#19773) Do not update go.mod during packaging and testing (elastic#19823) ...
melchiormoulin
pushed a commit
to melchiormoulin/beats
that referenced
this pull request
Oct 14, 2020
* work on metricset vendor work run fix change fix fix dependencies work fix * remove vendor * remove unused * work on the billing * make notice * work on fields * build dashboards * make notice * review * make sure * is set to auto in gitattributes * test * update CLRF to LF * update CLRF to LF * notice * notice * Fix notice * update visualization Co-authored-by: Martijn Laarman <Mpdreamz@gmail.com> Co-authored-by: Carlos Pérez-Aradros Herce <exekias@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds usage and costs metrics from azure subscriptions
Why is it important?
Shows relevant charges and forecast information
Checklist
CHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.How to test this PR locally
Enable billing metricset in the azure module
Related issues
Screenshots