Skip to content

Update monitoring-internal-collection.asciidoc#19422

Merged
ycombinator merged 1 commit into7.8from
uihyun-patch-1
Jul 7, 2020
Merged

Update monitoring-internal-collection.asciidoc#19422
ycombinator merged 1 commit into7.8from
uihyun-patch-1

Conversation

@uihyun
Copy link
Copy Markdown
Contributor

@uihyun uihyun commented Jun 26, 2020 •
edited by andresrc
Loading

What does this PR do?

the monitoring configuration shows an extra ssl.
for example, monitoring.elasticsearch.ssl.certificate_authorities should be right but now it looks like monitoring.elasticsearch.ssl.ssl.certificate_authorities.
this documentation was added since the version 7.5.

Why is it important?

wrong info

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

@uihyun
Update monitoring-internal-collection.asciidoc
989c49b 
the monitoring configuration shows an extra `ssl`.
for example, `monitoring.elasticsearch.ssl.certificate_authorities` should be right but now it looks like `monitoring.elasticsearch.ssl.ssl.certificate_authorities`.
this documentation was added since the version 7.5.
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jun 26, 2020
@uihyun uihyun added the docs label Jun 26, 2020
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Jun 26, 2020 •
edited
Loading

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Branch indexing]

  • Start Time: 2020-07-02T09:28:06.430+0000

  • Duration: 25 min 25 sec

@uihyun uihyun added Team:SIEM and removed needs_team Indicates that the issue/PR needs a Team:* label labels Jun 26, 2020
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Jun 26, 2020

Pinging @elastic/siem (Team:SIEM)

@andrewkroh andrewkroh added Team:Services (Deprecated) Label for the former Integrations-Services team and removed Team:SIEM labels Jul 6, 2020
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Jul 6, 2020

Pinging @elastic/integrations-services (Team:Services)

@andresrc andresrc requested a review from ycombinator July 7, 2020 09:01
ycombinator
ycombinator approved these changes Jul 7, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@ycombinator ycombinator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Good catch and thanks for fixing it!

@ycombinator ycombinator added v7.8.2 v7.9.0 v8.0.0 needs_backport PR is waiting to be backported to other branches. labels Jul 7, 2020
@ycombinator ycombinator merged commit 7854c48 into 7.8 Jul 7, 2020
@ycombinator ycombinator deleted the uihyun-patch-1 branch July 7, 2020 12:12
@ycombinator ycombinator mentioned this pull request Jul 7, 2020
Merged
ycombinator added a commit that referenced this pull request Jul 13, 2020
@ycombinator @uihyun
Update monitoring-internal-collection.asciidoc (#19422) (#19697)
ac89845 
the monitoring configuration shows an extra `ssl`.
for example, `monitoring.elasticsearch.ssl.certificate_authorities` should be right but now it looks like `monitoring.elasticsearch.ssl.ssl.certificate_authorities`.
this documentation was added since the version 7.5.

Co-authored-by: uihyun <uihyun.kim@elastic.co>
@ycombinator ycombinator mentioned this pull request Jul 14, 2020
Merged
v1v added a commit to v1v/beats that referenced this pull request Jul 14, 2020
@v1v
Merge remote-tracking branch 'upstream/master' into feature/windows-7-32
de92936 
* upstream/master: (25 commits)
  [Elastic Agent] Send checkin payload to Fleet (elastic#19857)
  [Ingest Manager] Fixed tests across agent elastic#19877
  [Ingest Manager] Fix serialization test  elastic#19876
  Fix service start type mapping in windows/service metricset (elastic#19551)
  ci: Change comment trigger detection method (elastic#19827)
  Add 21 autogenerated filesets from rsa2elk devices (elastic#19713)
  [Ingest Manager] Agent config cleanup (elastic#19848)
  libbeat/publisher/pipeline: fix data races (elastic#19821)
  Update monitoring-internal-collection.asciidoc (elastic#19422) (elastic#19697)
  [Elastic Agent] Trust exchange endpoint must bind to 127.0.0.1 (elastic#19861)
  Specify an ECS version in Auditbeat/Packetbeat/Winlogbeat (elastic#19159)
  Add azure billing metricset (elastic#19207)
  Add support for appinsights in the metricbeat azure module (elastic#18940)
  Add MySQL query metricset with lightweight module and SQL helper (elastic#18955)
  [Ingest Manager] Refuse invalid stream values in configuration (elastic#19587)
  Do not use vendor during integration tests (elastic#19839)
  LIBBEAT: Enhancement Convert dissected values from String to other basic data types and IP (elastic#18683)
  [Elastic Agent] Remove support for "logs" and only support logfile (elastic#19761)
  [CI] support windows-2012 (elastic#19773)
  Do not update go.mod during packaging and testing (elastic#19823)
  ...
ycombinator added a commit that referenced this pull request Jul 14, 2020
@ycombinator @uihyun
Update monitoring-internal-collection.asciidoc (#19422) (#19697) (#19883
a4eca30 
)

the monitoring configuration shows an extra `ssl`.
for example, `monitoring.elasticsearch.ssl.certificate_authorities` should be right but now it looks like `monitoring.elasticsearch.ssl.ssl.certificate_authorities`.
this documentation was added since the version 7.5.

Co-authored-by: uihyun <uihyun.kim@elastic.co>

Co-authored-by: uihyun <uihyun.kim@elastic.co>
@dedemorton
Copy link
Copy Markdown
Contributor

dedemorton commented Aug 15, 2020

I think we can remove the needs_backport label from this right?

@bmorelli25 bmorelli25 mentioned this pull request Sep 1, 2020
Merged
1 task
melchiormoulin pushed a commit to melchiormoulin/beats that referenced this pull request Oct 14, 2020
@ycombinator @uihyun @melchiormoulin
Update monitoring-internal-collection.asciidoc (elastic#19422) (elast…
7b60010 
…ic#19697)

the monitoring configuration shows an extra `ssl`.
for example, `monitoring.elasticsearch.ssl.certificate_authorities` should be right but now it looks like `monitoring.elasticsearch.ssl.ssl.certificate_authorities`.
this documentation was added since the version 7.5.

Co-authored-by: uihyun <uihyun.kim@elastic.co>
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
@uihyun
Update monitoring-internal-collection.asciidoc (elastic#19422)
85ac559 
the monitoring configuration shows an extra `ssl`.
for example, `monitoring.elasticsearch.ssl.certificate_authorities` should be right but now it looks like `monitoring.elasticsearch.ssl.ssl.certificate_authorities`.
this documentation was added since the version 7.5.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ycombinator ycombinator ycombinator approved these changes

Assignees

No one assigned

Labels

docs needs_backport PR is waiting to be backported to other branches. Team:Services (Deprecated) Label for the former Integrations-Services team v7.8.2 v7.9.0 v8.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@uihyun @elasticmachine @dedemorton @ycombinator @andresrc @andrewkroh