Merged
Conversation
Contributor
|
Pinging @elastic/integrations-services (Team:Services) |
urso
reviewed
Jul 8, 2020
| var found bool | ||
| for _, err := range errs { | ||
| if strings.Contains(err.Error(), "request canceled (Client.Timeout exceeded") { | ||
| if strings.Contains(err.Error(), "context deadline exceeded (Client.Timeout exceeded") { |
There was a problem hiding this comment.
maybe for another PR, but better check for err == context.X. There are constants for this. Checking errors by error string is kind of a no-go.
Contributor
💔 Tests Failed
Expand to view the summary
Build stats
Test stats 🧪
Test errorsExpand to view the tests failures
Steps errorsExpand to view the steps failures
Log outputExpand to view the last 100 lines of log output
|
|
Some tests failed, but seems unrelated (maybe the generator might have some problem, though). As follow up: we should disable vendoring in the generator. |
Contributor
Author
|
@urso I've updated the generators to not use vendoring. |
Contributor
Author
|
The issues with the generated Beats will disappear once the PR gets merged to master. Travis errors are unrelated. |
urso
approved these changes
Jul 9, 2020
|
CI failures seem to be unrelated. I'm Investigating the filebeat errors. Feel free to merge independently. |
6 tasks
v1v
added a commit
to v1v/beats
that referenced
this pull request
Jul 9, 2020
* upstream/master: Add `docker logs` support to the Elastic Log Driver (elastic#19531) [Elastic Agent] Fix saving of agent configuration on Windows to have proper ACLs (elastic#19793) Send the config revision down to the endpoint application. (elastic#19759) [Elastic Agent] Add support for multiple hosts in connection to kibana (elastic#19628) Remove the downloadConfig and retryConfig from plugin/process.Application and plugin/service.Application. (elastic#19603) Update go version to 1.14.4 (elastic#19753) ci: set builds as skipped when they do not match the trigger (elastic#19750) [Auditbeat] Fix up socket dataset runaway CPU usage (elastic#19764) Convert cloudfoundry input to v2 (elastic#19717)
kvch
added a commit
to kvch/beats
that referenced
this pull request
Jul 13, 2020
This PR adds support for Golang 1.14.4 in Beats. The dependency `golang.org/x/tools` is pinned to `release-branch.go1.14`. The generated Beats no longer contain a vendor folder. Go 1.14 has been out for quite some time. It is high time we update. Closes elastic#18829 Closes elastic#16566 (cherry picked from commit 7580c72)
kvch
added a commit
that referenced
this pull request
Jul 13, 2020
This PR adds support for Golang 1.14.4 in Beats. The dependency `golang.org/x/tools` is pinned to `release-branch.go1.14`. The generated Beats no longer contain a vendor folder. Go 1.14 has been out for quite some time. It is high time we update. Closes #18829 Closes #16566 (cherry picked from commit 7580c72)
melchiormoulin
pushed a commit
to melchiormoulin/beats
that referenced
this pull request
Oct 14, 2020
## What does this PR do? This PR adds support for Golang 1.14.4 in Beats. The dependency `golang.org/x/tools` is pinned to `release-branch.go1.14`. The generated Beats no longer contain a vendor folder. ## Why is it important? Go 1.14 has been out for quite some time. It is high time we update. ## Related issues Closes elastic#18829 Closes elastic#16566
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds support for Golang 1.14.4 in Beats. The dependency
golang.org/x/toolsis pinned torelease-branch.go1.14.The generated Beats no longer contain a vendor folder.
Why is it important?
Go 1.14 has been out for quite some time. It is high time we update.
Checklist
CHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Related issues
Closes #18829
Closes #16566