Skip to content

Cherry-pick #19753 to 7.x: Update go version to 1.14.4#19792

Merged
kvch merged 1 commit intoelastic:7.xfrom
kvch:backport_19753_7.x
Jul 13, 2020
Merged

Cherry-pick #19753 to 7.x: Update go version to 1.14.4#19792
kvch merged 1 commit intoelastic:7.xfrom
kvch:backport_19753_7.x

Conversation

@kvch
Copy link
Copy Markdown
Contributor

@kvch kvch commented Jul 9, 2020

Cherry-pick of PR #19753 to 7.x branch. Original message:

What does this PR do?

This PR adds support for Golang 1.14.4 in Beats. The dependency golang.org/x/tools is pinned to release-branch.go1.14.

The generated Beats no longer contain a vendor folder.

Why is it important?

Go 1.14 has been out for quite some time. It is high time we update.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

Closes #18829
Closes #16566

@kvch kvch requested a review from a team as a code owner July 9, 2020 14:41
@kvch kvch added [zube]: In Review backport Team:Services (Deprecated) Label for the former Integrations-Services team labels Jul 9, 2020
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jul 9, 2020
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/integrations-services (Team:Services)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Jul 9, 2020
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Jul 9, 2020

💔 Tests Failed

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #19792 updated]

  • Start Time: 2020-07-09T15:16:48.050+0000

  • Duration: 123 min 49 sec

Test stats 🧪

Test Results
Failed 2
Passed 9191
Skipped 1401
Total 10594

Test errors

Expand to view the tests failures

  • Name: Build and Test / Metricbeat Mac OS X / TestFetch – filesystem

    • Age: 1
    • Duration: 0
    • Error Details: Failed
  • Name: Build and Test / Metricbeat Mac OS X / TestFetch – fsstat

    • Age: 1
    • Duration: 0
    • Error Details: Failed

Steps errors

Expand to view the steps failures

  • Name: Report to Codecov

    • Description: curl -sSLo codecov https://codecov.io/bash for i in auditbeat filebeat heartbeat libbeat metricbeat packetbeat winlogbeat journalbeat do FILE="${i}/build/coverage/full.cov" if [ -f "${FILE}" ]; then bash codecov -f "${FILE}" fi done

    • Duration: 2 min 22 sec

    • Start Time: 2020-07-09T16:35:06.349+0000

    • log

  • Name: Install Go 1.14.4

    • Description: .ci/scripts/install-go.sh

    • Duration: 1 min 32 sec

    • Start Time: 2020-07-09T15:39:22.653+0000

    • log

  • Name: Install Go 1.14.4

    • Description: .ci/scripts/install-go.sh

    • Duration: 1 min 57 sec

    • Start Time: 2020-07-09T15:41:27.419+0000

    • log

  • Name: Mage build unitTest

    • Description: mage build unitTest

    • Duration: 14 min 46 sec

    • Start Time: 2020-07-09T16:01:16.424+0000

    • log

  • Name: Report to Codecov

    • Description: curl -sSLo codecov https://codecov.io/bash for i in auditbeat filebeat heartbeat libbeat metricbeat packetbeat winlogbeat journalbeat do FILE="${i}/build/coverage/full.cov" if [ -f "${FILE}" ]; then bash codecov -f "${FILE}" fi done

    • Duration: 2 min 22 sec

    • Start Time: 2020-07-09T15:44:58.288+0000

    • log

Log output

Expand to view the last 100 lines of log output

[2020-07-09T17:19:09.396Z] + FILE=winlogbeat/build/coverage/full.cov
[2020-07-09T17:19:09.396Z] + [ -f winlogbeat/build/coverage/full.cov ]
[2020-07-09T17:19:09.396Z] + FILE=journalbeat/build/coverage/full.cov
[2020-07-09T17:19:09.396Z] + [ -f journalbeat/build/coverage/full.cov ]
[2020-07-09T17:19:10.589Z] Failed in branch Filebeat oss
[2020-07-09T17:19:10.743Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19792/src/github.com/elastic/beats
[2020-07-09T17:19:11.052Z] + find . -type f -name TEST*.xml -path */build/* -delete
[2020-07-09T17:19:11.064Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19792/src/github.com/elastic/beats/Lint
[2020-07-09T17:19:11.152Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19792/src/github.com/elastic/beats/Winlogbeat-oss
[2020-07-09T17:19:11.231Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19792/src/github.com/elastic/beats/Elastic-Agent-x-pack
[2020-07-09T17:19:11.311Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19792/src/github.com/elastic/beats/Auditbeat-crosscompile
[2020-07-09T17:19:11.397Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19792/src/github.com/elastic/beats/Generators-Metricbeat-Linux
[2020-07-09T17:19:11.481Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19792/src/github.com/elastic/beats/Dockerlogbeat
[2020-07-09T17:19:11.567Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19792/src/github.com/elastic/beats/Journalbeat-oss
[2020-07-09T17:19:11.663Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19792/src/github.com/elastic/beats/Functionbeat-x-pack
[2020-07-09T17:19:11.753Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19792/src/github.com/elastic/beats/Elastic-Agent-x-pack-Windows
[2020-07-09T17:19:11.847Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19792/src/github.com/elastic/beats/Metricbeat-OSS-Unit-tests
[2020-07-09T17:19:11.924Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19792/src/github.com/elastic/beats/Auditbeat-x-pack
[2020-07-09T17:19:12.002Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19792/src/github.com/elastic/beats/Auditbeat-x-pack-Windows
[2020-07-09T17:19:12.096Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19792/src/github.com/elastic/beats/Auditbeat-oss-Windows
[2020-07-09T17:19:12.181Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19792/src/github.com/elastic/beats/Heartbeat-oss
[2020-07-09T17:19:12.267Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19792/src/github.com/elastic/beats/Winlogbeat-Windows-x-pack
[2020-07-09T17:19:12.358Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19792/src/github.com/elastic/beats/Filebeat-x-pack-Windows
[2020-07-09T17:19:12.444Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19792/src/github.com/elastic/beats/Libbeat-x-pack
[2020-07-09T17:19:12.527Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19792/src/github.com/elastic/beats/Filebeat-Windows
[2020-07-09T17:19:12.624Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19792/src/github.com/elastic/beats/Metricbeat-crosscompile
[2020-07-09T17:19:12.720Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19792/src/github.com/elastic/beats/Auditbeat-oss-Linux
[2020-07-09T17:19:12.800Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19792/src/github.com/elastic/beats/Elastic-Agent-Mac-OS-X
[2020-07-09T17:19:12.892Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19792/src/github.com/elastic/beats/Packetbeat-oss
[2020-07-09T17:19:12.990Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19792/src/github.com/elastic/beats/Metricbeat-Windows
[2020-07-09T17:19:13.074Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19792/src/github.com/elastic/beats/Winlogbeat-Windows
[2020-07-09T17:19:13.181Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19792/src/github.com/elastic/beats/Generators-Beat-Linux
[2020-07-09T17:19:13.273Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19792/src/github.com/elastic/beats/Metricbeat-x-pack-Windows
[2020-07-09T17:19:13.366Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19792/src/github.com/elastic/beats/Filebeat-x-pack-Mac-OS-X
[2020-07-09T17:19:13.455Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19792/src/github.com/elastic/beats/Auditbeat-oss-Mac-OS-X
[2020-07-09T17:19:13.531Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19792/src/github.com/elastic/beats/Filebeat-Mac-OS-X
[2020-07-09T17:19:13.606Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19792/src/github.com/elastic/beats/Auditbeat-x-pack-Mac-OS-X
[2020-07-09T17:19:13.693Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19792/src/github.com/elastic/beats/Metricbeat-x-pack-Mac-OS-X
[2020-07-09T17:19:13.770Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19792/src/github.com/elastic/beats/Heartbeat-Mac-OS-X
[2020-07-09T17:19:13.844Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19792/src/github.com/elastic/beats/Functionbeat-Mac-OS-X-x-pack
[2020-07-09T17:19:13.920Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19792/src/github.com/elastic/beats/Metricbeat-Python-integration-tests
[2020-07-09T17:19:14.027Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19792/src/github.com/elastic/beats/Metricbeat-Mac-OS-X
[2020-07-09T17:19:14.101Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19792/src/github.com/elastic/beats/Generators-Metricbeat-Mac-OS-X
[2020-07-09T17:19:14.186Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19792/src/github.com/elastic/beats/Heartbeat-Windows
[2020-07-09T17:19:14.263Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19792/src/github.com/elastic/beats/Functionbeat-Windows
[2020-07-09T17:19:14.382Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19792/src/github.com/elastic/beats/Generators-Beat-Mac-OS-X
[2020-07-09T17:19:14.492Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19792/src/github.com/elastic/beats/Libbeat-oss
[2020-07-09T17:19:14.594Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19792/src/github.com/elastic/beats/Libbeat-crosscompile
[2020-07-09T17:19:14.670Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19792/src/github.com/elastic/beats/Metricbeat-OSS-Integration-tests
[2020-07-09T17:19:14.756Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19792/src/github.com/elastic/beats/Libbeat-stress-tests
[2020-07-09T17:19:14.833Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19792/src/github.com/elastic/beats/Metricbeat-x-pack
[2020-07-09T17:19:14.906Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19792/src/github.com/elastic/beats/Filebeat-x-pack
[2020-07-09T17:19:14.983Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19792/src/github.com/elastic/beats/Filebeat-oss
[2020-07-09T17:19:15.378Z] + cat
[2020-07-09T17:19:15.378Z] + /usr/local/bin/runbld ./runbld-script
[2020-07-09T17:19:15.378Z] Picked up JAVA_TOOL_OPTIONS: -Dfile.encoding=UTF8
[2020-07-09T17:19:21.951Z] runbld>>> runbld started
[2020-07-09T17:19:21.951Z] runbld>>> 1.6.12/f45d832f2ba0aa2722ab4ec1fda8ad140f027f8b
[2020-07-09T17:19:23.336Z] runbld>>> The following profiles matched the job 'Beats/beats-beats-mbp/PR-19792' in order of occurrence in the config (last value wins).
[2020-07-09T17:19:24.275Z] runbld>>> Debug logging enabled.
[2020-07-09T17:19:24.275Z] runbld>>> Storing result
[2020-07-09T17:19:24.534Z] runbld>>> Store result: created {:total 2, :successful 2, :failed 0} 1
[2020-07-09T17:19:24.534Z] runbld>>> BUILD: https://c150076387b5421f9154dfbf536e5c60.us-west1.gcp.cloud.es.io:9243/build-1587637540455/t/20200709171924-5715653D
[2020-07-09T17:19:24.534Z] runbld>>> Adding system facts.
[2020-07-09T17:19:25.481Z] runbld>>> Adding vcs info for the latest commit:  04f7bb11bf9b1ddeefc76f363333103ccf610923
[2020-07-09T17:19:25.481Z] runbld>>> >>>>>>>>>>>> SCRIPT EXECUTION BEGIN >>>>>>>>>>>>
[2020-07-09T17:19:25.481Z] runbld>>> Adding /usr/lib/jvm/java-8-openjdk-amd64/bin to the path.
[2020-07-09T17:19:25.481Z] Processing JUnit reports with runbld...
[2020-07-09T17:19:25.481Z] + echo 'Processing JUnit reports with runbld...'
[2020-07-09T17:19:25.743Z] runbld>>> <<<<<<<<<<<< SCRIPT EXECUTION END <<<<<<<<<<<<
[2020-07-09T17:19:25.743Z] runbld>>> DURATION: 21ms
[2020-07-09T17:19:25.743Z] runbld>>> STDOUT: 40 bytes
[2020-07-09T17:19:25.743Z] runbld>>> STDERR: 49 bytes
[2020-07-09T17:19:25.743Z] runbld>>> WRAPPED PROCESS: SUCCESS (0)
[2020-07-09T17:19:25.743Z] runbld>>> Searching for build metadata in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19792/src/github.com/elastic/beats
[2020-07-09T17:19:26.684Z] runbld>>> Storing build metadata: 
[2020-07-09T17:19:26.684Z] runbld>>> Adding test report.
[2020-07-09T17:19:26.684Z] runbld>>> Searching for junit test output files with the pattern: TEST-.*\.xml$ in: /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19792/src/github.com/elastic/beats
[2020-07-09T17:19:27.625Z] runbld>>> Found 112 test output files
[2020-07-09T17:19:27.885Z] runbld>>> No testsuite node found in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19792/src/github.com/elastic/beats/Metricbeat-x-pack/x-pack/metricbeat/build/TEST-go-integration-istio.xml
[2020-07-09T17:19:27.885Z] runbld>>> No testsuite node found in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19792/src/github.com/elastic/beats/Metricbeat-x-pack/x-pack/metricbeat/build/TEST-go-integration-tomcat.xml
[2020-07-09T17:19:27.885Z] runbld>>> No testsuite node found in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19792/src/github.com/elastic/beats/Metricbeat-x-pack/x-pack/metricbeat/build/TEST-go-integration-iis.xml
[2020-07-09T17:19:27.885Z] runbld>>> No testsuite node found in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19792/src/github.com/elastic/beats/Metricbeat-x-pack/x-pack/metricbeat/build/TEST-go-integration-openmetrics.xml
[2020-07-09T17:19:27.885Z] runbld>>> No testsuite node found in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19792/src/github.com/elastic/beats/Metricbeat-x-pack/x-pack/metricbeat/build/TEST-go-integration-activemq.xml
[2020-07-09T17:19:29.285Z] runbld>>> No testsuite node found in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19792/src/github.com/elastic/beats/Metricbeat-OSS-Integration-tests/metricbeat/build/TEST-go-integration-graphite.xml
[2020-07-09T17:19:29.285Z] runbld>>> No testsuite node found in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19792/src/github.com/elastic/beats/Metricbeat-OSS-Integration-tests/metricbeat/build/TEST-go-integration-windows.xml
[2020-07-09T17:19:29.545Z] runbld>>> Test output logs contained: Errors: 0 Failures: 2 Tests: 10448 Skipped: 1166
[2020-07-09T17:19:29.805Z] runbld>>> Storing result
[2020-07-09T17:19:29.805Z] runbld>>> FAILURES: 2
[2020-07-09T17:19:30.374Z] runbld>>> Store result: updated {:total 2, :successful 2, :failed 0} 2
[2020-07-09T17:19:30.374Z] runbld>>> BUILD: https://c150076387b5421f9154dfbf536e5c60.us-west1.gcp.cloud.es.io:9243/build-1587637540455/t/20200709171924-5715653D
[2020-07-09T17:19:30.632Z] runbld>>> Email notification disabled by environment variable.
[2020-07-09T17:19:30.632Z] runbld>>> Slack notification disabled by environment variable.
[2020-07-09T17:19:36.154Z] Running on Jenkins in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19792
[2020-07-09T17:19:36.512Z] [INFO] getVaultSecret: Getting secrets
[2020-07-09T17:19:36.608Z] Masking supported pattern matches of $VAULT_ADDR or $VAULT_ROLE_ID or $VAULT_SECRET_ID
[2020-07-09T17:19:37.384Z] + chmod 755 generate-build-data.sh
[2020-07-09T17:19:37.384Z] + ./generate-build-data.sh https://beats-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/Beats/beats-beats-mbp/PR-19792/ https://beats-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/Beats/beats-beats-mbp/PR-19792/runs/2 FAILURE 7369074
[2020-07-09T17:19:37.384Z] INFO: curl https://beats-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/Beats/beats-beats-mbp/PR-19792/runs/2/steps/?limit=10000 -o steps-info.json
[2020-07-09T17:19:39.245Z] INFO: curl https://beats-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/Beats/beats-beats-mbp/PR-19792/runs/2/tests/?status=FAILED -o tests-errors.json

@kvch kvch force-pushed the backport_19753_7.x branch from a555fd4 to fbf43af Compare July 9, 2020 15:16
This PR adds support for Golang 1.14.4 in Beats. The dependency `golang.org/x/tools` is pinned to `release-branch.go1.14`.

The generated Beats no longer contain a vendor folder.

Go 1.14 has been out for quite some time. It is high time we update.

Closes elastic#18829
Closes elastic#16566

(cherry picked from commit 7580c72)
@kvch kvch force-pushed the backport_19753_7.x branch from fbf43af to 5972891 Compare July 13, 2020 12:09
@kvch kvch merged commit 569e289 into elastic:7.x Jul 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Team:Services (Deprecated) Label for the former Integrations-Services team [zube]: Done

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants