Update go version to go 1.14.3#18829
Closed
blakerouse wants to merge 9 commits intoelastic:masterfrom
Closed
Conversation
Contributor
|
Pinging @elastic/integrations-services (Team:Services) |
4 tasks
Contributor
💔 Build Failed
Expand to view the summary
Build stats
Steps errorsExpand to view the steps failures
Log outputExpand to view the last 100 lines of log output
|
Contributor
|
Pinging @elastic/ingest-management (Team:Ingest Management) |
Contributor
|
@blakerouse The failures of auditbeat and other beats seems related to theses changes? |
Contributor
Author
|
@ph Investigating them now, I know the metricbeat ones are related. |
ph
reviewed
May 29, 2020
Contributor
There was a problem hiding this comment.
oh they changed the returned string vlue.
|
Go 1.14.0 introduced a regression in the JSON parser. Due to some faulty state handling UTF-8 characters are not always handled correctly, which can result in 'splits' and invalid/mangled characters in input strings. The fix will only be available in go1.14.4. Related issues:
Checking the known issues, the JSON one is the last outstanding issue that can affect us and our users. |
Contributor
https://github.com/golang/go/issues?q=milestone%3AGo1.14.4+label%3ACherryPickApproved This is indeed a problem, there is no guarantee if it will be shipped before our next major. @blakerouse could we make it work with 1.13.x? |
Contributor
Author
|
@ph Yes I can make it work with go 1.13, switching to go 1.14 was the
easiest path, but if its broken I can make it work.
…On Fri, May 29, 2020, 11:16 AM Pier-Hugues Pellerin < ***@***.***> wrote:
Go 1.14.0 introduced a regression in the JSON parser. Due to some faulty
state handling UTF-8 characters are not always handled correctly, which can
result in 'splits' and invalid/mangled characters in input strings. The fix
will only be available in go1.14.4. Related issues:
https://github.com/golang/go/issues?q=milestone%3AGo1.14.4+label%3ACherryPickApproved
This is indeed a problem, there is no guarantee if it will be shipped
before our next major.
@blakerouse <https://github.com/blakerouse> could we make it work with
1.13.x?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#18829 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AA5QXZ4PTJAWCNGYEHNALLTRT7GUDANCNFSM4NNMLJPA>
.
|
Contributor
|
@blakerouse lets do that instead, I think it's worth it so we do not depend on Golang to release a fix. From what I've seen in the 1.14 had a rocky beginning :) |
Contributor
Author
|
Closing this, once go 1.14.4 is released we can update then. |
Contributor
|
@blakerouse FYI we have an open issue for updating Go to 1.14 with the required tasks: #16566 |
Contributor
Author
|
@kvch I used it to create this branch and linked it to that issue. Other than the regressions in go 1.14.0, I think this is close once 1.14.4 is released. I did the removal of |
Contributor
|
@blakerouse I've merged removing the vendor folder. Could you please update |
Contributor
|
|
Contributor
|
@kuisathaverat The branch is in an incorrect state at the moment. Turning off go modules is not the correct solution. We need to install it |
# Conflicts: # .ci/scripts/install-tools.bat # Jenkinsfile # auditbeat/make.bat # dev-tools/mage/fmt.go # dev-tools/mage/settings.go # dev-tools/make/mage-install.mk # filebeat/make.bat # heartbeat/make.bat # libbeat/make.bat # libbeat/scripts/Makefile # make.bat # metricbeat/make.bat # packetbeat/make.bat # winlogbeat/make.bat # x-pack/filebeat/make.bat # x-pack/winlogbeat/make.bat
kvch
approved these changes
Jul 6, 2020
Contributor
kvch
left a comment
There was a problem hiding this comment.
Once changelog is updated and everything is green, merge.
|
lint is failing. Check for usages of |
Contributor
Author
|
Setting |
Contributor
|
@blakerouse We do not have vendor folder in our repositry. So go modules is not running in vendor mode.
|
kvch
added a commit
that referenced
this pull request
Jul 9, 2020
## What does this PR do? This PR adds support for Golang 1.14.4 in Beats. The dependency `golang.org/x/tools` is pinned to `release-branch.go1.14`. The generated Beats no longer contain a vendor folder. ## Why is it important? Go 1.14 has been out for quite some time. It is high time we update. ## Related issues Closes #18829 Closes #16566
6 tasks
kvch
added a commit
to kvch/beats
that referenced
this pull request
Jul 13, 2020
This PR adds support for Golang 1.14.4 in Beats. The dependency `golang.org/x/tools` is pinned to `release-branch.go1.14`. The generated Beats no longer contain a vendor folder. Go 1.14 has been out for quite some time. It is high time we update. Closes elastic#18829 Closes elastic#16566 (cherry picked from commit 7580c72)
kvch
added a commit
that referenced
this pull request
Jul 13, 2020
This PR adds support for Golang 1.14.4 in Beats. The dependency `golang.org/x/tools` is pinned to `release-branch.go1.14`. The generated Beats no longer contain a vendor folder. Go 1.14 has been out for quite some time. It is high time we update. Closes #18829 Closes #16566 (cherry picked from commit 7580c72)
melchiormoulin
pushed a commit
to melchiormoulin/beats
that referenced
this pull request
Oct 14, 2020
## What does this PR do? This PR adds support for Golang 1.14.4 in Beats. The dependency `golang.org/x/tools` is pinned to `release-branch.go1.14`. The generated Beats no longer contain a vendor folder. ## Why is it important? Go 1.14 has been out for quite some time. It is high time we update. ## Related issues Closes elastic#18829 Closes elastic#16566
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Updates the go version to go 1.14.4. Removes the
-mod=vendorthrough out the make and mage files being that is the new default in go 1.14.Why is it important?
To be on the latest version of go 1.14.
Checklist
I have added tests that prove my fix is effective or that my feature worksCHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Author's Checklist
How to test this PR locally
Related issues
Use cases
Screenshots
Logs