Skip to content

Send the config revision down to the endpoint application.#19759

Merged
ph merged 2 commits intoelastic:masterfrom
ph:add-revision-to-yaml
Jul 9, 2020
Merged

Send the config revision down to the endpoint application.#19759
ph merged 2 commits intoelastic:masterfrom
ph:add-revision-to-yaml

Conversation

@ph
Copy link
Copy Markdown
Contributor

@ph ph commented Jul 8, 2020 •
edited
Loading

What does this PR do?

This PR make sure we forward the config revision down to the endpoint.

Why is it important?

The endpoint uses that information to send information back to Elasticsearch.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

@ph ph added review needs_backport PR is waiting to be backported to other branches. [zube]: In Review Team:Ingest Management labels Jul 8, 2020
@ph ph requested a review from blakerouse July 8, 2020 21:30
@ph ph self-assigned this Jul 8, 2020
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Jul 8, 2020

Pinging @elastic/ingest-management (Team:Ingest Management)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Jul 8, 2020
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Jul 8, 2020 •
edited
Loading

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #19759 updated]

  • Start Time: 2020-07-09T12:29:57.102+0000

  • Duration: 32 min 37 sec

Steps errors

Expand to view the steps failures

  • Name: Report to Codecov

    • Description: curl -sSLo codecov https://codecov.io/bash for i in auditbeat filebeat heartbeat libbeat metricbeat packetbeat winlogbeat journalbeat do FILE="${i}/build/coverage/full.cov" if [ -f "${FILE}" ]; then bash codecov -f "${FILE}" fi done

    • Duration: 2 min 22 sec

    • Start Time: 2020-07-09T12:50:46.699+0000

    • log

@kevinlog
Copy link
Copy Markdown

kevinlog commented Jul 8, 2020

LGTM, but more of a ceremonial approval from me since I'm not familiar with this code base, but this is important for the Endpoint config.

ph added 2 commits July 9, 2020 08:29
@ph
Send the config revision down to the endpoint application.
7180ea8 
This PR make sure we forward the config revision down to the endpoint.
@ph
Changelog
6a9d163
kaiyan-sheng
kaiyan-sheng approved these changes Jul 9, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@kaiyan-sheng kaiyan-sheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

blakerouse
blakerouse approved these changes Jul 9, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@blakerouse blakerouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@ph ph merged commit d03432b into elastic:master Jul 9, 2020
@ph ph mentioned this pull request Jul 9, 2020
Merged
6 tasks
@ph ph added v7.9.0 and removed needs_backport PR is waiting to be backported to other branches. labels Jul 9, 2020
v1v added a commit to v1v/beats that referenced this pull request Jul 9, 2020
@v1v
Merge remote-tracking branch 'upstream/master' into feature/windows-2012
82aa85e 
* upstream/master:
  Add `docker logs` support to the Elastic Log Driver (elastic#19531)
  [Elastic Agent] Fix saving of agent configuration on Windows to have proper ACLs (elastic#19793)
  Send the config revision down to the endpoint application. (elastic#19759)
  [Elastic Agent] Add support for multiple hosts in connection to kibana (elastic#19628)
  Remove the downloadConfig and retryConfig from plugin/process.Application and plugin/service.Application. (elastic#19603)
  Update go version to 1.14.4 (elastic#19753)
  ci: set builds as skipped when they do not match the trigger (elastic#19750)
  [Auditbeat] Fix up socket dataset runaway CPU usage (elastic#19764)
  Convert cloudfoundry input to v2 (elastic#19717)
v1v added a commit to v1v/beats that referenced this pull request Jul 9, 2020
@v1v
Merge remote-tracking branch 'upstream/master' into feature/windows-2008
ee0d403 
* upstream/master:
  Add `docker logs` support to the Elastic Log Driver (elastic#19531)
  [Elastic Agent] Fix saving of agent configuration on Windows to have proper ACLs (elastic#19793)
  Send the config revision down to the endpoint application. (elastic#19759)
  [Elastic Agent] Add support for multiple hosts in connection to kibana (elastic#19628)
v1v added a commit to v1v/beats that referenced this pull request Jul 9, 2020
@v1v
Merge remote-tracking branch 'upstream/master' into feature/windows-7-32
3ad1a52 
* upstream/master:
  Add `docker logs` support to the Elastic Log Driver (elastic#19531)
  [Elastic Agent] Fix saving of agent configuration on Windows to have proper ACLs (elastic#19793)
  Send the config revision down to the endpoint application. (elastic#19759)
ph added a commit that referenced this pull request Jul 9, 2020
@ph
Send the config revision down to the endpoint application. (#19759) (#…
dc621a5 
…19802)

* Send the config revision down to the endpoint application.

This PR make sure we forward the config revision down to the endpoint.

(cherry picked from commit d03432b)
melchiormoulin pushed a commit to melchiormoulin/beats that referenced this pull request Oct 14, 2020
@ph @melchiormoulin
Send the config revision down to the endpoint application. (elastic#1…
078bd14 
…9759)

* Send the config revision down to the endpoint application.

This PR make sure we forward the config revision down to the endpoint.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@blakerouse blakerouse blakerouse approved these changes

+1 more reviewer

@kaiyan-sheng kaiyan-sheng kaiyan-sheng approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@ph ph

Labels

review v7.9.0 [zube]: In Review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ph @elasticmachine @kevinlog @blakerouse @kaiyan-sheng