Skip to content

Fix log path format in logging example#10647

Merged
dedemorton merged 1 commit intoelastic:masterfrom
dedemorton:issue#10646
Feb 21, 2019
Merged

Fix log path format in logging example#10647
dedemorton merged 1 commit intoelastic:masterfrom
dedemorton:issue#10646

Conversation

@dedemorton
Copy link
Copy Markdown
Contributor

Closes #10646

Doesn't seem to matter if you use forward or backslashes in the config file, but doing so is more intuitive for windows users, so I've changed that, too.

@dedemorton dedemorton added review needs_backport PR is waiting to be backported to other branches. labels Feb 8, 2019
@dedemorton dedemorton requested a review from a team February 8, 2019 02:09
@dedemorton dedemorton merged commit b2ce8bc into elastic:master Feb 21, 2019
@dedemorton dedemorton deleted the issue#10646 branch February 21, 2019 18:08
dedemorton added a commit to dedemorton/beats that referenced this pull request Mar 6, 2019
dedemorton added a commit to dedemorton/beats that referenced this pull request Mar 6, 2019
dedemorton added a commit to dedemorton/beats that referenced this pull request Mar 6, 2019
@dedemorton dedemorton removed the needs_backport PR is waiting to be backported to other branches. label Mar 6, 2019
dedemorton added a commit that referenced this pull request Mar 20, 2019
…10859 ) (#11122)

* Fix log path format in logging example (#10647)

* Add systemd compatibility statement (#10740)

* Remove simplistic docker command examples (#10741)

* Fix attribute references (#10742)

* Remove broken link to docker source code (#10833)

* Remove link to old repo for docker source

* Remove dockergithub attribute

* Add links to Logstash docs about working with Filebeat modules (#10859)
dedemorton added a commit that referenced this pull request Mar 20, 2019
…0833 #10859)  (#11120)

* Add steps for loading journalbeat dashboards  (#9167)

* Add steps for loading and viewing dashboards

* Deprecate global options for backoff, max_backoff, seek, and include_matches

* Add screen capture

* Move tip to correct place in doc

* Fix log path format in logging example (#10647)

* Add systemd compatibility statement (#10740)

* Remove simplistic docker command examples (#10741)

* Fix attribute references (#10742)

* Remove broken link to docker source code (#10833)

* Remove link to old repo for docker source

* Remove dockergithub attribute

* Add links to Logstash docs about working with Filebeat modules (#10859)
dedemorton added a commit that referenced this pull request Mar 21, 2019
…0833 #10859) (#11119)

* Add steps for loading journalbeat dashboards  (#9167)

* Add steps for loading and viewing dashboards

* Deprecate global options for backoff, max_backoff, seek, and include_matches

* Add screen capture

* Move tip to correct place in doc

* Fix log path format in logging example (#10647)

* Add systemd compatibility statement (#10740)

* Remove simplistic docker command examples (#10741)

* Fix attribute references (#10742)

* Remove broken link to docker source code (#10833)

* Remove link to old repo for docker source

* Remove dockergithub attribute

* Add links to Logstash docs about working with Filebeat modules (#10859)
DStape pushed a commit to DStape/beats that referenced this pull request Aug 20, 2019
…0740 elastic#10741 elastic#10742 elastic#10833 elastic#10859) (elastic#11119)

* Add steps for loading journalbeat dashboards  (elastic#9167)

* Add steps for loading and viewing dashboards

* Deprecate global options for backoff, max_backoff, seek, and include_matches

* Add screen capture

* Move tip to correct place in doc

* Fix log path format in logging example (elastic#10647)

* Add systemd compatibility statement (elastic#10740)

* Remove simplistic docker command examples (elastic#10741)

* Fix attribute references (elastic#10742)

* Remove broken link to docker source code (elastic#10833)

* Remove link to old repo for docker source

* Remove dockergithub attribute

* Add links to Logstash docs about working with Filebeat modules (elastic#10859)
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
…10741 elastic#10742 elastic#10833 elastic#10859 ) (elastic#11122)

* Fix log path format in logging example (elastic#10647)

* Add systemd compatibility statement (elastic#10740)

* Remove simplistic docker command examples (elastic#10741)

* Fix attribute references (elastic#10742)

* Remove broken link to docker source code (elastic#10833)

* Remove link to old repo for docker source

* Remove dockergithub attribute

* Add links to Logstash docs about working with Filebeat modules (elastic#10859)
andrewkroh added a commit to andrewkroh/beats that referenced this pull request Aug 27, 2024
When a region is not specified in the SQS notification then reuse the existing
S3 client instead of creating a new one based on an empty (unspecified) AWS
region name. This problem affected custom SQS notification formats that did
not specify a region name (like Crowdstrike FDR notifications).

Fixes: elastic/integrations/elastic#10647
Relates: elastic#40309
andrewkroh added a commit to andrewkroh/beats that referenced this pull request Aug 27, 2024
When a region is not specified in the SQS notification then reuse the existing
S3 client instead of creating a new one based on an empty (unspecified) AWS
region name. This problem affected custom SQS notification formats that did
not specify a region name (like Crowdstrike FDR notifications).

This addresses errors like:

    S3 download failure: s3 GetObject failed: operation error S3: GetObject, resolve auth scheme: resolve endpoint: endpoint rule error, Invalid region: region was not a valid DNS name.

Fixes: elastic/integrations/elastic#10647
Relates: elastic#40309
andrewkroh added a commit that referenced this pull request Aug 27, 2024
…#40628)

When a region is not specified in the SQS notification then reuse the existing
S3 client instead of creating a new one based on an empty (unspecified) AWS
region name. This problem affected custom SQS notification formats that did
not specify a region name (like Crowdstrike FDR notifications).

This addresses errors like:

    S3 download failure: s3 GetObject failed: operation error S3: GetObject, resolve auth scheme: resolve endpoint: endpoint rule error, Invalid region: region was not a valid DNS name.

Fixes: elastic/integrations/#10647
Relates: #40309
mergify bot pushed a commit that referenced this pull request Aug 27, 2024
…#40628)

When a region is not specified in the SQS notification then reuse the existing
S3 client instead of creating a new one based on an empty (unspecified) AWS
region name. This problem affected custom SQS notification formats that did
not specify a region name (like Crowdstrike FDR notifications).

This addresses errors like:

    S3 download failure: s3 GetObject failed: operation error S3: GetObject, resolve auth scheme: resolve endpoint: endpoint rule error, Invalid region: region was not a valid DNS name.

Fixes: elastic/integrations/#10647
Relates: #40309
(cherry picked from commit 6d25d46)
andrewkroh added a commit that referenced this pull request Aug 27, 2024
…#40628) (#40632)

When a region is not specified in the SQS notification then reuse the existing
S3 client instead of creating a new one based on an empty (unspecified) AWS
region name. This problem affected custom SQS notification formats that did
not specify a region name (like Crowdstrike FDR notifications).

This addresses errors like:

    S3 download failure: s3 GetObject failed: operation error S3: GetObject, resolve auth scheme: resolve endpoint: endpoint rule error, Invalid region: region was not a valid DNS name.

Fixes: elastic/integrations/#10647
Relates: #40309

(cherry picked from commit 6d25d46)

Co-authored-by: Andrew Kroh <andrew.kroh@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants