Remove broken link to docker source code#10833
Merged
dedemorton merged 2 commits intoelastic:masterfrom Feb 25, 2019
Merged
Conversation
jsoriano
approved these changes
Feb 20, 2019
Member
jsoriano
left a comment
There was a problem hiding this comment.
I don't see why users need to know where the source lives (especially now that it's in the main beats repo), so I removed the sentence.
Agree, LGTM.
I think this should be backported till 6.6, the first version where docker images are built from this repo.
4359cb4 to
d0fc3ca
Compare
Contributor
Author
|
Force pushed to see if that fixes CI. |
Member
|
@dedemorton feel free to merge this, I don't think CI failures are related. |
dedemorton
added a commit
to dedemorton/beats
that referenced
this pull request
Mar 6, 2019
* Remove link to old repo for docker source * Remove dockergithub attribute
dedemorton
added a commit
to dedemorton/beats
that referenced
this pull request
Mar 6, 2019
* Remove link to old repo for docker source * Remove dockergithub attribute
dedemorton
added a commit
to dedemorton/beats
that referenced
this pull request
Mar 6, 2019
* Remove link to old repo for docker source * Remove dockergithub attribute
dedemorton
added a commit
that referenced
this pull request
Mar 20, 2019
…10859 ) (#11122) * Fix log path format in logging example (#10647) * Add systemd compatibility statement (#10740) * Remove simplistic docker command examples (#10741) * Fix attribute references (#10742) * Remove broken link to docker source code (#10833) * Remove link to old repo for docker source * Remove dockergithub attribute * Add links to Logstash docs about working with Filebeat modules (#10859)
dedemorton
added a commit
that referenced
this pull request
Mar 20, 2019
…0833 #10859) (#11120) * Add steps for loading journalbeat dashboards (#9167) * Add steps for loading and viewing dashboards * Deprecate global options for backoff, max_backoff, seek, and include_matches * Add screen capture * Move tip to correct place in doc * Fix log path format in logging example (#10647) * Add systemd compatibility statement (#10740) * Remove simplistic docker command examples (#10741) * Fix attribute references (#10742) * Remove broken link to docker source code (#10833) * Remove link to old repo for docker source * Remove dockergithub attribute * Add links to Logstash docs about working with Filebeat modules (#10859)
dedemorton
added a commit
that referenced
this pull request
Mar 21, 2019
…0833 #10859) (#11119) * Add steps for loading journalbeat dashboards (#9167) * Add steps for loading and viewing dashboards * Deprecate global options for backoff, max_backoff, seek, and include_matches * Add screen capture * Move tip to correct place in doc * Fix log path format in logging example (#10647) * Add systemd compatibility statement (#10740) * Remove simplistic docker command examples (#10741) * Fix attribute references (#10742) * Remove broken link to docker source code (#10833) * Remove link to old repo for docker source * Remove dockergithub attribute * Add links to Logstash docs about working with Filebeat modules (#10859)
DStape
pushed a commit
to DStape/beats
that referenced
this pull request
Aug 20, 2019
…0740 elastic#10741 elastic#10742 elastic#10833 elastic#10859) (elastic#11119) * Add steps for loading journalbeat dashboards (elastic#9167) * Add steps for loading and viewing dashboards * Deprecate global options for backoff, max_backoff, seek, and include_matches * Add screen capture * Move tip to correct place in doc * Fix log path format in logging example (elastic#10647) * Add systemd compatibility statement (elastic#10740) * Remove simplistic docker command examples (elastic#10741) * Fix attribute references (elastic#10742) * Remove broken link to docker source code (elastic#10833) * Remove link to old repo for docker source * Remove dockergithub attribute * Add links to Logstash docs about working with Filebeat modules (elastic#10859)
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
…10741 elastic#10742 elastic#10833 elastic#10859 ) (elastic#11122) * Fix log path format in logging example (elastic#10647) * Add systemd compatibility statement (elastic#10740) * Remove simplistic docker command examples (elastic#10741) * Fix attribute references (elastic#10742) * Remove broken link to docker source code (elastic#10833) * Remove link to old repo for docker source * Remove dockergithub attribute * Add links to Logstash docs about working with Filebeat modules (elastic#10859)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes issue #10821
@jsoriano I don't see why users need to know where the source lives (especially now that it's in the main beats repo), so I removed the sentence. Let me know if you would prefer that I update the link instead. Also let me know how far I should backport this change. Usually we only do the current and future branches.