Skip to content

[8.15](backport #40628) x-pack/filebeat/inputs/awss3 - Handle SQS notification without region#40632

Merged
andrewkroh merged 1 commit into8.15from
mergify/bp/8.15/pr-40628
Aug 27, 2024
Merged

[8.15](backport #40628) x-pack/filebeat/inputs/awss3 - Handle SQS notification without region#40632
andrewkroh merged 1 commit into8.15from
mergify/bp/8.15/pr-40628

Conversation

@mergify
Copy link
Copy Markdown
Contributor

@mergify mergify bot commented Aug 27, 2024

Proposed commit message

When a region is not specified in the SQS notification then reuse the existing S3 client instead of creating a new one based on an empty (unspecified) AWS region name. This problem affected custom SQS notification formats that did not specify a region name (like Crowdstrike FDR notifications).

This addresses errors like:

S3 download failure: s3 GetObject failed: operation error S3: GetObject, resolve auth scheme:
resolve endpoint: endpoint rule error, Invalid region: region was not a valid DNS name.

Fixes: elastic/integrations#10647
Relates: #40309

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues


This is an automatic backport of pull request #40628 done by [Mergify](https://mergify.com).

…#40628)

When a region is not specified in the SQS notification then reuse the existing
S3 client instead of creating a new one based on an empty (unspecified) AWS
region name. This problem affected custom SQS notification formats that did
not specify a region name (like Crowdstrike FDR notifications).

This addresses errors like:

    S3 download failure: s3 GetObject failed: operation error S3: GetObject, resolve auth scheme: resolve endpoint: endpoint rule error, Invalid region: region was not a valid DNS name.

Fixes: elastic/integrations/#10647
Relates: #40309
(cherry picked from commit 6d25d46)
@mergify mergify bot requested a review from a team as a code owner August 27, 2024 15:30
@mergify mergify bot added the backport label Aug 27, 2024
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Aug 27, 2024
@andrewkroh andrewkroh enabled auto-merge (squash) August 27, 2024 15:45
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Aug 27, 2024
@andrewkroh andrewkroh merged commit 0788765 into 8.15 Aug 27, 2024
@andrewkroh andrewkroh deleted the mergify/bp/8.15/pr-40628 branch August 27, 2024 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant