Skip to content

Revert "Throw NotImplementedException when a build errorId is not supported"#82638

Merged
jjonescz merged 2 commits intomainfrom
revert-82508-dev/jorobich/fix-error-list
Mar 6, 2026
Merged

Revert "Throw NotImplementedException when a build errorId is not supported"#82638
jjonescz merged 2 commits intomainfrom
revert-82508-dev/jorobich/fix-error-list

Conversation

@ToddGrun
Copy link
Contributor

@ToddGrun ToddGrun commented Mar 5, 2026

Reverts #82508

@ToddGrun
Copy link
Contributor Author

ToddGrun commented Mar 5, 2026

/pr-val

@github-actions
Copy link
Contributor

github-actions bot commented Mar 5, 2026

View PR Validation Run triggered by @ToddGrun

Parameters
  • Validation Type: pr-val
  • Pipeline ID: 8972
  • Pipeline Version: main
  • PR Number: 82638
  • Commit SHA: f8b5b616095b18ba056467b7837a422e12ebb8a4
  • Source Branch: revert-82508-dev/jorobich/fix-error-list
  • Target Branch: main
  • Build ID: 13470413

@jjonescz
Copy link
Member

jjonescz commented Mar 5, 2026

/pr-val

EDIT: GitHub Actions are currently having issues; started the run manually: https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=13471091&view=results

https://dev.azure.com/devdiv/DevDiv/_git/VS/pullrequest/714873

@JoeRobich
Copy link
Member

I would be a bit surprised if this PR was an issue as we have other insertions of this change with no regressions.
insiders insertion

@jjonescz
Copy link
Member

jjonescz commented Mar 6, 2026

@JoeRobich I know and I'm surprised too, but DDRITs passed in this revert.

@JoeRobich
Copy link
Member

I am doing a val run of a modification of this which should do less work. Especially in CPS project scenarios. See #82643

@JoeRobich
Copy link
Member

Well first change didn't go as well as expected. I've made another change which I am testing now. I would say revert if this unblocks and I will keep working on making my fix less impactful.

@jjonescz jjonescz marked this pull request as ready for review March 6, 2026 17:02
@jjonescz jjonescz requested review from a team as code owners March 6, 2026 17:02
@jjonescz jjonescz enabled auto-merge (squash) March 6, 2026 17:43
@jjonescz jjonescz merged commit 797317e into main Mar 6, 2026
27 of 28 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the Next milestone Mar 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants