Skip to content

Revert "Throw NotImplementedException when a build errorId is not supported"#82638

Merged
jjonescz merged 2 commits into
mainfrom
revert-82508-dev/jorobich/fix-error-list
Mar 6, 2026
Merged

Revert "Throw NotImplementedException when a build errorId is not supported"#82638
jjonescz merged 2 commits into
mainfrom
revert-82508-dev/jorobich/fix-error-list

Conversation

@ToddGrun

@ToddGrun ToddGrun commented Mar 5, 2026

Copy link
Copy Markdown
Contributor

Reverts #82508

@ToddGrun

ToddGrun commented Mar 5, 2026

Copy link
Copy Markdown
Contributor Author

/pr-val

@github-actions

github-actions Bot commented Mar 5, 2026

Copy link
Copy Markdown
Contributor

View PR Validation Run triggered by @ToddGrun

Parameters
  • Validation Type: pr-val
  • Pipeline ID: 8972
  • Pipeline Version: main
  • PR Number: 82638
  • Commit SHA: f8b5b616095b18ba056467b7837a422e12ebb8a4
  • Source Branch: revert-82508-dev/jorobich/fix-error-list
  • Target Branch: main
  • Build ID: 13470413

@jjonescz

jjonescz commented Mar 5, 2026

Copy link
Copy Markdown
Member

/pr-val

EDIT: GitHub Actions are currently having issues; started the run manually: https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=13471091&view=results

https://dev.azure.com/devdiv/DevDiv/_git/VS/pullrequest/714873

@JoeRobich

Copy link
Copy Markdown
Member

I would be a bit surprised if this PR was an issue as we have other insertions of this change with no regressions.
insiders insertion

@jjonescz

jjonescz commented Mar 6, 2026

Copy link
Copy Markdown
Member

@JoeRobich I know and I'm surprised too, but DDRITs passed in this revert.

@JoeRobich

Copy link
Copy Markdown
Member

I am doing a val run of a modification of this which should do less work. Especially in CPS project scenarios. See #82643

@JoeRobich

Copy link
Copy Markdown
Member

Well first change didn't go as well as expected. I've made another change which I am testing now. I would say revert if this unblocks and I will keep working on making my fix less impactful.

@jjonescz jjonescz marked this pull request as ready for review March 6, 2026 17:02
@jjonescz jjonescz requested review from a team as code owners March 6, 2026 17:02
@jjonescz jjonescz enabled auto-merge (squash) March 6, 2026 17:43
@jjonescz jjonescz merged commit 797317e into main Mar 6, 2026
27 of 28 checks passed
@dotnet-policy-service dotnet-policy-service Bot added this to the Next milestone Mar 6, 2026
333fred added a commit to 333fred/roslyn that referenced this pull request Mar 9, 2026
* upstream/main: (56 commits)
  [main] Source code updates from dotnet/dotnet (dotnet#82655)
  Update insert.yml to use roslyn-tools for insertions (dotnet#82615)
  Localized file check-in by OneLocBuild Task: Build definition ID 327: Build ID 2921538
  Localized file check-in by OneLocBuild Task: Build definition ID 327: Build ID 2921538
  Reduce allocations during source text diffing (dotnet#82462)
  Localized file check-in by OneLocBuild Task: Build definition ID 327: Build ID 2920904
  Localized file check-in by OneLocBuild Task: Build definition ID 327: Build ID 2920904
  Revert "Throw NotImplementedException when a build errorId is not supported" (dotnet#82638)
  [main] Source code updates from dotnet/dotnet (dotnet#82623)
  Revert System.ValueTuple version update (dotnet#82639)
  Pack enum values
  Track non-blocking PROTOTYPE comments for `Unions` feature in an issue (dotnet#82637)
  Update the build system errors instructions for Visual Studio 2026
  Don't log named pipe connection failures as errors in BuildServerConnection (dotnet#82609)
  Fix resx source generator for less common resx metadata and locations (dotnet#81994)
  Disallow `ref` modifier for a union declaration (dotnet#82632)
  Add IFSharpInlineHintsService2 for displayAllOverride support (dotnet#82629)
  Report errors for union members that are not permitted (dotnet#82626)
  Check language version for union matching and conversions (dotnet#82617)
  [main] Update dependencies from dotnet/arcade (dotnet#82618)
  ...
@jjonescz jjonescz modified the milestones: Next, 18.6 Mar 31, 2026
@JoeRobich JoeRobich deleted the revert-82508-dev/jorobich/fix-error-list branch May 22, 2026 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants