Open
Conversation
Member
Author
|
/pr-val |
Contributor
|
View PR Validation Run triggered by @JoeRobich Parameters
|
Member
Author
|
/pr-val |
Contributor
|
View PR Validation Run triggered by @JoeRobich Parameters
|
ToddGrun
reviewed
Mar 6, 2026
| /// <summary> | ||
| /// Returns all the DiagnosticIds producible by the referenced DiagnosticAnalyzers. | ||
| /// </summary> | ||
| public ImmutableHashSet<string> GetAllDiagnosticIds( |
Contributor
Contributor
There was a problem hiding this comment.
To be fair, this is no worse than the code directly below it creating ImmutableDictionary objects when it seems like it could be using ReadOnlyDictionary objects.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We added a diagnostic id cache to answer whether a build error was supported by a particular project. This cache stored diagnostic ids for all projects in the solution. However it was only being used for legacy projects. This means we were doing too much work.
This PR changes the cache to only store diagnostic ids for registered projects and updates the AbstractLegacyProject to register new projects with the cache when they are created.