Check language version for union matching and conversions#82617
Merged
Conversation
Contributor
Author
|
@RikkiGibson, @jjonescz, @dotnet/roslyn-compiler Please review |
jjonescz
approved these changes
Mar 4, 2026
| "); | ||
|
|
||
| comp = CreateCompilation([src, UnionAttributeSource], targetFramework: TargetFramework.NetCoreApp, options: TestOptions.ReleaseExe, parseOptions: TestOptions.RegularNext); | ||
| CompileAndVerify(comp, expectedOutput: ExecutionConditionUtil.IsMonoOrCoreClr ? "TrueFalseFalseFalse TrueFalseFalseFalseTrue FalseFalseTrue FalseTrueFalse TrueFalseFalseFalseFalse" : null, verify: Verification.FailsPEVerify).VerifyDiagnostics(); |
Member
There was a problem hiding this comment.
Can we extract the expected output into a variable to make it clearer it's expected to be the same between both CompileAndVerify calls?
Contributor
Author
There was a problem hiding this comment.
Can we extract the expected output into a variable to make it clearer it's expected to be the same between both CompileAndVerify calls?
I do not think it is worth doing.
RikkiGibson
approved these changes
Mar 4, 2026
333fred
added a commit
to 333fred/roslyn
that referenced
this pull request
Mar 9, 2026
* upstream/main: (56 commits) [main] Source code updates from dotnet/dotnet (dotnet#82655) Update insert.yml to use roslyn-tools for insertions (dotnet#82615) Localized file check-in by OneLocBuild Task: Build definition ID 327: Build ID 2921538 Localized file check-in by OneLocBuild Task: Build definition ID 327: Build ID 2921538 Reduce allocations during source text diffing (dotnet#82462) Localized file check-in by OneLocBuild Task: Build definition ID 327: Build ID 2920904 Localized file check-in by OneLocBuild Task: Build definition ID 327: Build ID 2920904 Revert "Throw NotImplementedException when a build errorId is not supported" (dotnet#82638) [main] Source code updates from dotnet/dotnet (dotnet#82623) Revert System.ValueTuple version update (dotnet#82639) Pack enum values Track non-blocking PROTOTYPE comments for `Unions` feature in an issue (dotnet#82637) Update the build system errors instructions for Visual Studio 2026 Don't log named pipe connection failures as errors in BuildServerConnection (dotnet#82609) Fix resx source generator for less common resx metadata and locations (dotnet#81994) Disallow `ref` modifier for a union declaration (dotnet#82632) Add IFSharpInlineHintsService2 for displayAllOverride support (dotnet#82629) Report errors for union members that are not permitted (dotnet#82626) Check language version for union matching and conversions (dotnet#82617) [main] Update dependencies from dotnet/arcade (dotnet#82618) ...
This was referenced Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.