Skip to content

Update insert.yml to use roslyn-tools for insertions#82615

Merged
jjonescz merged 4 commits into
mainfrom
dev/jorobich/insert-with-roslyn-tools
Mar 9, 2026
Merged

Update insert.yml to use roslyn-tools for insertions#82615
jjonescz merged 4 commits into
mainfrom
dev/jorobich/insert-with-roslyn-tools

Conversation

@JoeRobich

@JoeRobich JoeRobich commented Mar 3, 2026

Copy link
Copy Markdown
Member

With roslyn-tools tool supporting insertions, we should move off the RIT tool.

Test Run

@dotnet dotnet deleted a comment from github-actions Bot Mar 3, 2026
Comment thread eng/pipelines/insert.yml Outdated
@JoeRobich JoeRobich force-pushed the dev/jorobich/insert-with-roslyn-tools branch from 2225441 to 01ae8f5 Compare March 5, 2026 14:31
@JoeRobich JoeRobich marked this pull request as ready for review March 5, 2026 17:26
@JoeRobich JoeRobich requested a review from a team as a code owner March 5, 2026 17:26
@JoeRobich JoeRobich requested review from akhera99 and jjonescz March 5, 2026 17:26
Comment thread eng/pipelines/insert.yml

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we wait with merging this PR until our roslyn insertions are stable? Thanks.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please merge when things settle down =)

@jjonescz jjonescz merged commit dcc3438 into main Mar 9, 2026
28 checks passed
@dotnet-policy-service dotnet-policy-service Bot added this to the Next milestone Mar 9, 2026
333fred added a commit to 333fred/roslyn that referenced this pull request Mar 9, 2026
* upstream/main: (56 commits)
  [main] Source code updates from dotnet/dotnet (dotnet#82655)
  Update insert.yml to use roslyn-tools for insertions (dotnet#82615)
  Localized file check-in by OneLocBuild Task: Build definition ID 327: Build ID 2921538
  Localized file check-in by OneLocBuild Task: Build definition ID 327: Build ID 2921538
  Reduce allocations during source text diffing (dotnet#82462)
  Localized file check-in by OneLocBuild Task: Build definition ID 327: Build ID 2920904
  Localized file check-in by OneLocBuild Task: Build definition ID 327: Build ID 2920904
  Revert "Throw NotImplementedException when a build errorId is not supported" (dotnet#82638)
  [main] Source code updates from dotnet/dotnet (dotnet#82623)
  Revert System.ValueTuple version update (dotnet#82639)
  Pack enum values
  Track non-blocking PROTOTYPE comments for `Unions` feature in an issue (dotnet#82637)
  Update the build system errors instructions for Visual Studio 2026
  Don't log named pipe connection failures as errors in BuildServerConnection (dotnet#82609)
  Fix resx source generator for less common resx metadata and locations (dotnet#81994)
  Disallow `ref` modifier for a union declaration (dotnet#82632)
  Add IFSharpInlineHintsService2 for displayAllOverride support (dotnet#82629)
  Report errors for union members that are not permitted (dotnet#82626)
  Check language version for union matching and conversions (dotnet#82617)
  [main] Update dependencies from dotnet/arcade (dotnet#82618)
  ...
@jjonescz jjonescz modified the milestones: Next, 18.6 Mar 31, 2026
dibarbet pushed a commit that referenced this pull request Apr 23, 2026
dibarbet pushed a commit that referenced this pull request Apr 23, 2026
@JoeRobich JoeRobich deleted the dev/jorobich/insert-with-roslyn-tools branch May 22, 2026 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants