Skip to content

Merge 'main' into 'features/struct-ctors'#54410

Merged
cston merged 1462 commits intodotnet:features/struct-ctorsfrom
cston:main-to-struct-ctors
Jun 30, 2021
Merged

Merge 'main' into 'features/struct-ctors'#54410
cston merged 1462 commits intodotnet:features/struct-ctorsfrom
cston:main-to-struct-ctors

Conversation

@cston
Copy link
Contributor

@cston cston commented Jun 26, 2021

No description provided.

JoeRobich and others added 30 commits June 15, 2021 11:12
Restore support for disabling structure guides
…MembersInInterfaceFix

Fix GoToBase/GoToImplementation/FAR/InheritanceMargin for static abstract member
…ike a resultId we can pass between the client and server
Add Quick Info tests for static abstract inheritdoc
* Add formatting options

* Update codestyle version

* Update version

* enable

* keep together

* Fix warning

* Formatting style

* Formatting style

* Formatting style

* Formatting style

* Formatting style

* Formatting style

* Formatting style

* Formatting style

* Formatting style

* Formatting style

* Formatting style

* Formatting style

* Formatting style

* Revert

* Disable

* Place colon consistently

* Fix IDE0059: Unnecessary assignment

* Fix IDE0059: Unnecessary assignment

* Fix IDE0059: Unnecessary assignment

* Fix IDE0059: Unnecessary assignment

* Fix IDE0059: Unnecessary assignment

* Fix IDE0059: Unnecessary assignment

* Fix IDE0059: Unnecessary assignment

* Fix IDE0059: Unnecessary assignment

* Revert

* Disable

* Disable

* Disable

* Disable

* Fix IDE0059: Unnecessary assignment

* Fix IDE0059: Unnecessary assignment

* Fix IDE0059: Unnecessary assignment

* Fix IDE0059: Unnecessary assignment

* Fix IDE0059: Unnecessary assignment

* Fix IDE0059: Unnecessary assignment

* Fix IDE0059: Unnecessary assignment

* Update .editorconfig

* Update .editorconfig

* move options

* Only run on IDE code
…ginTitleFix

Change the header of inheritance margin
…ethods. (dotnet#54118)

* Pack error codes.

* Disallow UnmanagedCallersOnly for abstract static methods.
…ed builds inside Visual Studio

Work towards [AB#1337109](https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1337109)

For builds which are indirectly triggered inside Visual Studio from commands such as 'Run Tests' or 'Start Debugging', we implicitly skip analyzers to speed up these builds.

Such builds will set a special property `IsIndirectlyTriggeredBuildInsideVisualStudio` to `true`, which guards the implicit skip analyzers logic. We display a special message to inform the users about us implicitly skipping analyzers to speed up the build.

To enable MSBuild's incremental build logic and project system's fast-upto-date check logic to work correctly, we create/touch a special semaphore file to indicate the time stamp for last build with skipAnalyzers flag. This semaphore file is passed as a custom additional file input to builds without skipAnalyzers flag to ensure correct incremental builds. Additionally, we pass this file as an 'UpToDateCheckInput' item for project system's fast-upto-date check.
RikkiGibson and others added 16 commits June 25, 2021 12:27
Co-authored-by: Joey Robichaud <joseph.robichaud@microsoft.com>
* Fix nodestate table .Single() in presence of removes + add tests

* Add new APIs for state updates.

* Wire up new APIs in the IDE layer

* Add tests

* Apply suggestions from code review

Co-authored-by: Andrew Hall <ryzngard@live.com>

* Add missing using

* Add tests and check for null

* Throw for null replacement operations

Co-authored-by: Andrew Hall <ryzngard@live.com>
Speed up progression searches by using the navigate-to index
…tree_navigation

Value tracking originally used the standard WPF navigation pattern. This would also navigate to the source line based on selection.

This improves the design by manually handling keyboard navigation for most cases. By default, if an item is selected it no longer navigates to source. There are conditions where this is different:

| Shortcut | Expand Behavior | Navigates To Source | Previous or Next |
| --------- | ---------------- | ---------------------- | --------------------- |
| Arrow Down | False | True| Next |
| Arrow Up | False | True| Next |
| Arrow Left | Collapse Only | False | Neither |
| Arrow Right | Expand Only | False | Neither |
| Space | Toggle | False | Neither |
| Enter | False | True | Neither |
| F8 | Expand Only | True | Next |
| Shift + F8 | False | True | Previous |
| Click | False | True| Neither |
| Double Click | False | True | Neither |
Co-authored-by: David Wengier <david.wengier@microsoft.com>
…ation

Thread cancellation tokens through progression in more places.
@cston cston requested review from a team as code owners June 26, 2021 04:50
@cston cston requested a review from a team June 26, 2021 04:50
@ghost ghost added the Area-Compilers label Jun 26, 2021
@RikkiGibson
Copy link
Member

Anything in this merge that wasn't run of the mill/straightforward?

@cston
Copy link
Contributor Author

cston commented Jun 26, 2021

Anything in this merge that wasn't run of the mill/straightforward?

There were no conflicts because there have been no other commits to this branch yet.

@cston cston added Blocked and removed Blocked labels Jun 26, 2021
@cston cston merged commit 04bc5e4 into dotnet:features/struct-ctors Jun 30, 2021
@cston cston deleted the main-to-struct-ctors branch June 30, 2021 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.