Fix GoToBase/GoToImplementation/FAR/InheritanceMargin for static abstract member#54056
Merged
Cosifne merged 13 commits intodotnet:features/StaticAbstractMembersInInterfacesfrom Jun 15, 2021
Conversation
sharwell
approved these changes
Jun 14, 2021
| if (symbol is INamedTypeSymbol) | ||
| { | ||
| return false; | ||
| return !symbol.IsStatic; |
Contributor
There was a problem hiding this comment.
❔ Can static types implement interfaces with only static abstract members?
Member
Author
There was a problem hiding this comment.
https://github.com/dotnet/csharplang/blob/main/proposals/static-abstracts-in-interfaces.md
At least from the existing document, I don't think static type could do that.
sharwell
reviewed
Jun 14, 2021
|
|
||
| class C2_1 : I2 | ||
| { | ||
| public static int {|Definition:P2|} { get; set; } |
Contributor
There was a problem hiding this comment.
💭 I'm not sure we want this one included for FAR (with unidirectional hierarchy cascade), but we can adjust this later. We would want it for rename operations.
This was referenced Jun 16, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix part of this issue: #52221
All the fixes are in GoToBase/GoToImplementation/FAR/InheritanceMargin