Add 'replace' APIs and hook them up to the IDE#54270
Merged
chsienki merged 8 commits intodotnet:mainfrom Jun 25, 2021
Merged
Conversation
Member
Author
|
@dotnet/roslyn-compiler & @dotnet/roslyn-ide for review please :) |
cston
reviewed
Jun 22, 2021
Contributor
Member
Author
There was a problem hiding this comment.
Sort of, but not currently in the way the NodeStateTable is used. In the cases where nodes call Single() there should ever be one element, or one removed and a new one that replaces it. We could move the stronger assertion out to the callsites, and allow the state table to contain multiple removed elements, but given that nothing else uses it right now, it seems fine to leave it here.
cston
reviewed
Jun 22, 2021
src/Compilers/Core/Portable/SourceGeneration/GeneratorDriver.cs
Outdated
Show resolved
Hide resolved
cston
approved these changes
Jun 22, 2021
ryzngard
reviewed
Jun 23, 2021
...e/Workspace/Solution/SolutionState.CompilationAndGeneratorDriverTranslationAction_Actions.cs
Outdated
Show resolved
Hide resolved
ryzngard
reviewed
Jun 23, 2021
...e/Workspace/Solution/SolutionState.CompilationAndGeneratorDriverTranslationAction_Actions.cs
Outdated
Show resolved
Hide resolved
jmarolf
approved these changes
Jun 23, 2021
jcouv
reviewed
Jun 23, 2021
src/Compilers/Core/Portable/SourceGeneration/GeneratorDriver.cs
Outdated
Show resolved
Hide resolved
jcouv
reviewed
Jun 23, 2021
src/Compilers/CSharp/Test/Semantic/SourceGeneration/GeneratorDriverTests.cs
Outdated
Show resolved
Hide resolved
jcouv
reviewed
Jun 23, 2021
Member
jcouv
left a comment
There was a problem hiding this comment.
Done with review pass (iteration 6)
cston
reviewed
Jun 24, 2021
src/Compilers/CSharp/Test/Semantic/SourceGeneration/GeneratorDriverTests.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Andrew Hall <ryzngard@live.com>
cston
approved these changes
Jun 24, 2021
046a23b to
0d43516
Compare
333fred
added a commit
that referenced
this pull request
Jun 25, 2021
…ures/caller-argument-expression * upstream/main: (492 commits) Add nullable ref annotations to SyntaxFactory (#54199) Add 'replace' APIs and hook them up to the IDE (#54270) Allow implicit implementation of non-public interface members (#54182) Make insertion a stage of the official build (#54376) Cleanup Remove unused property Simplify glyph computation Report all-empty top level statements. (#54385) Calculate TypeParameterKind based on the container type (#54200) vert not roaming Split tests Multple matches Report as we get results Fixup tests Update tests Avoid thread dependency in VirtualMemoryNotificationListener constructor Fast progression search. Add LanguageVersion 10 (#54359) Sure, why not ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds missing source generator APIs
Fixes #54087