Add IVT for UnitTestingHostReloadService#54366
Merged
davidwengier merged 3 commits intodotnet:mainfrom Jun 25, 2021
Merged
Conversation
Member
vritant24
commented
Jun 24, 2021
- Add IVT to use the UnitTestingHostReloadService
- Update API to give a list of capabilities
- Update API to dictate whether or not to commit updates
Member
Author
|
tagging @tmat |
tmat
reviewed
Jun 24, 2021
src/Features/Core/Portable/ExternalAccess/UnitTesting/API/UnitTestingHotReloadService.cs
Outdated
Show resolved
Hide resolved
tmat
reviewed
Jun 24, 2021
src/Features/Core/Portable/ExternalAccess/UnitTesting/API/UnitTestingHotReloadService.cs
Outdated
Show resolved
Hide resolved
Member
Author
|
Addressed comments |
src/Features/Core/Portable/ExternalAccess/UnitTesting/API/UnitTestingHotReloadService.cs
Outdated
Show resolved
Hide resolved
…TestingHotReloadService.cs
davidwengier
approved these changes
Jun 25, 2021
Member
davidwengier
left a comment
There was a problem hiding this comment.
LGTM. Will merge once the build is green.
tmat
approved these changes
Jun 25, 2021
Member
Author
|
@davidwengier looks like the ci build failed due to an agent availability issue? Is there a way to re-run it? |
Member
|
Done |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.