Add new navigation pattern for Value Tracking#54163
Conversation
| item.Parent = parent; | ||
| } | ||
| } | ||
| }; |
There was a problem hiding this comment.
Call me old, but a 20 line lambda with a local function should probably just be a method 😛
There was a problem hiding this comment.
maybe... you don't always know when you start writing it :P
| { | ||
| if (sender is TreeViewItemBase viewModel) | ||
| { | ||
| SelectItem(viewModel, true); |
There was a problem hiding this comment.
Shouldn't this also expand, based on your table?
There was a problem hiding this comment.
Actually, I think the table is wrong here. Imo clicking on an item shouldn't expand at all. Open to feedback on that behavior though
There was a problem hiding this comment.
Updated table to reflect this behavior as written
There was a problem hiding this comment.
As the person who made double click on a project file open the editor, and not expand/collapse, I get the logic of it and support you, but you should probably expect feedback too :)
There was a problem hiding this comment.
I believe double-clicking in Test Explorer would do an expansion. And I just know solution explorer does a different thing😮
Co-authored-by: David Wengier <david.wengier@microsoft.com>
|
I personally do think arrow up, arrow down, and single click should navigate to source. We should keep behavior consistent with other results windows like Find All References and shouldn't add keyboard friction which can cause the experience to be less seamless for users. Can we revert those options back to true and monitor feedback once we release it in preview 2? |
…github.com/ryzngard/roslyn into feature/value_tracking_tree_navigation
|
I've changed the table to match Mika's request and updated the code. If we get more user feedback on wanting this to be different we will reevaluate. |
Value tracking originally used the standard WPF navigation pattern. This would also navigate to the source line based on selection.
This improves the design by manually handling keyboard navigation for most cases. By default, if an item is selected it no longer navigates to source. There are conditions where this is different:
Resolves #53821