Refresh features/list-patterns with latest bits from main branch#53937
Refresh features/list-patterns with latest bits from main branch#53937jcouv merged 2271 commits intodotnet:features/list-patternsfrom
features/list-patterns with latest bits from main branch#53937Conversation
Fix out of bound crash in lsp navto.
These should have been left as is as a part of 299d55d, as this otherwise created breaking API changes.
…o-main Merge release/dev16.11 to main
Only require telemetry validation in CI
…pi-break Revert changes to TypeScriptWaitContext wrappers
Port 'Fix out of bound crash in lsp navto' to dev 16.11
Ensure we do not need to go back to compilations/symbols when a user selects a navbar item.
…itorNavigationBarItemService.cs
…NavigationBarItemService_CodeGeneration.vb
Use simpler, less allocating immutable array helper.
Add line numbers to contract failures
Simplify navbar code further.
Gracefully fail when resolving unsupported symbolkeys in VB
…release/dev16.11-to-main
…o-main Merge release/dev16.11 to main
| { | ||
| <<<<<<< HEAD | ||
| ======= | ||
| CheckImplicitThisCopyInReadOnlyMember(receiverOpt, lengthOrCountProperty.GetMethod, diagnostics); |
There was a problem hiding this comment.
This call to CheckImplicitThisCopyInReadOnlyMember turned out unnecessary because the caller (for indexing via this[int]) already reported exactly the same diagnostic (see line 7932 above in diff).
Note that the other caller is for list-patterns (TryFindIndexerOrIndexerPattern in Binder_Patterns.cs). Added a test for that scenario (PatternIndexRangeReadOnly_01) but I don't think it should report this diagnostic anyway because the indexer access is off of a special receiver for patterns... CheckImplicitThisCopyInReadOnlyMember only reports when the receiver is this.
| ======= | ||
| CheckImplicitThisCopyInReadOnlyMember(receiverOpt, lengthOrCountProperty.GetMethod, diagnostics); | ||
| ReportDiagnosticsIfObsolete(diagnostics, property, syntax, hasBaseReceiver: false); | ||
| ReportDiagnosticsIfObsolete(diagnostics, lengthOrCountProperty, syntax, hasBaseReceiver: false); |
There was a problem hiding this comment.
Moved this check to caller (line 7934 above) for binding indexer.
For binding list-patterns we still have a PROTOTYPE marker tracking this in test ListPattern_ObsoleteMembers.
The last commit resolves the conflicts: 6470f61
FYI @alrz