Simplify navbar code further.#53898
Merged
CyrusNajmabadi merged 4 commits intodotnet:mainfrom Jun 7, 2021
Merged
Conversation
CyrusNajmabadi
commented
Jun 5, 2021
| } | ||
| // We only show items in gray when near that actually exist (i.e. are not meant for codegen). | ||
| // This will be all C# items, and only VB non-codegen items. | ||
| return ((WrappedNavigationBarItem)item).UnderlyingItem is SymbolItem; |
Contributor
Author
There was a problem hiding this comment.
this was just pulling the VB impl up to the VB/C# shared impl. It's the same effective logic for both.
CyrusNajmabadi
commented
Jun 5, 2021
| { | ||
| var notificationService = workspace.Services.GetRequiredService<INotificationService>(); | ||
| notificationService.SendNotification(EditorFeaturesResources.The_definition_of_the_object_is_hidden, severity: NotificationSeverity.Error); | ||
| } |
Contributor
Author
There was a problem hiding this comment.
had this code already. So removed the duplicated method and had the caller just call into the otehr impl.
CyrusNajmabadi
commented
Jun 5, 2021
src/EditorFeatures/Core/Extensibility/NavigationBar/AbstractEditorNavigationBarItemService.cs
Outdated
Show resolved
Hide resolved
…itorNavigationBarItemService.cs
CyrusNajmabadi
commented
Jun 5, 2021
...atures/VisualBasic/NavigationBar/VisualBasicEditorNavigationBarItemService_CodeGeneration.vb
Outdated
Show resolved
Hide resolved
…NavigationBarItemService_CodeGeneration.vb
dibarbet
approved these changes
Jun 7, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.