Revert changes to TypeScriptWaitContext wrappers#53498
Merged
jasonmalinowski merged 1 commit intodotnet:mainfrom May 19, 2021
Merged
Revert changes to TypeScriptWaitContext wrappers#53498jasonmalinowski merged 1 commit intodotnet:mainfrom
jasonmalinowski merged 1 commit intodotnet:mainfrom
Conversation
333fred
reviewed
May 18, 2021
src/EditorFeatures/Core/ExternalAccess/VSTypeScript/Api/VSTypeScriptWaitContextWrapper.cs
Outdated
Show resolved
Hide resolved
These should have been left as is as a part of 299d55d, as this otherwise created breaking API changes.
046bda4 to
6864a68
Compare
davidwengier
approved these changes
May 18, 2021
genlu
approved these changes
May 18, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These should have been left as is as a part of 299d55d, as this otherwise created breaking API changes.