Fix out of bound crash in lsp navto.#53495
Merged
CyrusNajmabadi merged 2 commits intodotnet:mainfrom May 18, 2021
Merged
Conversation
dibarbet
approved these changes
May 18, 2021
CyrusNajmabadi
commented
May 18, 2021
| // to. | ||
| span = TextSpan.FromBounds( | ||
| Math.Min(text.Length, span.Start), | ||
| Math.Min(text.Length, span.End)); |
Contributor
Author
There was a problem hiding this comment.
stale results are possible as of: #52380
Member
There was a problem hiding this comment.
Do we have the same clamping happening in the non-LSP implementation as well? Is there way to unify that?
Contributor
Author
There was a problem hiding this comment.
yes, we do. i'll see if i can share the code somehow.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #53493