Add line numbers to contract failures#53916
Merged
CyrusNajmabadi merged 1 commit intodotnet:mainfrom Jun 7, 2021
Merged
Conversation
Cosifne
approved these changes
Jun 7, 2021
Member
|
@CyrusNajmabadi: nice! We should have done this years ago. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #53706
The goal here is to make it easier to investigate reports where we get a failure report where we get nothing more than:
Unexpectedin a particular method. When there is just a singleContract.ThrowIfNullin that method, then the issue is obvious. However, when tehre are several contract calls, it can be extremely difficult to tell which one actually failed. By adding the line number we can vastly improve understanding what has failed, without needing a dump.