Skip to content

Merge features/covariant-returns to master#44447

Merged
gafter merged 161 commits intomasterfrom
features/covariant-returns
Jul 31, 2020
Merged

Merge features/covariant-returns to master#44447
gafter merged 161 commits intomasterfrom
features/covariant-returns

Conversation

@gafter
Copy link
Member

@gafter gafter commented May 20, 2020

No description provided.

msftbot[bot] and others added 30 commits April 15, 2020 18:22
Merge master to features/covariant-returns
…e language version.

Note that we now consider a get accessor with the wrong return type to still be an override.
Issue language version suggestion when covariant returns feature would permit the override.
Merge master to features/covariant-returns
Merge master to features/covariant-returns
…able.

- Add test for override properties with setters.
- Test relaxed rules for override in source vs a metadata base type.
Merge master to features/covariant-returns
…riding method.

Ensure that the overriden-symbol API behaves the same with or without the featue.
…iant-returns

Merge master to features/covariant-returns
…e have a place to put necessary support library declarations.
…iant-returns

Merge master to features/covariant-returns
Neal Gafter and others added 10 commits July 24, 2020 15:37
…iant-returns

Merge master to features/covariant-returns
…iant-returns

Merge master to features/covariant-returns
…iant-returns

Merge master to features/covariant-returns
This updates our build to support the use of `net5.0` as a target
framework inside of our repository.

Note: this is back porting some changes from the covariant returns
branch. Wanted to get them into master sooner so we get more exposure to
them.
Check in simple end-to-end test for covariant returns on net5.0
Neal Gafter and others added 4 commits July 29, 2020 09:02
…iant-returns

Merge master to features/covariant-returns
…ant returns (#46367)

* Adjust overload resolution to handle explicit overrides that skip inheritance steps in binary compat scenarios
   Fixes #45798
* Skip a flaky test.
   Relates to #46361
@gafter gafter removed the PR For Personal Review Only The PR doesn’t require anyone other than the developer to review it. label Jul 30, 2020
@gafter gafter marked this pull request as ready for review July 30, 2020 20:36
@gafter gafter requested a review from a team as a code owner July 30, 2020 20:36
@ghost
Copy link

ghost commented Jul 30, 2020

Hello @gafter!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approval

…iant-returns

Merge master to features/covariant-returns
@ghost ghost removed the auto-merge label Jul 31, 2020
@gafter gafter merged commit 6a38986 into master Jul 31, 2020
@ghost ghost modified the milestones: 16.8, Next Jul 31, 2020
RikkiGibson added a commit that referenced this pull request Aug 4, 2020
@RikkiGibson RikkiGibson modified the milestones: Next, 16.8.P2 Aug 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants