Merge features/covariant-returns to master#44447
Merged
Conversation
Merge master to features/covariant-returns
…e language version. Note that we now consider a get accessor with the wrong return type to still be an override. Issue language version suggestion when covariant returns feature would permit the override.
…ant-returns-merge-2020-04-22
Merge master to features/covariant-returns
…t/roslyn into covariant-returns-part1
…ant-returns-merge-2020-04-24
…ant-returns-merge-2020-04-24
Merge master to features/covariant-returns
…t/roslyn into covariant-returns-part1
Covariant returns part1
…able. - Add test for override properties with setters. - Test relaxed rules for override in source vs a metadata base type.
…ant-returns-merge-2020-04-27
Merge master to features/covariant-returns
…riding method. Ensure that the overriden-symbol API behaves the same with or without the featue.
…ures/covariant-returns
…iant-returns Merge master to features/covariant-returns
Covariant returns part 2
…e have a place to put necessary support library declarations.
…iant-returns Merge master to features/covariant-returns
…iant-returns Merge master to features/covariant-returns
…iant-returns Merge master to features/covariant-returns
…iant-returns Merge master to features/covariant-returns
…t/roslyn into covariant-returns-e2e1
…hat is what is breaking the tests.
This updates our build to support the use of `net5.0` as a target framework inside of our repository. Note: this is back porting some changes from the covariant returns branch. Wanted to get them into master sooner so we get more exposure to them.
Check in simple end-to-end test for covariant returns on net5.0
…features/covariant-returns
…iant-returns Merge master to features/covariant-returns
…features/covariant-returns
|
Hello @gafter! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
…iant-returns Merge master to features/covariant-returns
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.