Skip to content

Remove feature flag used for testing "DoNotRequireRuntimeCovariantReturnsSupport"#46390

Merged
gafter merged 1 commit intodotnet:features/covariant-returnsfrom
gafter:covariant-returns-44206
Jul 29, 2020
Merged

Remove feature flag used for testing "DoNotRequireRuntimeCovariantReturnsSupport"#46390
gafter merged 1 commit intodotnet:features/covariant-returnsfrom
gafter:covariant-returns-44206

Conversation

@gafter
Copy link
Member

@gafter gafter commented Jul 28, 2020

Fixes #44206
This also tests the runtime behavior of code generated by the VB compiler that interacts with C# covariant methods.

@gafter gafter requested a review from a team as a code owner July 28, 2020 19:35
@gafter gafter self-assigned this Jul 28, 2020
@gafter gafter added Area-Compilers Feature - Covariant Returns Permit an override to return a more specific reference type labels Jul 28, 2020
@gafter gafter added this to the 16.8 milestone Jul 28, 2020

/// <summary>
/// Figure out if the target runtime supports covariant returns of methods declared in classes.
/// True if the target runtime support covariant returns of methods declared in classes.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo: supports

Copy link
Member

@jcouv jcouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks (iteration 1)

@jcouv jcouv self-assigned this Jul 29, 2020
@gafter gafter requested a review from a team July 29, 2020 15:06
@RikkiGibson
Copy link
Member

Taking a look

@gafter gafter merged commit 5a7b591 into dotnet:features/covariant-returns Jul 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area-Compilers Feature - Covariant Returns Permit an override to return a more specific reference type

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants