Skip to content

Merge master to features/covariant-returns#43654

Merged
59 commits merged intodotnet:features/covariant-returnsfrom
gafter:covariant-returns-merge-2020-04-24
Apr 24, 2020
Merged

Merge master to features/covariant-returns#43654
59 commits merged intodotnet:features/covariant-returnsfrom
gafter:covariant-returns-merge-2020-04-24

Conversation

@gafter
Copy link
Member

@gafter gafter commented Apr 24, 2020

No description provided.

CyrusNajmabadi and others added 30 commits April 16, 2020 12:09
…ing build

Closes dotnet#42166

This PR is aimed towards improving the build performance in presence of analyzers that report Info (Suggestion) and/or Hidden diagnostics. Hidden diagnostics are never reported in build and Info diagnostics are only officially supported in presence of /errorlog, we will retain this support. The command line compilers do report Info diagnostics on command line today, but these are filtered away by MSBuild and are effectively never visible to users. This makes this a non-breaking scenario in .NET core build environment and an extreme corner case breaking change on desktop (clients relying on info diagnostics from raw csc/vbc output). Note that such clients would still have a workaround to get the prior behavior by enabling /errorlog.

This optimization should improve build performance when users install the new IDE CodeStyle NuGet package (mostly hidden diagnostics) and the upcoming .NET5 analyzers package (has large number of info/hidden diagnostics).
…-master

Merge release/dev16.6 to master
* Revert "Fixed the expected backslash in the Compiler Tests for Anonymous Types (dotnet#43211)"

This reverts commit efa12f7.

* Add a comment

* Update AnonymousType.TemplateSymbol.cs

* Fix whitespace
* Remove unused code

* Conditional using
* AssetStorage cleanup

* Test fixes
tmat and others added 16 commits April 23, 2020 12:33
Validate FunctionId does not contain duplicate values
Ensure that TS can report todo comments even prior to us having connected to the OOP server.
Simplifications to help moving rename entirely OOP.
Improves build performance by allowing VBCSCompiler.exe to service all
build requests for Roslyn.sln.
Disable failing IntelliSense integration tests
…SymbolToProjectId.cs

Co-Authored-By: Sam Harwell <sam@tunnelvisionlabs.com>
Skip execution of analyzers reporting info and hidden diagnostics dur…
Fix rename test flakeyness with dynamic types.
Use the same analyzer version in the Code Style layer as elsewhere
@gafter gafter added Area-Compilers Feature - Covariant Returns Permit an override to return a more specific reference type labels Apr 24, 2020
@gafter gafter added this to the Compiler.Net5 milestone Apr 24, 2020
@gafter gafter requested review from a team as code owners April 24, 2020 17:57
@gafter gafter requested a review from a team April 24, 2020 17:57
@gafter gafter self-assigned this Apr 24, 2020
msftbot[bot] and others added 3 commits April 24, 2020 18:10
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approval

@ghost ghost merged commit ec9c30e into dotnet:features/covariant-returns Apr 24, 2020
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area-Compilers auto-merge Feature - Covariant Returns Permit an override to return a more specific reference type

Projects

None yet

Development

Successfully merging this pull request may close these issues.