Validate FunctionId does not contain duplicate values#43608
Merged
jasonmalinowski merged 1 commit intodotnet:masterfrom Apr 23, 2020
Merged
Validate FunctionId does not contain duplicate values#43608jasonmalinowski merged 1 commit intodotnet:masterfrom
jasonmalinowski merged 1 commit intodotnet:masterfrom
Conversation
JoeRobich
approved these changes
Apr 23, 2020
CyrusNajmabadi
approved these changes
Apr 23, 2020
7ec02b2 to
39863f3
Compare
jasonmalinowski
approved these changes
Apr 23, 2020
| var value = (FunctionId)Enum.Parse(typeof(FunctionId), name); | ||
| if (map.TryGetValue(value, out var existingName)) | ||
| { | ||
| Assert.True(false, $"'{nameof(FunctionId)}.{name}' cannot have the same value as '{nameof(FunctionId)}.{existingName}'"); |
Member
There was a problem hiding this comment.
Suggested change
| Assert.True(false, $"'{nameof(FunctionId)}.{name}' cannot have the same value as '{nameof(FunctionId)}.{existingName}'"); | |
| throw new Exception($"'{nameof(FunctionId)}.{name}' cannot have the same value as '{nameof(FunctionId)}.{existingName}'"); |
Otherwise you get a lot of head scratching as to why we expected true and got false.
Contributor
Author
There was a problem hiding this comment.
This is the official xUnit pattern for Assert.Fail.
https://xunit.net/docs/comparisons.html
Member
There was a problem hiding this comment.
Oh really I had always thought the advice was indeed just throw.
Member
|
Overriding the CI checks as we're seeing some failures do this this; there more things to unpack but this we know needs to be fixed regardless. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #43607