Skip to content

Use the same analyzer version in the Code Style layer as elsewhere#43629

Merged
sharwell merged 2 commits intodotnet:masterfrom
sharwell:analyzer-version
Apr 24, 2020
Merged

Use the same analyzer version in the Code Style layer as elsewhere#43629
sharwell merged 2 commits intodotnet:masterfrom
sharwell:analyzer-version

Conversation

@sharwell
Copy link
Contributor

Improves build performance by allowing VBCSCompiler.exe to service all build requests for Roslyn.sln.

Improves build performance by allowing VBCSCompiler.exe to service all
build requests for Roslyn.sln.
@sharwell sharwell requested a review from a team as a code owner April 24, 2020 02:31
@CyrusNajmabadi
Copy link
Contributor

Oooh. this might help a lot. i've been seeing an issue where builds seem to kick of lots of csc processes. will this fix that?

@sharwell
Copy link
Contributor Author

@CyrusNajmabadi Yes, that is the issue which this fixes.

@sharwell sharwell merged commit 6c27cec into dotnet:master Apr 24, 2020
@ghost ghost added this to the Next milestone Apr 24, 2020
@sharwell sharwell deleted the analyzer-version branch April 24, 2020 14:26
@sharwell sharwell modified the milestones: Next, temp, 16.7.P1 Apr 28, 2020
jaredpar added a commit to jaredpar/roslyn that referenced this pull request May 4, 2020
This changes the bootstrap compiler to enforce that our build doesn't
suffer from analyzer consistency issues. This will prevent us from
introducing build performance issues into the repository in the future.
Essentially adding enforcement to make sure that PRs like dotnet#43629 won't
ever be necessary again.

Related to dotnet#43629
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants